Add a presubmit to the build repo to smoke test a buildbot slave |
||
Issue descriptionWe want to check it starts up and makes a connection to a master.
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d00ee5ad93ab3f2b24f9479ed6e381b5b800ef2f commit d00ee5ad93ab3f2b24f9479ed6e381b5b800ef2f Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Apr 11 20:04:51 2017 Revert "Add a smoke test for run_slave.py." This reverts commit 7e26e839fa1265eac7987f22792e3a8d876f8878. Reason for revert: Broke internal presubmit. See https://bugs.chromium.org/p/chromium/issues/detail?id=710569 Original change's description: > Add a smoke test for run_slave.py. > > This starts a TCP server that pretends to be a buildbot master, then > starts run_slave.py and expects it to connect to our server. > > Bug: 699407 > Change-Id: I6875897960268878fcffdb8580131d9bfa021a67 > Reviewed-on: https://chromium-review.googlesource.com/470826 > Commit-Queue: Dave Sansome <dsansome@chromium.org> > Reviewed-by: Scott Lee <ddoman@google.com> > TBR=vadimsh@chromium.org,dsansome@chromium.org,ddoman@google.com,mmoss@chromium.org,chromium-reviews@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I0f95b6d1aca155db86ea5a0c418a0d2a9c378a4f Reviewed-on: https://chromium-review.googlesource.com/474984 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [delete] https://crrev.com/b0090c323ae033185b1f6d8b27f961664c84fecc/tests/slave_test.py
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/2c2e20b378623f4d406d0583018ea6a674e0ea11 commit 2c2e20b378623f4d406d0583018ea6a674e0ea11 Author: David Sansome <dsansome@chromium.org> Date: Wed Apr 12 05:35:01 2017 Add a smoke test for run_slave.py. This is a re-land of https://chromium-review.googlesource.com/c/470826/ Now it works for build_internal too. build_internal has a config_private.py higher on the PYTHONPATH than our one, so this test now writes a site.py that explicitly imports ours. Bug: 699407 Change-Id: I48e386e3f87e37939f6302a9183b66073b3ff2fa Reviewed-on: https://chromium-review.googlesource.com/475611 Reviewed-by: Scott Lee <ddoman@google.com> Commit-Queue: Dave Sansome <dsansome@chromium.org> [add] https://crrev.com/2c2e20b378623f4d406d0583018ea6a674e0ea11/tests/slave_test.py
,
Apr 12 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/2e29289db0169de0c7a28badde39b000c8219b54 commit 2e29289db0169de0c7a28badde39b000c8219b54 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Apr 12 15:18:20 2017 Revert "Add a smoke test for run_slave.py." This reverts commit 2c2e20b378623f4d406d0583018ea6a674e0ea11. Reason for revert: still blocks PRESUBMIT/CQ for internal repo Original change's description: > Add a smoke test for run_slave.py. > > This is a re-land of https://chromium-review.googlesource.com/c/470826/ > Now it works for build_internal too. build_internal has a config_private.py > higher on the PYTHONPATH than our one, so this test now writes a site.py that > explicitly imports ours. > > Bug: 699407 > Change-Id: I48e386e3f87e37939f6302a9183b66073b3ff2fa > Reviewed-on: https://chromium-review.googlesource.com/475611 > Reviewed-by: Scott Lee <ddoman@google.com> > Commit-Queue: Dave Sansome <dsansome@chromium.org> > TBR=dsansome@chromium.org,ddoman@google.com,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I77da37cfadcf5f61fa72ca4d151e088298b8afb5 Reviewed-on: https://chromium-review.googlesource.com/475773 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [delete] https://crrev.com/3646fbe6f4e294388b1ec755411600f0497fb12e/tests/slave_test.py
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d3c3fb83f87b375365639f05cef8786596003e96 commit d3c3fb83f87b375365639f05cef8786596003e96 Author: David Sansome <dsansome@chromium.org> Date: Thu Apr 27 03:42:08 2017 Add a smoke test for run_slave.py. This is a re-land of https://chromium-review.googlesource.com/c/475611/ which itself was a re-land of https://chromium-review.googlesource.com/c/470826/. This one sets a longer timeout for waiting for run_slave.py to start and connect to the master, as the builder running the build-internal-presubmit simply seems slower than the others... Bug:699407 Change-Id: I8ca43ce0d1e495f612f4943f8f01f7efb4fac280 Reviewed-on: https://chromium-review.googlesource.com/482740 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Dave Sansome <dsansome@chromium.org> [add] https://crrev.com/d3c3fb83f87b375365639f05cef8786596003e96/tests/slave_test.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 10 2017