New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 699403 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Glimpse of blue focus ring is seen after pressing 'Enter' key in chrome://md-settings/searchEngines.

Reported by mni...@etouch.net, Mar 8 2017 
Version: 59.0.3033.0 264668d2881277a13cd9a52c6a26b592b3502fbd-refs/heads/master@{#455023}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/searchEngines
2. Now press 'Tab' key to bring blue focus ring on default search engine name in the list.
3. Now again press 'Tab' key to bring focus on 'iron icon' and press 'Enter' key,observe over the default search engine name.

Actual: Glimpse of blue focus ring is seen over default search engine name after pressing 'Enter' key
Expected: Glimpse of blue focus ring should not be seen over default search engine name after pressing 'Enter' key

This is regression issue, broken in ‘M 56’ and will soon update other info :
Good build:56.0.2891.0
Bad build: 56.0.2894.0
Actual_video.mov
2.7 MB Download
Expected_video.mp4
247 KB View Download

Comment 1 by mni...@etouch.net, Mar 8 2017

Labels: hasbisect
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/b9893ae730d1ffb08fad82862e93a371086d13a5..746078e0517a27285eb253fc847453e301e98a3e?pretty=fuller&n=100

Suspecting: r425534 from Narrow bisect

@dpapad : Could you please help to reassign if your change is not the cause for this change.

Comment 2 by ranjitkan@chromium.org, Mar 8 2017 

All the builds generated using per revision bisect were providing only good builds, tried changing the revisions as well. Hence used the normal bisect to narrow down.

Thanks.!

Comment 3 by dpa...@chromium.org, Mar 8 2017

Cc: dpa...@chromium.org
Labels: Proj-MaterialDesign-WebUI
Owner: scottchen@chromium.org
The bisect is not accurate (it goes back a few months), when in fact it is https://codereview.chromium.org/2700863002 who affected this behavior.

@scottchen: Can you take  a look? I was able to reproduce this.

Comment 4 by scottchen@chromium.org, Mar 10 2017

Status: Started (was: Assigned)

Comment 5 by tbuck...@chromium.org, Mar 13 2017

Labels: Hotlist-MD-Settings-SearchEngines
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b520415c483d14ee79d8fb82accc63aedd78b755

commit b520415c483d14ee79d8fb82accc63aedd78b755
Author: scottchen <scottchen@chromium.org>
Date: Wed Mar 15 00:44:20 2017

MD Settings: fix unnecessary focus on list items.

BUG= 699403 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745653003
Cr-Commit-Position: refs/heads/master@{#456921}

[modify] https://crrev.com/b520415c483d14ee79d8fb82accc63aedd78b755/chrome/browser/resources/settings/focusable_iron_list_item_behavior.js
[modify] https://crrev.com/b520415c483d14ee79d8fb82accc63aedd78b755/chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js

Comment 7 by scottchen@chromium.org, Mar 16 2017

Status: Fixed (was: Started)
►

Sign in to add a comment