Manual bisect:
Good build: 59.0.3032.0 
Bad build: 59.0.3033.0 

Note: Issue is not seen on Mac and Linux OS.

Deleted: bookmark_actual.jpg 86.2 KB

	bookmark_actual.jpg 86.2 KB View Download

Using the per-revision bisect providing the bisect results,
Good build:59.0.3032.0 (Revision: 454806).
Bad build:59.0.3033.0  (Revision: 455023).

You are probably looking for a change made after 454818 (known good), but no later than 454824 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/42bca36878d20e2bf6f27fb091d61d01ddc516a9..f4c976fc1f4578b0c75ba304553ef2ff6134f551

From the CL above, assigning the issue to the concern owner

@tapted : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2706423002

Note:Unable to provide the per revision bisect due to more CL's are coming in per revision bisect level so providing normal bisect.Windows specific issue and Able to reproduce in latest Canary #58.0.3033.0.Adding Release Block-Dev for this issue.Please remove if not the case.

https://codereview.chromium.org/2737913002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ffcf3d8575a7cea0a759b7df23e5b45138ed0dd

commit 1ffcf3d8575a7cea0a759b7df23e5b45138ed0dd
Author: Trent Apted <tapted@chromium.org>
Date: Wed Mar 08 13:04:15 2017

Fix missing buttons on the Edit Bookmark dialog.

This regressed in r454823.

The buttons disappear because a spurious Layout() is triggered when
adding a LabelButton as an extra view on Windows. The GridLayout is
still being set up at this point, so the Layout attempt gets horribly
confused and thinks the button row only needs to be a few pixels high.

The Layout() results when the views::Label inside the dialog's extra
view does a PreferredSizeChanged() when shadows are added to the text on
Windows. MD text buttons do not have shadows, and Mac and Linux never
have text shadows, so they are not affected.

Fix by extending the scope of a bool that tracks when DialogClientView
is manipulating the view hierarchy, and ignore calls to
ChildPreferredSizeChanged() in that case.

BUG= 699390 
TEST=On Windows, right-click a bookmark and select "Edit". The dialog
should have buttons.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2737913002 .
Cr-Commit-Position: refs/heads/master@{#455438}

[modify] https://crrev.com/1ffcf3d8575a7cea0a759b7df23e5b45138ed0dd/ui/views/window/dialog_client_view.cc
[modify] https://crrev.com/1ffcf3d8575a7cea0a759b7df23e5b45138ed0dd/ui/views/window/dialog_client_view.h

Fixed + checked 59.0.3036 canary. I'll follow up in  Issue 699912  about adding guards against this kind of craziness.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d775162580774ccfaed86a8dcf2ac6564198d93

commit 4d775162580774ccfaed86a8dcf2ac6564198d93
Author: tapted <tapted@chromium.org>
Date: Tue Mar 14 06:41:32 2017

GridLayout: Guard against layout queries while adding a view.

Adds a DCHECK to GridLayout to ensure client code doesn't ask it to
perform layout calculations while inside GridLayout::AddViewState().
GridLayout has not yet updated its internal data structures, so it can
only give invalid results at this point.

Adds a BrowserDialogTest for the edit bookmark view which would have
triggered this DCHECK without the fix in r455438.

Adds a DCHECK_DEATH test for GridLayout.

BUG= 699912 ,  699390 

Review-Url: https://codereview.chromium.org/2743743003
Cr-Commit-Position: refs/heads/master@{#456638}

[add] https://crrev.com/4d775162580774ccfaed86a8dcf2ac6564198d93/chrome/browser/ui/views/bookmarks/bookmark_editor_view_browsertest.cc
[modify] https://crrev.com/4d775162580774ccfaed86a8dcf2ac6564198d93/chrome/test/BUILD.gn
[modify] https://crrev.com/4d775162580774ccfaed86a8dcf2ac6564198d93/ui/views/layout/grid_layout.cc
[modify] https://crrev.com/4d775162580774ccfaed86a8dcf2ac6564198d93/ui/views/layout/grid_layout_unittest.cc

Tested the issue on Windows-7 using chrome version#59.0.3043.0 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!

Deleted: 699390.mp4 278 KB

	699390.mp4 278 KB View Download