New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699384 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 699394



Sign in to add a comment

PlzNavigate fails process bindings tests

Project Member Reported by cblume@chromium.org, Mar 8 2017

Issue description

The process bindings tests
org.chromium.chrome.browser.BindingManagerIntegrationTest#testRestoreSharedRenderer
org.chromium.chrome.browser.BindingManagerIntegrationTest#testCrashInForeground
are failing on Chromium for Android with PlzNavigate.

To repro,
$ git cl patch 2385413004   // this forces PlzNavigate without requiring a switch
$ ./out/Debug/bin/run_chrome_public_test_apk_incremental -f "*RestoreSharedRenderer*"
// or "*CrashInForeground*"
 
Blocking: 699394
Owner: shaktisahu@chromium.org
Status: Assigned (was: Available)
Cc: mariakho...@chromium.org
Copying from offline conversation with John and Maria. 

Found a suspected place what could be the reason the following test fails org.chromium.chrome.browser.BindingManagerIntegrationTest#testCrashInForeground (line : 401)

In this test, we load a URL in a tab, crash it intentionally and reload it again.

In non-PlzNavigate mode, when a new renderer is starting after the crash, we call RenderWidgetHostView::Show.
https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_manager.cc?rcl=062df28033e325db34be74c68da1f2bec888229d&l=258

I don't see that called for PlzNavigate mode. Not sure what is expected here.

As a result, we get to the following state in PlzNavigate mode with should_background = true and hence the new render process is not foregrounded.
https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_process_host_impl.cc?rcl=11e28fd6b9380b77273db51ef0b6ccc7ea341944&l=2831
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e

commit 8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e
Author: jam <jam@chromium.org>
Date: Fri Mar 17 00:34:14 2017

Ensure that with PlzNavigate, reloads after process crash display the RenderView.

BUG= 699384 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2753093002
Cr-Commit-Position: refs/heads/master@{#457626}

[modify] https://crrev.com/8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e/chrome/browser/crash_recovery_browsertest.cc
[modify] https://crrev.com/8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e/content/browser/frame_host/render_frame_host_manager.h

Comment 5 by jam@chromium.org, Mar 17 2017

I fixed the issue noted, but the BindingManagerIntegrationTest#testCrashInForeground still fails on android. Can you take a look?
Thanks!

I had to fix the tests little bit to wait till the loading is complete. After that these two tests seem to pass. I will upload a CL shortly.

CL in progress: https://codereview.chromium.org/2759663003
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a627a2107cb27b4707f1f3b4c741636d8b7c5ace

commit a627a2107cb27b4707f1f3b4c741636d8b7c5ace
Author: shaktisahu <shaktisahu@chromium.org>
Date: Sat Mar 18 21:06:22 2017

Fixed process binding tests

Changed tests to wait for tab getting loaded completely after a reload.

BUG= 699384 

Review-Url: https://codereview.chromium.org/2759663003
Cr-Commit-Position: refs/heads/master@{#457979}

[modify] https://crrev.com/a627a2107cb27b4707f1f3b4c741636d8b7c5ace/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

Status: Fixed (was: Assigned)

Comment 9 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment