Issue metadata
Sign in to add a comment
|
PlzNavigate fails webapp mode tests |
||||||||||||||||||||||||
Issue descriptionThe webapp mode tests org.chromium.chrome.browser.webapps.WebappModeTest#testWebappHandlesWindowOpenInTabbedMode org.chromium.chrome.browser.webapps.WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode are failing on Chromium for Android with PlzNavigate. To repro, $ git cl patch 2385413004 // this forces PlzNavigate without requiring a switch $ ./out/Debug/bin/run_chrome_public_test_apk_incremental -f "*WebappHandles*"
,
Mar 9 2017
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fd7349089bc194ac6a08af6f94298987629dd9b commit 6fd7349089bc194ac6a08af6f94298987629dd9b Author: shaktisahu <shaktisahu@chromium.org> Date: Fri Mar 10 17:51:44 2017 Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indicator of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests that are failing when PlzNavigate mode enabled. WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG= 699383 Review-Url: https://codereview.chromium.org/2742963002 Cr-Commit-Position: refs/heads/master@{#456097} [modify] https://crrev.com/6fd7349089bc194ac6a08af6f94298987629dd9b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java
,
Mar 10 2017
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by cblume@chromium.org
, Mar 8 2017