New issue
Advanced search Search tips

Issue 699380 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 699394



Sign in to add a comment

PlzNavigate fails tab theme color tests

Project Member Reported by cblume@chromium.org, Mar 8 2017

Issue description

The tab theme color test
org.chromium.chrome.browser.TabThemeTest#testThemeColorIsCorrect
is failing on Chromium for Android with PlzNavigate.

To repro,
$ git cl patch 2385413004   // this forces PlzNavigate without requiring a switch
$ ./out/Debug/bin/run_chrome_public_test_apk_incremental -f "*TabTheme*"
 
Blocking: 699394
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d65eda07d21cff0513ba84c90fc9b29fa53577

commit b7d65eda07d21cff0513ba84c90fc9b29fa53577
Author: wychen <wychen@chromium.org>
Date: Thu Mar 09 20:17:19 2017

Use the correct observer in TabThemeTest

It's flaky without this fix, and the probability of failing would be
much higher if PlzNavigate is enabled.

BUG= 699380 

Review-Url: https://codereview.chromium.org/2738093002
Cr-Commit-Position: refs/heads/master@{#455849}

[modify] https://crrev.com/b7d65eda07d21cff0513ba84c90fc9b29fa53577/chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java

Status: Fixed (was: Started)

Comment 5 by jam@chromium.org, Mar 9 2017

Thanks!

Comment 6 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 7 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment