kitchen takes hard dependency on recipe-py's package.proto, doesn't respect backwards-compatible changes |
||||||
Issue descriptionBecause recipe engine uses textproto for recipes.cfg, and the textproto parser doesn't ignore unrecognized fields, kitchen explodes if it can't fully parse recipes.cfg (using whichever flavor of hard-coded package.proto it knows about). This is surprising, and can lead to breakages. Packages.proto should behave like any other proto: backwards compatible changes (such as field additions) should be compatible with kitchen. I think the way we can solve this is by switching recipes.cfg from textproto to jsonproto (whose parser behaves in the non-surprising way).
,
Mar 8 2017
Ugh... jsonpb parser also doesn't ignore fields. HOWEVER!!! If we switch to jsonpb, then kitchen can parse recipes.cfg like this: https://play.golang.org/p/XdcZ2Y_aVL Which would behave much better.
,
Mar 8 2017
Yes!
,
Mar 8 2017
an additional benefit of doing this is that the copypasta recipes.py will be able to remove about half of its hacky code too. Ok, here's the lists of repos that will need to change, I think: * https://github.com/luci/recipes-py/ * https://chromium.googlesource.com/chromium/tools/build/ * https://chromium.googlesource.com/chromium/tools/depot_tools/ * https://chromium.googlesource.com/infra/infra/ * https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave * https://fuchsia.googlesource.com/infra * https://chrome-internal.googlesource.com/chrome/tools/release/scripts * https://skia.googlesource.com/skia * https://skia.googlesource.com/buildbot
,
Mar 8 2017
SGTM, yeah!
,
Mar 8 2017
,
Mar 8 2017
dirk pointed out that there's a larger issue of using textproto for config files in our system if they can't easily be extended. Internally, google recommends against ignoring unknown text fields (as they might be typos), and compiling everything to binary protos. I don't think that's generally an option for our system at large right now, but running lint checks is. So I think what I'm going to try is writing a textproto parser which knows how to ignore unknown fields (as an option), and then also add lint checks to the recipe engine so that it can validate that every field in the proto is known to the latest version of the proto (thus catching spelling mistakes). I think that would allow us to decouple milo and kitchen from the recipe engine, while not losing the benefit of spellchecking these files. Basically the recipe engine itself will never ignore fields, but external systems (milo, kitchen) will.
,
Mar 8 2017
(in which case none of these repos will need to change)
,
Mar 8 2017
(conversation still ongoing in ML though, this could change back again)
,
Mar 8 2017
Back to json :). Maintaining a custom parser would be not worth it, and: * we don't need comments in this file (if we do, we could add a comment string field to the proto) * switching this particular file to json doesn't imply the need to do so for any other text proto files in the fleet (since we use a more traditional rollout process for services that consume those files, and so there's no issue with unknown fields since all the services already know about those fields).
,
Mar 8 2017
Sounds good. I agree that it's a good idea for recipes.cfg and probably not for many others.
,
Mar 9 2017
Actually I'm a dummy. jsonpb (both in python and go) has an option to ignore unknown fields :) https://godoc.org/github.com/golang/protobuf/jsonpb#Unmarshaler
,
Mar 9 2017
Oh well that's just the best of both worlds!
,
Mar 9 2017
it's not just whether or not the parser will ignore and skip over an unknown field, but also that if you then attempt to modify the data and write it back out, the unknown field will be dropped. I.e., you can't round-trip a message with unknown fields. Again, maybe not a problem for this particular scenario, though.
,
Mar 9 2017
Yeah the thing that round-trips the data (engine) is always at the highest version of the .proto, I should have mentioned that. Only read-only systems need to ignore fields.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/054be2c5e4f94f6529e3b89087b695d6db6dbfcf commit 054be2c5e4f94f6529e3b89087b695d6db6dbfcf Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 09 23:49:55 2017 [kitchen] add support for json-encoded recipes.cfg BUG= 699379 Change-Id: I8c35791b0c3345dc4ba7e9e63371c04ac0046c96 Reviewed-on: https://chromium-review.googlesource.com/452759 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/054be2c5e4f94f6529e3b89087b695d6db6dbfcf/go/src/infra/tools/kitchen/cook.go [modify] https://crrev.com/054be2c5e4f94f6529e3b89087b695d6db6dbfcf/go/src/infra/tools/kitchen/recipe.go
,
Mar 10 2017
The following revision refers to this bug: https://skia.googlesource.com/buildbot/+/5d74c758912b6f539168f0f8583e50a510ad31a9 commit 5d74c758912b6f539168f0f8583e50a510ad31a9 Author: Robert Iannucci <iannucci@google.com> Date: Fri Mar 10 12:14:18 2017 [recipes.cfg] manually roll recipes to get skiabuildbot recipe roller unstuck. This rolls the engine past the bad revision which was the cause of the mentioned bug (22e413ad35481ecd49d232620e7794ce6f544958). No expectation changes. BUG= chromium:699379 R=borenet@google.com Change-Id: I3984c8c4e30016ea57a5e9a078a314fb777724e9 Reviewed-on: https://skia-review.googlesource.com/9502 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> [modify] https://crrev.com/5d74c758912b6f539168f0f8583e50a510ad31a9/infra/config/recipes.cfg
,
Mar 10 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/0e5a9906e350c3ef59351c103cad3590ec492a46 commit 0e5a9906e350c3ef59351c103cad3590ec492a46 Author: Robert Iannucci <iannucci@google.com> Date: Fri Mar 10 12:41:04 2017 [recipes.cfg] manually roll recipes to get skia recipe roller unstuck. This rolls the engine past the bad revision which was the cause of the mentioned bug (22e413ad35481ecd49d232620e7794ce6f544958). No expectation changes. BUG= chromium:699379 R=borenet@google.com Change-Id: I3b44ae54ddec3b2053af59117074b5c1332d0cdf Reviewed-on: https://skia-review.googlesource.com/9503 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> [modify] https://crrev.com/0e5a9906e350c3ef59351c103cad3590ec492a46/infra/config/recipes.cfg
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3ddc83bf60d55bab789c414352f6560ad22897 commit 5f3ddc83bf60d55bab789c414352f6560ad22897 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Fri Mar 10 13:56:44 2017 Roll src/third_party/skia/ 6e1e27b7f..0e5a9906e (1 commit) https://skia.googlesource.com/skia.git/+log/6e1e27b7fccd..0e5a9906e350 $ git log 6e1e27b7f..0e5a9906e --date=short --no-merges --format='%ad %ae %s' 2017-03-09 iannucci [recipes.cfg] manually roll recipes to get skia recipe roller unstuck. Created with: roll-dep src/third_party/skia BUG= 699379 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=djsollen@chromium.org Change-Id: I520d94e4ec7d08adacf7934ca7cb25af20c15c85 Reviewed-on: https://chromium-review.googlesource.com/452668 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#456051} [modify] https://crrev.com/5f3ddc83bf60d55bab789c414352f6560ad22897/DEPS
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d5ba4fca3fb4dae084f96f90373d7d709faea64e commit d5ba4fca3fb4dae084f96f90373d7d709faea64e Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 16 02:22:39 2017 Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b This will enable it to be compatible with both the textpb and upcoming jsonpb form of recipes.cfg. BUG= 699379 Change-Id: I964ff571a105c8121c4dfe39b909d86a62085f78 Reviewed-on: https://chromium-review.googlesource.com/456119 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/d5ba4fca3fb4dae084f96f90373d7d709faea64e/recipes/recipes.py
,
Mar 16 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/39d4cb673399c52cf81bdc286dc11fbb0149a9d3 commit 39d4cb673399c52cf81bdc286dc11fbb0149a9d3 Author: Robert Iannucci <iannucci@google.com> Date: Thu Mar 16 02:22:10 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/604c13747f50519686a0e8b3b685d4af1d664cd2 commit 604c13747f50519686a0e8b3b685d4af1d664cd2 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 16 02:23:16 2017 Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b This will enable it to be compatible with both the textpb and upcoming jsonpb form of recipes.cfg. BUG= 699379 Change-Id: I4e2b10bfe78fa48cf4c5ab60e63d280dbd7b7ba0 Reviewed-on: https://chromium-review.googlesource.com/455990 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/604c13747f50519686a0e8b3b685d4af1d664cd2/scripts/slave/recipes.py
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/604c13747f50519686a0e8b3b685d4af1d664cd2 commit 604c13747f50519686a0e8b3b685d4af1d664cd2 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 16 02:23:16 2017 Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b This will enable it to be compatible with both the textpb and upcoming jsonpb form of recipes.cfg. BUG= 699379 Change-Id: I4e2b10bfe78fa48cf4c5ab60e63d280dbd7b7ba0 Reviewed-on: https://chromium-review.googlesource.com/455990 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/604c13747f50519686a0e8b3b685d4af1d664cd2/scripts/slave/recipes.py
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/370ca1bdcef508db313d00bc0601f8502c814e4e commit 370ca1bdcef508db313d00bc0601f8502c814e4e Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 16 02:24:04 2017 Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b This will enable it to be compatible with both the textpb and upcoming jsonpb form of recipes.cfg. BUG= 699379 Change-Id: Iafa3d959190648eca4fa864aaa79430759e568fe Reviewed-on: https://chromium-review.googlesource.com/455585 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/370ca1bdcef508db313d00bc0601f8502c814e4e/recipes.py
,
Mar 16 2017
The following revision refers to this bug: https://skia.googlesource.com/buildbot/+/fed703aa91845e8ef6acd424c9ac1a48dcd03341 commit fed703aa91845e8ef6acd424c9ac1a48dcd03341 Author: Robert Iannucci <iannucci@google.com> Date: Thu Mar 16 11:23:44 2017 Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b This will enable it to be compatible with both the textpb and upcoming jsonpb form of recipes.cfg. BUG= chromium:699379 Change-Id: Ide07d43042de2ee8bd9d6fccffc57807b0d9ead3 Reviewed-on: https://skia-review.googlesource.com/9750 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> [modify] https://crrev.com/fed703aa91845e8ef6acd424c9ac1a48dcd03341/infra/bots/recipes.py
,
Mar 16 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/2ba659e85ffeeb392f0dfd94dd5ee3c7d89787d6 commit 2ba659e85ffeeb392f0dfd94dd5ee3c7d89787d6 Author: Robert Iannucci <iannucci@google.com> Date: Thu Mar 16 11:50:07 2017 Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b This will enable it to be compatible with both the textpb and upcoming jsonpb form of recipes.cfg. BUG= chromium:699379 Change-Id: Ieabf2b0c3e41bbb250e987a90902ee1bdb71b73d Reviewed-on: https://skia-review.googlesource.com/9749 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> [modify] https://crrev.com/2ba659e85ffeeb392f0dfd94dd5ee3c7d89787d6/infra/bots/recipes.py
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92c8e73cacc372fe7e44adc316c49937821d2d7c commit 92c8e73cacc372fe7e44adc316c49937821d2d7c Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Mar 16 12:51:59 2017 Roll src/third_party/skia/ b66fa526b..f49b1e0ad (2 commits) https://skia.googlesource.com/skia.git/+log/b66fa526b882..f49b1e0ad955 $ git log b66fa526b..f49b1e0ad --date=short --no-merges --format='%ad %ae %s' 2017-03-15 halcanary FuzzCanvas: only valid ChannelSelectors 2017-03-15 iannucci Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b Created with: roll-dep src/third_party/skia BUG= 699379 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I75b38ce9077100e93ad1c685382099face7c3f75 Reviewed-on: https://chromium-review.googlesource.com/455992 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457410} [modify] https://crrev.com/92c8e73cacc372fe7e44adc316c49937821d2d7c/DEPS
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e9b94890b6de526673e6995e1395353b1e752299 commit e9b94890b6de526673e6995e1395353b1e752299 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 23 21:41:32 2017 [recipes.cfg] convert to JSON Bug: 699379 Change-Id: I917b34b36e7e7d3b0ef4773a57c7905ec4eccb18 Reviewed-on: https://chromium-review.googlesource.com/458595 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/e9b94890b6de526673e6995e1395353b1e752299/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e9b94890b6de526673e6995e1395353b1e752299 commit e9b94890b6de526673e6995e1395353b1e752299 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 23 21:41:32 2017 [recipes.cfg] convert to JSON Bug: 699379 Change-Id: I917b34b36e7e7d3b0ef4773a57c7905ec4eccb18 Reviewed-on: https://chromium-review.googlesource.com/458595 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/e9b94890b6de526673e6995e1395353b1e752299/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3 commit ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:15:26 2017 [recipes.cfg] convert to JSON Bug: 699379 Change-Id: I81d4665e57ab5fce22216671aa53012041d5011a Reviewed-on: https://chromium-review.googlesource.com/457833 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3 commit ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:15:26 2017 [recipes.cfg] convert to JSON Bug: 699379 Change-Id: I81d4665e57ab5fce22216671aa53012041d5011a Reviewed-on: https://chromium-review.googlesource.com/457833 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bd7fdc1212522513f464ca3f189018872ff26eca commit bd7fdc1212522513f464ca3f189018872ff26eca Author: Robbie Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:22:28 2017 Revert "[recipes.cfg] convert to JSON" This reverts commit ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3. Reason for revert: <INSERT REASONING HERE> Original change's description: > [recipes.cfg] convert to JSON > > Bug: 699379 > Change-Id: I81d4665e57ab5fce22216671aa53012041d5011a > Reviewed-on: https://chromium-review.googlesource.com/457833 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I2feed2f0573a7f3638b8b5012d093881ceea4696 Reviewed-on: https://chromium-review.googlesource.com/458109 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/bd7fdc1212522513f464ca3f189018872ff26eca/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bd7fdc1212522513f464ca3f189018872ff26eca commit bd7fdc1212522513f464ca3f189018872ff26eca Author: Robbie Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:22:28 2017 Revert "[recipes.cfg] convert to JSON" This reverts commit ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3. Reason for revert: <INSERT REASONING HERE> Original change's description: > [recipes.cfg] convert to JSON > > Bug: 699379 > Change-Id: I81d4665e57ab5fce22216671aa53012041d5011a > Reviewed-on: https://chromium-review.googlesource.com/457833 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I2feed2f0573a7f3638b8b5012d093881ceea4696 Reviewed-on: https://chromium-review.googlesource.com/458109 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/bd7fdc1212522513f464ca3f189018872ff26eca/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bd7fdc1212522513f464ca3f189018872ff26eca commit bd7fdc1212522513f464ca3f189018872ff26eca Author: Robbie Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:22:28 2017 Revert "[recipes.cfg] convert to JSON" This reverts commit ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3. Reason for revert: <INSERT REASONING HERE> Original change's description: > [recipes.cfg] convert to JSON > > Bug: 699379 > Change-Id: I81d4665e57ab5fce22216671aa53012041d5011a > Reviewed-on: https://chromium-review.googlesource.com/457833 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I2feed2f0573a7f3638b8b5012d093881ceea4696 Reviewed-on: https://chromium-review.googlesource.com/458109 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/bd7fdc1212522513f464ca3f189018872ff26eca/infra/config/recipes.cfg
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b9ede07dcc65de05933ce80fa23a0507fcd7c3c5 commit b9ede07dcc65de05933ce80fa23a0507fcd7c3c5 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:40:39 2017 [remote_run] bump canary version of recipes-py. Bug: 699379 Change-Id: Ife0f05fcd9374db80039d788f31057ae0612e3f2 Reviewed-on: https://chromium-review.googlesource.com/458568 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/b9ede07dcc65de05933ce80fa23a0507fcd7c3c5/scripts/slave/remote_run.py
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b9ede07dcc65de05933ce80fa23a0507fcd7c3c5 commit b9ede07dcc65de05933ce80fa23a0507fcd7c3c5 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 23 22:40:39 2017 [remote_run] bump canary version of recipes-py. Bug: 699379 Change-Id: Ife0f05fcd9374db80039d788f31057ae0612e3f2 Reviewed-on: https://chromium-review.googlesource.com/458568 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/b9ede07dcc65de05933ce80fa23a0507fcd7c3c5/scripts/slave/remote_run.py
,
Mar 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/1ad2fb882f27cc5e6d0ed362f1fbc783e55e5c69 commit 1ad2fb882f27cc5e6d0ed362f1fbc783e55e5c69 Author: Robert Iannucci <iannucci@google.com> Date: Fri Mar 24 00:11:49 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c15677597961c6f980914ce5e25e95d02323c722 commit c15677597961c6f980914ce5e25e95d02323c722 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 24 00:19:18 2017 [remote_run] bump prod version of recipes-py Bug: 699379 Change-Id: I865af5957502b1eaa2921d5effb338b062d8e735 Reviewed-on: https://chromium-review.googlesource.com/458976 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/c15677597961c6f980914ce5e25e95d02323c722/scripts/slave/remote_run.py
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c8b04fa68d968242aae885947bacdb7116d6886b commit c8b04fa68d968242aae885947bacdb7116d6886b Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 24 02:08:51 2017 Reland: [recipes.cfg] convert to JSON Originally: https://chromium-review.googlesource.com/#/c/457833/ Bug: 699379 Change-Id: Id67db1adb7429d30326ca7e7cc8822bba4011a14 Reviewed-on: https://chromium-review.googlesource.com/458998 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/c8b04fa68d968242aae885947bacdb7116d6886b/infra/config/recipes.cfg
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/17f33c9a7735dba20c9d80f954eeaabdd28e72d1 commit 17f33c9a7735dba20c9d80f954eeaabdd28e72d1 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 24 03:01:49 2017 [remote_run.py] bump kitchen canary version Bug: 699379 Change-Id: Ia15ed0e804981926ca07471054fa38d690aa023d Reviewed-on: https://chromium-review.googlesource.com/459007 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/17f33c9a7735dba20c9d80f954eeaabdd28e72d1/scripts/slave/remote_run.py
,
Mar 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d312a3d94dd5a5dd9d9e1576a4ba194f00c4101f commit d312a3d94dd5a5dd9d9e1576a4ba194f00c4101f Author: Robert Iannucci <iannucci@google.com> Date: Fri Mar 24 21:46:37 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/1a481a5a49fc3771ce9764e68f9e81f0058d3e36 commit 1a481a5a49fc3771ce9764e68f9e81f0058d3e36 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 24 22:15:52 2017 [recipes.cfg] convert to JSON Bug: 699379 Change-Id: Ibf896b70f2e8dbcf190776abaabe8b381fe60382 Reviewed-on: https://chromium-review.googlesource.com/459396 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/1a481a5a49fc3771ce9764e68f9e81f0058d3e36/infra/config/recipes.cfg
,
Mar 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/361936be371e5efba6da64d11443b8a1e95bb673 commit 361936be371e5efba6da64d11443b8a1e95bb673 Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Mar 25 02:42:26 2017 [recipes/recipe_simulation] recipes.cfg files are JSON now TBR=dnj@chromium.org Bug: 699379 Change-Id: I5d13ad95274fc199cd3a821f91079d7a98841212 Reviewed-on: https://chromium-review.googlesource.com/459703 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/361936be371e5efba6da64d11443b8a1e95bb673/recipes/recipes/recipe_simulation.py
,
Mar 25 2017
This is essentially completed now. One last item is to wait for all downstreams (just skia at this point) to pick up the changes, then remove the textproto support from kitchen.
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/dfb91755bc938d5485983f6060ca9c7ae38dbbe1 commit dfb91755bc938d5485983f6060ca9c7ae38dbbe1 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 28 03:47:49 2017 [kitchen] remove support for non-JSON recipes.cfg files Bug: 699379 Change-Id: If6819e10db606840191beddb806dec0ba4a4d073 Reviewed-on: https://chromium-review.googlesource.com/461268 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/dfb91755bc938d5485983f6060ca9c7ae38dbbe1/go/src/infra/tools/kitchen/proto/arguments.pb.go [delete] https://crrev.com/c81534acdb218daa5c6b55ea17fb1a66e5373c3a/go/src/infra/tools/kitchen/proto/package.pb.go [modify] https://crrev.com/dfb91755bc938d5485983f6060ca9c7ae38dbbe1/go/src/infra/tools/kitchen/recipe.go [delete] https://crrev.com/c81534acdb218daa5c6b55ea17fb1a66e5373c3a/go/src/infra/tools/kitchen/proto/package.proto
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/dfb91755bc938d5485983f6060ca9c7ae38dbbe1 commit dfb91755bc938d5485983f6060ca9c7ae38dbbe1 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 28 03:47:49 2017 [kitchen] remove support for non-JSON recipes.cfg files Bug: 699379 Change-Id: If6819e10db606840191beddb806dec0ba4a4d073 Reviewed-on: https://chromium-review.googlesource.com/461268 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/dfb91755bc938d5485983f6060ca9c7ae38dbbe1/go/src/infra/tools/kitchen/proto/arguments.pb.go [delete] https://crrev.com/c81534acdb218daa5c6b55ea17fb1a66e5373c3a/go/src/infra/tools/kitchen/proto/package.pb.go [modify] https://crrev.com/dfb91755bc938d5485983f6060ca9c7ae38dbbe1/go/src/infra/tools/kitchen/recipe.go [delete] https://crrev.com/c81534acdb218daa5c6b55ea17fb1a66e5373c3a/go/src/infra/tools/kitchen/proto/package.proto
,
Apr 20 2017
This one is done |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by d...@chromium.org
, Mar 8 2017