New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699376 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit 29 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"Linked to source map" file path is incorrect when the folders have dashes in them.

Reported by m...@codeavengers.com, Mar 8 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3033.0 Safari/537.36

Steps to reproduce the problem:
1. Turn on dev tools experiment Persistence 2.0.
2. Store less files in a folder called less-modules
3. When the auto mapping happens, it says "Linked to source map: 
http://localhost/less/-modules/file.less"

What is the expected behavior?
It should be:
http://localhost/less-modules/file.less

What went wrong?
Some files in that folder are automatically linked, others don't automatically link.

Also, sometimes when I click through to less files from the Elements CSS inspector, the less file shows up blank.

Did this work before? N/A 

Chrome version: 59.0.3033.0  Channel: canary
OS Version: 10.0
Flash Version:
 

Comment 1 by ajha@chromium.org, Mar 9 2017

Labels: Needs-Triage-M59
Cc: sureshkumari@chromium.org
Labels: Needs-Feedback
mike@codeavengers@ could you please provide a sample test file or url to reproduce the issue and possible help us by providing the screen cast of the issue to triaging it better.

Thanks.
The linking doesn't work for less files or javascript files that are inside a directory with a dash in the name.

For example I have a javascript directory called markup-plugins/js and none of the files are automatically linked.

It seems the system is assuming that folders do NOT contain dashes in them.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 10 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sureshkumari@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I'll do a screen cast to show you an example of it happening... because it does work sometimes...
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
mike@ could you please provide the screen-cast as per comment #5, for further triage.

Thank You...
Owner: lushnikov@chromium.org
I am having trouble reproducing this. @lushnikov do you know what is going on?
Sorry about that. I'll do screen cast...
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 21 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Unconfirmed)
Hi Mike!
Could you please share with us a screenshot with you Sources navigator? Both "filesystem" and "network" tabs.

Comment 12 Deleted

These unfortunately don't show up; could you please attach them via web-interface?

Comment 14 Deleted

OK...let's try this again... last time some bot automatically deleted my comment.
devtools2.png
51.4 KB View Download
devtools.png
37.6 KB View Download
Nice, this is helpful! Any chance you can attach the .css.map file? 
main2.css.map
374 KB Download
Latest releases have made things worse.

Now I can't even get the mappings working at all.

https://www.screencast.com/t/LsTIL7cpOnN


Hi Mike,

Which tool do you use to generate the sourcemap file? It is generated incorrectly - it has broken source urls (see screenshot)
bad-sourcemap-file.png
37.7 KB View Download
Ah ok!

So it is a problem at our end.

I'll check with our team member that takes care of that.
I just checked the latest version of our source maps and they seem to be correct now.

Perhaps the mappings have gotten thrown out by them being incorrect previously.

I think we updated to a more recent version of the less compiler this week which has fixed a few bugs with source maps.
main2.css.map
941 KB Download

Comment 22 Deleted

Comment 23 Deleted

Comment 24 Deleted

It seems the problem was a bug with the old version of the less compiler. This bug is fixed in the new less compiler.
Status: WontFix (was: Assigned)
Good to hear, closing this then.
OK We still haven't quite got things sorted... my developer is still trying to find which combination of less compiler parameters yields the correct output that dev tools understands.

At present he's spitting out fullpaths as follows for a less file that is available at localhost://markup-plugins/less/grid-match.less :
["C:/Users/Public/workspace/CodeAvengers/war/less-modules/variables.less","C:/Users/Public/workspace/CodeAvengers/war/markup-plugins/less/grid-match.less"]

We previously used Koala to compile our less. Its source map works with dev tools. It spits out the following paths:
"..\\..\\..\\..\\..\\..\\..\\Program Files (x86)\\less\\C:\\Users\\Public\\workspace\\CodeAvengers\\war\\less-modules\\variables.less","../less/grid-match.less"

Why does one of these work and the other doesn't?

Shouldn't both of these work?

What are the settings to achieve this final outcome?
#27: DevTools expect sources to be URLs (possibly relative urls), not paths. URLs are platform-independent, but paths aren't.

In your examples:
- "C:/Users/Public/workspace/CodeAvengers/war/less-modules/variables.less" is a file path rather then URL,  it has forward slashes and couldn't be parsed as URL. DevTools fails to handle this properly
- "..\\..\\..\\..\\..\\..\\..\\Program Files (x86)\\less\\C:\\Users\\Public\\workspace\\CodeAvengers\\war\\less-modules\\variables.less" could be treated as a relative URL, and for this reason it probably works.

Thanks that makes sense.

Mike

Sign in to add a comment