New issue
Advanced search Search tips

Issue 699375 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Update Documentation for VS 2017

Project Member Reported by jasonkliu@chromium.org, Mar 8 2017

Issue description

I am trying to follow the instructions here: https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md

Under the Visual Studio section, the menus seem to have changed in VS2017 and I'm not sure which options to select.  Can these be updated?  Thanks.
 
VS2017.png
127 KB View Download

Comment 1 by pwnall@chromium.org, Oct 17 2017

Cc: pwnall@chromium.org
Owner: brucedaw...@chromium.org
brucedawson@: Assigning to you, as you completed the VS2017 migration.

The Windows build instructions are also confusing regarding the required VS2017 version.
* "System requirements" (top section) states "Visual Studio 2015 Update 3, see below (no other version is supported)."
* "Setting up Windows" > "Visual Studio" states "As of September, 2017 Chromium requires Visual Studio 2017 update 3.2...."

I imagine the truth is that M62 and below require VS2015, and M63 and above require VS2017. If you lack the bandwidth to update the docs, please let me know if this is true, and I'll send you a CL.
I'll remove the reference to VS 2015. Unfortunately it's not even as clean as M62 versus M63, it's more like VS 2017 is required from R503915 on.

The installation options have completely changed in VS 2017. If you run the recommended command-line installation shown in the docs:

vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended

then the installer will pop up with the necessary options reselected, and you can then add others if you want to. I believe that the options are "Desktop development with C++" with "MFC and ATL support (x86 and x64)" selected. After that is installed you need to modify the SDK installation to add the Debuggers.

Let me know if this is any clearer:

https://chromium-review.googlesource.com/#/c/chromium/src/+/724284

Comment 4 by pwnall@chromium.org, Oct 17 2017

The CL is an improvement, thank you very much!

I imagine that VS community edition does not have a vs_professional.exe, so the component names are helpful.
The same command-line arguments work with the community edition. I've updated the CL to make that more obvious. How does it look?
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97367b77b8fe95af568d2df996ee20b4919d7371

commit 97367b77b8fe95af568d2df996ee20b4919d7371
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Wed Oct 18 00:47:49 2017

Improve Windows build instructions

This change removes a stray reference to VS 2015, clarifies when VS
2017 became required, and clarifies which VS 2017 components must be
installed.

Bug:  699375 
Change-Id: Ia06240a4581afb784a25330170c61ce3f124cf17
Reviewed-on: https://chromium-review.googlesource.com/724284
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509631}
[modify] https://crrev.com/97367b77b8fe95af568d2df996ee20b4919d7371/docs/windows_build_instructions.md

Comment 7 by pwnall@chromium.org, Oct 18 2017

Status: Fixed (was: Untriaged)
Awesome, thank you!

Sign in to add a comment