Update Documentation for VS 2017 |
||
Issue descriptionI am trying to follow the instructions here: https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md Under the Visual Studio section, the menus seem to have changed in VS2017 and I'm not sure which options to select. Can these be updated? Thanks.
,
Oct 17 2017
I'll remove the reference to VS 2015. Unfortunately it's not even as clean as M62 versus M63, it's more like VS 2017 is required from R503915 on. The installation options have completely changed in VS 2017. If you run the recommended command-line installation shown in the docs: vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended then the installer will pop up with the necessary options reselected, and you can then add others if you want to. I believe that the options are "Desktop development with C++" with "MFC and ATL support (x86 and x64)" selected. After that is installed you need to modify the SDK installation to add the Debuggers.
,
Oct 17 2017
Let me know if this is any clearer: https://chromium-review.googlesource.com/#/c/chromium/src/+/724284
,
Oct 17 2017
The CL is an improvement, thank you very much! I imagine that VS community edition does not have a vs_professional.exe, so the component names are helpful.
,
Oct 17 2017
The same command-line arguments work with the community edition. I've updated the CL to make that more obvious. How does it look?
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97367b77b8fe95af568d2df996ee20b4919d7371 commit 97367b77b8fe95af568d2df996ee20b4919d7371 Author: Bruce Dawson <brucedawson@chromium.org> Date: Wed Oct 18 00:47:49 2017 Improve Windows build instructions This change removes a stray reference to VS 2015, clarifies when VS 2017 became required, and clarifies which VS 2017 components must be installed. Bug: 699375 Change-Id: Ia06240a4581afb784a25330170c61ce3f124cf17 Reviewed-on: https://chromium-review.googlesource.com/724284 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#509631} [modify] https://crrev.com/97367b77b8fe95af568d2df996ee20b4919d7371/docs/windows_build_instructions.md
,
Oct 18 2017
Awesome, thank you! |
||
►
Sign in to add a comment |
||
Comment 1 by pwnall@chromium.org
, Oct 17 2017Owner: brucedaw...@chromium.org