Clean up ID in the constructor of ui::TouchEvent, ui::MouseEvent, ui::PointerEvent Remove ID from the constructor of ui::TouchEvent, ui::MouseEvent, ui::PointerEvent, and make sure that the IDs are only inside PointerDetails's constructors.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f commit 055c05b7eec28250e13af090d0d1f9c4ea6e7b3f Author: lanwei <lanwei@chromium.org> Date: Tue Mar 21 03:50:42 2017 Remove ID from ui::PointerEvent's constructors We should put all the PointerEvent's properties in PointerDetails class, so remove ID from ui::PointerEvent's constructors into the PointerDetails object. BUG= 699372 Review-Url: https://codereview.chromium.org/2753163004 Cr-Commit-Position: refs/heads/master@{#458303} [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ash/common/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/services/ui/ws/drag_controller_unittest.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/services/ui/ws/window_manager_state_unittest.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/events/event.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/events/event.h [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/events/event_unittest.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/events/mojo/struct_traits_unittest.cc [modify] https://crrev.com/055c05b7eec28250e13af090d0d1f9c4ea6e7b3f/ui/views/mus/pointer_watcher_event_router_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e727d61336a80e47949951d2d71aa506e90d774 commit 3e727d61336a80e47949951d2d71aa506e90d774 Author: lanwei <lanwei@chromium.org> Date: Wed Apr 12 23:19:27 2017 Add PointerDetails to ui::MouseEvent's constructors We should put all the MouseEvent's properties in PointerDetails class, so add a PointerDetails object in ui::MouseEvent's constructors. BUG= 699372 Review-Url: https://codereview.chromium.org/2786693002 Cr-Commit-Position: refs/heads/master@{#464201} [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/content/common/input/synthetic_web_input_event_builders.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/services/ui/ws/drag_controller_unittest.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/blink/web_input_event_builders_win.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/blink/web_input_event_unittest.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/event.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/event.h [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/event_unittest.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/events_default.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/mojo/struct_traits_unittest.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/events/ozone/evdev/event_factory_evdev.cc [modify] https://crrev.com/3e727d61336a80e47949951d2d71aa506e90d774/ui/views/win/hwnd_message_handler.cc
Comment 1 by bugdroid1@chromium.org
, Mar 21 2017