Enable Translate dialog to trigger for zh-TW pages and zh-CN users, and vice-versa. |
||||||||
Issue descriptionIn Chrome M56, Translate dialog triggering for Chinese pages was disabled for Chinese users. This was because the new LangID model could not distinguish between Simplified and Traditional Chinese. This was generally OK temporarily since e.g. a zh-CN user does not need to translate a zh-CN page to his or her own language. However zh-CN users may want to "translate" a zh-TW page (Traditional) into zh-CN (Simplified). Likewise, zh-TW users may want to "translate" a zh-CN page (Simplified) into zh-TW (Traditional). This bug tracks the patch for re-enabling Translate dialog triggering for Chinese pages for Chinese users.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0611c94f01981658a9c0b6327d3195ad4a129d75 commit 0611c94f01981658a9c0b6327d3195ad4a129d75 Author: riesa <riesa@chromium.org> Date: Thu Mar 16 17:53:06 2017 Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users and zh-CN pages. BUG= 699370 Review-Url: https://codereview.chromium.org/2745253005 Cr-Commit-Position: refs/heads/master@{#457485} [modify] https://crrev.com/0611c94f01981658a9c0b6327d3195ad4a129d75/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/0611c94f01981658a9c0b6327d3195ad4a129d75/components/translate/core/browser/translate_manager_unittest.cc
,
Apr 4 2017
,
Apr 4 2017
,
Apr 4 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/593ccfbebcf847630f4ef126bee69afa2a7cf7ae commit 593ccfbebcf847630f4ef126bee69afa2a7cf7ae Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Apr 04 16:47:25 2017 [Merge M58] Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users and zh-CN pages. BUG= 699370 Review-Url: https://codereview.chromium.org/2745253005 Cr-Commit-Position: refs/heads/master@{#457485} (cherry picked from commit 0611c94f01981658a9c0b6327d3195ad4a129d75) Review-Url: https://codereview.chromium.org/2791353003 . Cr-Commit-Position: refs/branch-heads/3029@{#567} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/593ccfbebcf847630f4ef126bee69afa2a7cf7ae/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/593ccfbebcf847630f4ef126bee69afa2a7cf7ae/components/translate/core/browser/translate_manager_unittest.cc
,
Apr 4 2017
,
Apr 10 2017
,
Apr 27 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by riesa@chromium.org
, Mar 8 2017