New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699368 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert ChromeViewMsg_RequestThumbnailForContextNode{,_ACK} to a mojo interface

Project Member Reported by w...@chromium.org, Mar 8 2017

Issue description

From chrome/common/render_messages.h: ChromeViewMsg_RequestThumbnailForContextNode &  ChromeViewHostMsg_RequestThumbnailForContextNode_ACK

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c472009300a73512a5ace3543e2eec9e2cdd5d9

commit 2c472009300a73512a5ace3543e2eec9e2cdd5d9
Author: watk <watk@chromium.org>
Date: Tue Mar 14 05:52:28 2017

Mojoify the RequestThumbnailForContextNode IPC message and reply

Previously thumbnail requests for context nodes were done with two IPC
messages: ChromeViewMsg_RequestThumbnailForContextNode &
ChromeViewHostMsg_RequestThumbnailForContextNode_ACK.

This CL introduces a new per-frame mojo interface, ThumbnailCapturer,
that's exposed by the renderer to the browser.

BUG= 699368 
TEST=existing browsertest, manually tested on linux, mac, android

Review-Url: https://codereview.chromium.org/2737893002
Cr-Commit-Position: refs/heads/master@{#456632}

[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/browser/chrome_content_renderer_manifest_overlay.json
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/browser/ui/android/context_menu_helper.cc
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/browser/ui/android/context_menu_helper.h
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/browser/ui/tab_contents/core_tab_helper.cc
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/browser/ui/tab_contents/core_tab_helper.h
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/common/BUILD.gn
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/common/render_messages.h
[add] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/common/thumbnail_capturer.mojom
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/2c472009300a73512a5ace3543e2eec9e2cdd5d9/chrome/renderer/chrome_render_frame_observer.h

Comment 2 by w...@chromium.org, Mar 14 2017

Status: Fixed (was: Started)

Sign in to add a comment