New issue
Advanced search Search tips

Issue 699366 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Buildbot pubsub crash

Project Member Reported by hinoka@chromium.org, Mar 8 2017

Issue description

This is crashing on chromium.swarm

2017-03-07 18:38:24-0800 [HTTPPageGetter,client] Unhandled error in Deferred:
2017-03-07 18:38:24-0800 [HTTPPageGetter,client] Unhandled Error
        Traceback (most recent call last):
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 1141, in unwindGenerator
            return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 1020, in _inlineCallbacks
            result = g.send(result)
          File "/home/chrome-bot/buildbot/build/scripts/master/pubsub_json_status_push.py", line 216, in _stop
            # Cache pending builds by brid, because they are expensive to query.
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 1141, in unwindGenerator
            return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
        --- <exception caught here> ---
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 1020, in _inlineCallbacks
            result = g.send(result)
          File "/home/chrome-bot/buildbot/build/scripts/master/pubsub_json_status_push.py", line 281, in _doStatusPush
            # that.  Making this 9MB to account for potential overhead.
          File "/home/chrome-bot/buildbot/build/scripts/master/pubsub_json_status_push.py", line 386, in _loadBuild
            self._clearPushTimer()
        exceptions.AttributeError: 'NoneType' object has no attribute 'asDict'

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e43ad1132d9017150d4c24107e591ddcc2b5b931

commit e43ad1132d9017150d4c24107e591ddcc2b5b931
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Mar 08 19:29:03 2017

PubSub: Make build loader more resilient to failures

BUG= 699366 

Change-Id: I63b412ec7549e69d7c4f69e973bc2b48d0013bd0
Reviewed-on: https://chromium-review.googlesource.com/450932
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/e43ad1132d9017150d4c24107e591ddcc2b5b931/scripts/master/pubsub_json_status_push.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/101f3398b7d3922e5e3ff5313dde2e895595edcc

commit 101f3398b7d3922e5e3ff5313dde2e895595edcc
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Mar 08 19:34:15 2017

Status: Fixed (was: Assigned)
chromium.swarm is reporting again.
\o/

ty

Sign in to add a comment