New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699363 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[MR extension] Downstream Media Router extension unit tests

Project Member Reported by imch...@chromium.org, Mar 8 2017

Issue description

Tracking bug to upstream unit tests for MR extension code that we've upstreamed.

We should look into enabling these tests on the waterfall as well.

A few notes:
- Our tests are written using Jasmine, so we will need to add in a copy of the Jasmine library to third_party. third_party also has Qunit (which is used by remoting tests). But it would be a huge pain to have to rewrite all of our tests, due to difference in syntax and style.
- We will need to write a thin wrapper to report results to the window.domAutomationController object injected by browser tests. The existing model for running JS tests is a bit heavyweight, but I haven't seen any alternatives thus far. 
- We may need to include a copy of the Closure library with the unit tests.

(Background: https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/jasmine/chromium-dev/yAOY7qGIYwg/ghZMycMcu6sJ)
 

Comment 1 by mfo...@chromium.org, Oct 26 2017

Cc: -jrw@chromium.org
Labels: M-64
Owner: jrw@chromium.org
Status: Assigned (was: Available)

Comment 2 by mfo...@chromium.org, Oct 26 2017

Blocking: 698796
Components: Internals>Cast

Comment 3 by mfo...@chromium.org, Oct 26 2017

Components: -Blink>PresentationAPI

Comment 4 by jrw@google.com, Dec 11 2017

Blockedon: 698796

Comment 5 by jrw@google.com, Dec 11 2017

Labels: -M-64 M-65

Comment 6 by mfo...@chromium.org, Dec 14 2017

Blockedon: -698796
Labels: -Pri-2 -M-65 Pri-3
Summary: [MR extension] Downstream Media Router extension unit tests (was: [MR extension] Upstream Media Router extension unit tests)
Lowering priority and removing milestone, since we already have test coverage for this code internally.

Also updating summary, since Chromium is actually downstream w.r.t. the extension.

Blocking: -698796
Components: -Internals>Cast Internals>Cast>Providers
Also, this doesn't block the main goal of allowing Media Router E2E tests to run in the waterfall, so removing the blocking bug.

Comment 9 by amp@chromium.org, Mar 30 2018

Status: WontFix (was: Assigned)
Too much work and we are moving away from extension.

Sign in to add a comment