New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699362 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 698796



Sign in to add a comment

[MR extension] Define build step for Media Router extension

Project Member Reported by imch...@chromium.org, Mar 8 2017

Issue description

This bug tracks investigation work on the format in which the open-sourced MR extension should be bundled with Chromium. Some points to consider:
- Whether it is possible to load the open-source MR extension as an internal component extension in Chromium. This should be overridable if we loaded a custom MR extension build.
- Barring that, we can create a GN build target that generates a set of extension files in the output directory, that can be loaded manually.
- At the minimum, there should be Closure compiler type checking of the code (that is also enabled on the waterfall), and creating bundled JS files from sources that continues to work with mr.Module.
-- dbeam@ is a good POC to consult with regarding the use of Closure compiler.
- goog.module / goog.provide / goog.require will need to be compiled out, or removed manually, or we need to provide a stub definition.
 

Comment 1 by mfo...@chromium.org, Oct 26 2017

Cc: -jrw@chromium.org
Labels: M-64
Owner: jrw@chromium.org
Status: Assigned (was: Available)

Comment 2 by mfo...@chromium.org, Oct 26 2017

Blocking: 698796
Components: Internals>Cast

Comment 3 by mfo...@chromium.org, Oct 26 2017

Components: -Blink>PresentationAPI

Comment 4 by jrw@google.com, Dec 11 2017

Blockedon: 698796

Comment 5 by jrw@google.com, Dec 11 2017

Labels: -M-64 M-65

Comment 6 by mfo...@chromium.org, Dec 14 2017

Blockedon: -698796
Status: Fixed (was: Assigned)
I believe this can be closed out now with https://chromium.googlesource.com/chromium/src/+/ff7a08db8ecc874f799a7689568e1d69ec757db4. 

Sign in to add a comment