New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 699347 link

Starred by 2 users
Status: Duplicate
Merged: issue 686118
Owner:
csharrison@chromium.org
Closed: Mar 2017
Cc:
█ mkwst@chromium.org
kinuko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocking:
issue 348655



Sign in to add a comment

Layout Test http/tests/security/setDomainRelaxationForbiddenForURLScheme.html is flaky (crashing)

Project Member Reported by horo@chromium.org, Mar 8 2017 
The following layout test is flaky on Debug build

http/tests/security/setDomainRelaxationForbiddenForURLScheme.html


https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showLargeExpectations=true&tests=setDomainRelaxationForbiddenForURLScheme

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/979/layout-test-results/http/tests/security/setDomainRelaxationForbiddenForURLScheme-stderr.txt

[1:1:0225/032148.248560:4653934627:FATAL:SchemeRegistry.cpp(96)] Check failed: WTF::isBeforeThreadCreated(). 
#0 0x7f4e7056a45b base::debug::StackTrace::StackTrace()
#1 0x7f4e70568aec base::debug::StackTrace::StackTrace()
#2 0x7f4e705d6bef logging::LogMessage::~LogMessage()
#3 0x7f4e6a11e6de blink::(anonymous namespace)::getMutableURLSchemesRegistry()
#4 0x7f4e6a11f589 blink::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme()
#5 0x7f4e696efacf blink::WebViewImpl::setDomainRelaxationForbidden()
#6 0x7f4e690b257d test_runner::TestRunnerForSpecificView::SetDomainRelaxationForbiddenForURLScheme()
#7 0x7f4e69085bfe test_runner::TestRunnerBindings::SetDomainRelaxationForbiddenForURLScheme()
#8 0x7f4e690a51c8 _ZN4base8internal13FunctorTraitsIMN11test_runner18TestRunnerBindingsEFvbRKSsEvE6InvokeIPS3_JbS5_EEEvS7_OT_DpOT0_
#9 0x7f4e690a50fb _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN11test_runner18TestRunnerBindingsEFvbRKSsEJPS5_bS7_EEEvOT_DpOT0_
#10 0x7f4e690a5070 _ZN4base8internal7InvokerINS0_9BindStateIMN11test_runner18TestRunnerBindingsEFvbRKSsEJEEEFvPS4_bS6_EE7RunImplIRKS8_RKSt5tupleIJEEJEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOSA_ObS6_
#11 0x7f4e690a4fb3 _ZN4base8internal7InvokerINS0_9BindStateIMN11test_runner18TestRunnerBindingsEFvbRKSsEJEEEFvPS4_bS6_EE3RunEPNS0_13BindStateBaseEOSA_ObS6_
#12 0x7f4e690a4ec3 base::internal::RunMixin<>::Run()
#13 0x7f4e690a4d83 _ZN3gin8internal7InvokerINS0_13IndicesHolderIJLm0ELm1ELm2EEEEJPN11test_runner18TestRunnerBindingsEbRKSsEE18DispatchToCallbackEN4base8CallbackIFvS6_bS8_ELNSA_8internal8CopyModeE1ELNSD_10RepeatModeE1EEE
#14 0x7f4e690a4bc9 gin::internal::Dispatcher<>::DispatchToCallback()
#15 0x7f4e6ab10f1b v8::internal::FunctionCallbackArguments::Call()
#16 0x7f4e6abe33a9 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#17 0x7f4e6abe1eca v8::internal::Builtin_Impl_HandleApiCall()
#18 0x2c6dba404204 <unknown>



This DCHECK was introduced by https://codereview.chromium.org/2492233003

Comment 1 by csharrison@chromium.org, Mar 8 2017

Cc: kinuko@chromium.org mkwst@chromium.org
I'm impressed this took so long to discover! Yes indeed I introduced this flake.

However, really the test should be rewritten in a thread-safe way. No other consumer needs the SchemeRegistry to be mutable after other threads have started, so I think this should be rewritten as a SimTest, with the test runner plumbing of SetDomainRelaxationForbiddenForURLScheme removed.

+mkwst for thoughts as author of the test. +kinuko FYI
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cad2f66f878c0785125e63ef350f193485d652d

commit 1cad2f66f878c0785125e63ef350f193485d652d
Author: horo <horo@chromium.org>
Date: Thu Mar 09 08:48:30 2017

Add setDomainRelaxationForbiddenForURLScheme.html [ Crash ] to TestExpectations

BUG= 699347 
TBR=csharrison

Review-Url: https://codereview.chromium.org/2740023002
Cr-Commit-Position: refs/heads/master@{#455701}

[modify] https://crrev.com/1cad2f66f878c0785125e63ef350f193485d652d/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by horo@chromium.org, Mar 9 2017

Mergedinto: 686118
Status: Duplicate (was: Assigned)
Issue 686118 looks like the same problem.
Merging to 686118.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c881ee2276c5528873915860d3ca5c95fc37587

commit 0c881ee2276c5528873915860d3ca5c95fc37587
Author: Peter Mayo <petermayo@chromium.org>
Date: Fri Jul 13 02:24:48 2018

Update TestExpectations for crashy layout test

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/security/setDomainRelaxationForbiddenForURLScheme.html
indicates that on many builders (probably all those without DCHECK
on) this test passes.

Bug:  699347 , 686118
Change-Id: I7496ce45d0ce5c196073acba954f8cd48c7f1f3b
Reviewed-on: https://chromium-review.googlesource.com/1135661
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574820}
[modify] https://crrev.com/0c881ee2276c5528873915860d3ca5c95fc37587/third_party/WebKit/LayoutTests/TestExpectations
►

Sign in to add a comment