Make histograms.xml a build artifact. |
||||
Issue descriptionBuilding histograms.xml would allow us to be more flexible in changing how it is managed in chrome source without changes to server side script that parse it, and archiving it along with released builds would make it easier to figure out which metrics were in different releases. Planned steps: 1. Add simple build target for histograms.xml that just copies the current one (or maybe a zip file of histograms, actions, and rappor). 2. Add that build target to official GN build, and some CQ bots. 3. Update https://cs.chromium.org/chromium/src/chrome/tools/build/win/FILES.cfg to start archiving the built target 4. Update server code to use the built versions. 5. Make CLs to split, and start combining files, with presubmit changes. * Start with extracting simple splits, like: - Auto-updated enums - UseCounter histograms - Obsolete histograms - Cronet histograms * Later, add more domain specific histogram splits.
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bef6eb324513ab51540335f40abbc4e434caf833 commit bef6eb324513ab51540335f40abbc4e434caf833 Author: holte <holte@chromium.org> Date: Tue Apr 04 20:41:25 2017 Start archiving metrics_metadata with builds. BUG= 699328 Review-Url: https://codereview.chromium.org/2751423003 Cr-Commit-Position: refs/heads/master@{#461822} [modify] https://crrev.com/bef6eb324513ab51540335f40abbc4e434caf833/BUILD.gn [modify] https://crrev.com/bef6eb324513ab51540335f40abbc4e434caf833/chrome/tools/build/win/FILES.cfg [add] https://crrev.com/bef6eb324513ab51540335f40abbc4e434caf833/tools/metrics/BUILD.gn
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b87f01f54ba47ace1ddf35476a9166ef67341ea8 commit b87f01f54ba47ace1ddf35476a9166ef67341ea8 Author: holte <holte@chromium.org> Date: Mon Apr 10 20:45:53 2017 Add metrics_metadata target to chrome_official_builder_no_unittests. BUG= 699328 Review-Url: https://codereview.chromium.org/2802093007 Cr-Commit-Position: refs/heads/master@{#463386} [modify] https://crrev.com/b87f01f54ba47ace1ddf35476a9166ef67341ea8/BUILD.gn
,
Apr 18 2017
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2e664bfa92754ad40c14aa9cfa84296653b1591f commit 2e664bfa92754ad40c14aa9cfa84296653b1591f Author: Steven Holte <holte@google.com> Date: Wed May 03 20:59:35 2017 Handle extra metrics xml files in git cl format. This will allow git cl format to handle histograms.xml being split into several files, and also adds support for UKM. Bug:699328 Change-Id: I2bfbd333b78b679f69d7cb298f5adaf02f6a4dec Reviewed-on: https://chromium-review.googlesource.com/483979 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> [modify] https://crrev.com/2e664bfa92754ad40c14aa9cfa84296653b1591f/git_cl.py
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d79dbde08f2f4bc8ef85f205c099f786ec8ec269 commit d79dbde08f2f4bc8ef85f205c099f786ec8ec269 Author: Steven Holte <holte@google.com> Date: Thu May 04 01:34:50 2017 Split histogram enums to enums.xml Instead of picking up a simple copy of histograms.xml, the metrics_metadata target will now by merging histograms.xml and enums.xml into single file. Scripts for enums now update enums.xml, pretty_print.py will enforce that the split is continued, and validation is updated to run on the merged result. To be landed after the server side parsing code is fully migrated to using the archived metrics_metadata.zip files. BUG:699328 TBR = tnagel,bbudge Change-Id: Ia701423b7f2117991275477a92f77048a542b6db Reviewed-on: https://chromium-review.googlesource.com/481901 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#469239} [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/chrome/browser/about_flags_unittest.cc [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/chrome/test/BUILD.gn [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/components/policy/resources/PRESUBMIT.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/ppapi/PRESUBMIT.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/BUILD.gn [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/common/presubmit_util.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/OWNERS [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/PRESUBMIT.py [add] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/enums.xml [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/extract_histograms.py [add] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/histogram_paths.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/histograms.xml [add] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/merge_xml.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/pretty_print.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/update_editor_commands.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/update_histogram_enum.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/update_policies.py [modify] https://crrev.com/d79dbde08f2f4bc8ef85f205c099f786ec8ec269/tools/metrics/histograms/validate_format.py
,
May 4 2017
Awesome! You should send an announcement to chromium-dev@ about this change, give it will affect a lot of developers.
,
Jun 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by holte@chromium.org
, Mar 8 2017