New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 699022

Blocking:
issue 699331



Sign in to add a comment

nacl_integration test is sensitive to one of ($TMPDIR,$TEMP,$TMP) environment variables

Project Member Reported by iannu...@google.com, Mar 8 2017

Issue description

See issue 699022.

Basically I'm trying to make the bots generate per-run temporary directories in order to make builds more hermetic. When I did this in crrev.com/4236db6cb072c55f9483bd670fdfd9acfd3a95a1 we saw e.g. https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/52778

Filing this bug so as not to lose track of it.
 
Blockedon: 699022
Blocking: -699022
Blocking: 699331
Cc: bradnelson@chromium.org
Cc: iannucci@chromium.org
Owner: bradnelson@chromium.org
Status: Assigned (was: Untriaged)
Hmmn. Was talking with estaab about just taking this step down.
Might do that when get free cycles.

Project Member

Comment 5 by sheriffbot@chromium.org, Jul 25 2017

Labels: Hotlist-Google
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04ea2d90d8ba0c1061982330eaf520751878e459

commit 04ea2d90d8ba0c1061982330eaf520751878e459
Author: Robert Iannucci <iannucci@google.com>
Date: Fri Jul 28 08:41:41 2017

Remove nacl_integration test.

These tests are obsolete and have a bug w.r.t. dynamic $TMPDIR values.

R=bradnelson@chromium.org

Bug:  699326 
Change-Id: I58aca9a74267f512ba4e10ce8dd13544da0ebed4
Reviewed-on: https://chromium-review.googlesource.com/589432
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490319}
[delete] https://crrev.com/bcae6b3deb023f6494441a8f3b993f9edc3b56d6/chrome/test/nacl_test_injection/OWNERS
[delete] https://crrev.com/bcae6b3deb023f6494441a8f3b993f9edc3b56d6/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py
[delete] https://crrev.com/bcae6b3deb023f6494441a8f3b993f9edc3b56d6/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
[rename] https://crrev.com/04ea2d90d8ba0c1061982330eaf520751878e459/native_client_sdk/src/build_tools/find_chrome.py
[modify] https://crrev.com/04ea2d90d8ba0c1061982330eaf520751878e459/native_client_sdk/src/build_tools/test_projects.py
[modify] https://crrev.com/04ea2d90d8ba0c1061982330eaf520751878e459/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/04ea2d90d8ba0c1061982330eaf520751878e459/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/04ea2d90d8ba0c1061982330eaf520751878e459/testing/buildbot/chromium.win.json
[delete] https://crrev.com/bcae6b3deb023f6494441a8f3b993f9edc3b56d6/testing/scripts/nacl_integration.py

Owner: iannucci@chromium.org
Status: Fixed (was: Assigned)
Test is gone, this is done :)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/5e00cd59424a0fd50e9c87dd5af7b0b2d9644556

commit 5e00cd59424a0fd50e9c87dd5af7b0b2d9644556
Author: Robert Iannucci <iannucci@google.com>
Date: Fri Jul 28 13:39:01 2017

Sign in to add a comment