Mojo channels should support sending Java Parcelable objects. (This is needed as part of the servicification work. On Android Android Surfaces objects are exchanged between the browser and renderer processes.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aba5a6139d8823893880402cf40e9f319f2f0a97 commit aba5a6139d8823893880402cf40e9f319f2f0a97 Author: jcivelli <jcivelli@chromium.org> Date: Fri Mar 10 00:28:37 2017 Changing connections to take a ConnectionParams instead of a pipe handle. ConnectionParams will be augmented in a follow up patch to take extra objects on Android (channels to support sending Parcelable instances). BUG=699311 TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2738853002 Cr-Commit-Position: refs/heads/master@{#455921} [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/chrome/test/base/mojo_test_connector.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/components/arc/arc_session.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/components/nacl/broker/nacl_broker_listener.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/content/browser/child_process_launcher.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/BUILD.gn [add] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/connection_params.cc [add] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/connection_params.h [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/embedder.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/embedder_unittest.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/pending_process_connection.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/embedder/pending_process_connection.h [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/broker_host.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/channel.h [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/channel_posix.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/channel_win.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/core.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/core.h [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/node_channel.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/node_channel.h [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/node_controller.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/system/node_controller.h [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/mojo/edk/test/multiprocess_test_helper.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/remoting/host/win/wts_session_process_delegate.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/services/service_manager/runner/host/service_process_launcher.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/services/service_manager/tests/service_manager/service_manager_unittest.cc [modify] https://crrev.com/aba5a6139d8823893880402cf40e9f319f2f0a97/services/service_manager/tests/util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9 commit 87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9 Author: jcivelli <jcivelli@chromium.org> Date: Tue Mar 14 17:55:53 2017 Changing multiprocess test SpawnChild to return a struct instead of a process. The struct only contains the process for now but will be augmented in a follow up patch to contain other objects on Android. BUG=699311 TBR=sky@chromium.org,jochen@chromium.org,jam@chromium.org,rockot@chromium.org,jschuh@chromium.org Review-Url: https://codereview.chromium.org/2733323002 Cr-Commit-Position: refs/heads/master@{#456756} [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/debug/stack_trace_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/files/file_locking_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/mac/mach_port_broker_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/memory/shared_memory_mac_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/memory/shared_memory_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/memory/shared_memory_win_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/process/process_metrics_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/process/process_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/process/process_util_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/test/multiprocess_test.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/test/multiprocess_test.h [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/test/multiprocess_test_android.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/win/scoped_handle_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/base/win/wait_chain_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/chrome/browser/process_singleton_win_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/chrome/common/component_flash_hint_file_linux_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/chrome/common/multi_process_lock_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/chrome/common/service_process_util_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/chrome/installer/setup/setup_singleton_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/components/browser_watcher/exit_code_watcher_win_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/components/crash/content/app/fallback_crash_handler_win_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/components/crash/content/app/fallback_crash_handling_win_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/content/browser/mach_broker_mac_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/content/browser/memory/memory_coordinator_impl_unittest.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/content/common/sandbox_mac_diraccess_unittest.mm [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/content/common/sandbox_mac_unittest_helper.mm [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/mojo/edk/test/multiprocess_test_helper.cc [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/mojo/edk/test/multiprocess_test_helper.h [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/sandbox/mac/bootstrap_sandbox_unittest.mm [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/sandbox/mac/sandbox_mac_compiler_unittest.mm [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm [modify] https://crrev.com/87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9/sandbox/mac/xpc_message_server_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2be81a465a7b2ef07b3667f83de1009206acace commit f2be81a465a7b2ef07b3667f83de1009206acace Author: jcivelli <jcivelli@chromium.org> Date: Thu Mar 16 21:04:10 2017 Making the Mojo Channel Messages legacy mode dynamic. The mojo::edk::Channel::Message class uses a compile flag to determine whether to use the legacy or normal mode (legacy mode is used to keep backward compatibility between Arc++ and ChromeOS). Making that flag dynamically set on the embedder so that the default is now normal mode on Android. This is going to be used for adding Parcelable support on mojo Android (where we'll need the normal Message's header to include the parcelables). BUG=699311 Review-Url: https://codereview.chromium.org/2749853003 Cr-Commit-Position: refs/heads/master@{#457549} [modify] https://crrev.com/f2be81a465a7b2ef07b3667f83de1009206acace/mojo/edk/embedder/embedder.cc [modify] https://crrev.com/f2be81a465a7b2ef07b3667f83de1009206acace/mojo/edk/embedder/embedder.h [modify] https://crrev.com/f2be81a465a7b2ef07b3667f83de1009206acace/mojo/edk/system/channel.cc [modify] https://crrev.com/f2be81a465a7b2ef07b3667f83de1009206acace/mojo/edk/system/channel.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8726a7e2f31aba4bec3de517134e3c8edc512349 commit 8726a7e2f31aba4bec3de517134e3c8edc512349 Author: jcivelli <jcivelli@chromium.org> Date: Tue Mar 21 01:43:03 2017 Revert of Making the Mojo Channel Messages legacy mode dynamic. (patchset #4 id:120001 of https://codereview.chromium.org/2749853003/ ) Reason for revert: Breaks the Chrome PFQ bot. Will need to sync with a change to the Arc++ code before landing this. Original issue's description: > Making the Mojo Channel Messages legacy mode dynamic. > > The mojo::edk::Channel::Message class uses a compile flag to determine > whether to use the legacy or normal mode (legacy mode is used to keep > backward compatibility between Arc++ and ChromeOS). > Making that flag dynamically set on the embedder so that the default is > now normal mode on Android. This is going to be used for adding > Parcelable support on mojo Android (where we'll need the normal > Message's header to include the parcelables). > > BUG=699311 > > Review-Url: https://codereview.chromium.org/2749853003 > Cr-Commit-Position: refs/heads/master@{#457549} > Committed: https://chromium.googlesource.com/chromium/src/+/f2be81a465a7b2ef07b3667f83de1009206acace TBR=rockot@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699311 Review-Url: https://codereview.chromium.org/2765673002 Cr-Commit-Position: refs/heads/master@{#458271} [modify] https://crrev.com/8726a7e2f31aba4bec3de517134e3c8edc512349/mojo/edk/embedder/embedder.cc [modify] https://crrev.com/8726a7e2f31aba4bec3de517134e3c8edc512349/mojo/edk/embedder/embedder.h [modify] https://crrev.com/8726a7e2f31aba4bec3de517134e3c8edc512349/mojo/edk/system/channel.cc [modify] https://crrev.com/8726a7e2f31aba4bec3de517134e3c8edc512349/mojo/edk/system/channel.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f4e58bed74a0d5023a5668d68bcad7343212964 commit 4f4e58bed74a0d5023a5668d68bcad7343212964 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Mar 21 19:49:04 2017 Revert of Making the Mojo Channel Messages legacy mode dynamic. (patchset #4 id:120001 of https://codereview.chromium.org/2749853003/ ) Reason for revert: Breaks the Chrome PFQ bot. Will need to sync with a change to the Arc++ code before landing this. Original issue's description: > Making the Mojo Channel Messages legacy mode dynamic. > > The mojo::edk::Channel::Message class uses a compile flag to determine > whether to use the legacy or normal mode (legacy mode is used to keep > backward compatibility between Arc++ and ChromeOS). > Making that flag dynamically set on the embedder so that the default is > now normal mode on Android. This is going to be used for adding > Parcelable support on mojo Android (where we'll need the normal > Message's header to include the parcelables). > > BUG=699311 > > Review-Url: https://codereview.chromium.org/2749853003 > Cr-Commit-Position: refs/heads/master@{#457549} > Committed: https://chromium.googlesource.com/chromium/src/+/f2be81a465a7b2ef07b3667f83de1009206acace TBR=rockot@chromium.org BUG=699311 Review-Url: https://codereview.chromium.org/2765673002 Cr-Commit-Position: refs/heads/master@{#458271} (cherry picked from commit 8726a7e2f31aba4bec3de517134e3c8edc512349) Review-Url: https://codereview.chromium.org/2765963002 . Cr-Commit-Position: refs/branch-heads/3047@{#5} Cr-Branched-From: 15ae1e89e749d6443b6caffdbc78ad24f945aa67-refs/heads/master@{#458255} [modify] https://crrev.com/4f4e58bed74a0d5023a5668d68bcad7343212964/mojo/edk/embedder/embedder.cc [modify] https://crrev.com/4f4e58bed74a0d5023a5668d68bcad7343212964/mojo/edk/embedder/embedder.h [modify] https://crrev.com/4f4e58bed74a0d5023a5668d68bcad7343212964/mojo/edk/system/channel.cc [modify] https://crrev.com/4f4e58bed74a0d5023a5668d68bcad7343212964/mojo/edk/system/channel.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e9e77ee81535bb38bfc6c574d4b976475176908 commit 1e9e77ee81535bb38bfc6c574d4b976475176908 Author: Jay Civelli <jcivelli@google.com> Date: Sat Aug 19 00:59:41 2017 Changing ChildProcessLauncher to take a list of IBinder callbacks. The ChildProcessLauncher now takes a List of IBinder callbacks instead of a single one. It will be used to support sending Parcelables over Mojo channel, as it requires multiple AIDLs that can't be easily consolidated into one. Bug: 699311 Change-Id: I73d4f2cbf12dc5196fd7678502b38a292270ed07 Reviewed-on: https://chromium-review.googlesource.com/622156 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#495772} [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/android/java/src/org/chromium/base/process_launcher/ChildProcessConnection.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/android/java/src/org/chromium/base/process_launcher/ChildProcessServiceDelegate.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/android/java/src/org/chromium/base/process_launcher/ChildProcessServiceImpl.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/android/junit/src/org/chromium/base/process_launcher/ChildProcessConnectionTest.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/base/test/android/java/src/org/chromium/base/MultiprocessTestClientServiceDelegate.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java [modify] https://crrev.com/1e9e77ee81535bb38bfc6c574d4b976475176908/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/TestChildProcessService.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a44260b19a7e41498a8c2f4f2358d393061c050 commit 4a44260b19a7e41498a8c2f4f2358d393061c050 Author: Jay Civelli <jcivelli@google.com> Date: Mon Aug 21 19:26:29 2017 Revert "Changing multiprocess test SpawnChild to return a struct instead of a" We do not need this anymore as it turns out the initial plan of having Parcelable returned by SpawnChildProcess will not work as that code would have to live outside of base. This reverts commit 87c322b0dc2f4a7595fd288ab0c529d4aa1aafd9. TBR=sky@chromium.org,jochen@chromium.org,jam@chromium.org,rockot@chromium.org,jschuh@chromium.org Bug: 699311 Change-Id: I80be75071efcfc95428971d6dd5ae277cb0e2246 Reviewed-on: https://chromium-review.googlesource.com/621592 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#496020} [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/debug/stack_trace_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/files/file_locking_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/mac/mach_port_broker_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/memory/shared_memory_mac_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/memory/shared_memory_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/memory/shared_memory_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/process/process_metrics_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/process/process_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/process/process_util_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/test/multiprocess_test.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/test/multiprocess_test.h [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/test/multiprocess_test_android.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/win/scoped_handle_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/base/win/wait_chain_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/browser/process_singleton_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/common/component_flash_hint_file_linux_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/common/multi_process_lock_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/common/service_process_util_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/chrome/installer/setup/setup_singleton_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/components/browser_watcher/exit_code_watcher_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/components/browser_watcher/stability_paths_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/components/crash/content/app/fallback_crash_handler_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/components/crash/content/app/fallback_crash_handling_win_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/content/browser/mach_broker_mac_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/content/browser/memory/memory_coordinator_impl_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/content/common/sandbox_mac_diraccess_unittest.mm [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/content/common/sandbox_mac_unittest_helper.mm [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/content/renderer/sandbox_mac_v2_unittest.mm [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/mojo/edk/test/multiprocess_test_helper.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/mojo/edk/test/multiprocess_test_helper.h [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/sandbox/mac/bootstrap_sandbox_unittest.mm [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/sandbox/mac/sandbox_mac_compiler_unittest.mm [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/sandbox/mac/sandbox_mac_seatbelt_exec_unittest.cc [modify] https://crrev.com/4a44260b19a7e41498a8c2f4f2358d393061c050/sandbox/mac/xpc_message_server_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Mar 10 2017