WebView KeySystem tests are failing for components builds. |
|||||||
Issue description
tried on a recent master. John tried on ToT master. KeySystemTest#testSupportWidevineKeySystem is failing. For me specifically, I did:
./out/gn_arm64/bin/run_android_webview_test_apk --num_retries=0 --release -f KeySystemTest
my gn file is:
is_debug = false
use_goma = true
target_os = "android"
target_cpu = "arm64"
use_signing_keys=true
use_unpublished_apis=true
#use_really_unpublished_apis=true
use_webview_internal_framework=true
dcheck_always_on=true
android_default_version_code="999999999"
symbol_level=1
is_component_build = true
is_official_build = false
# android_channel = "beta"
run_findbugs = false
# this is to turn off building 32 bit
build_apk_secondary_abi = true
gdb_index = false
android_full_debug = false
Results are as below but the bots are fine:
C 78.657s Main Detailed Logs
C 78.657s Main ********************************************************************************
C 78.657s Main [FAIL] org.chromium.android_webview.test.KeySystemTest#testSupportClearKeySystem:
C 78.657s Main junit.framework.ComparisonFailure: expected:<"[supported]"> but was:<"[NotSupportedError]">
C 78.658s Main at org.chromium.android_webview.test.KeySystemTest.testSupportClearKeySystem(KeySystemTest.java:103)
C 78.658s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:220)
C 78.658s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:205)
C 78.658s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 78.658s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 78.658s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 78.659s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 78.659s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 78.659s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 78.659s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 78.659s Main
C 78.659s Main [FAIL] org.chromium.android_webview.test.KeySystemTest#testSupportClearKeySystem with {--webview-sandboxed-renderer}:
C 78.659s Main junit.framework.ComparisonFailure: expected:<"[supported]"> but was:<"[NotSupportedError]">
C 78.659s Main at org.chromium.android_webview.test.KeySystemTest.testSupportClearKeySystem(KeySystemTest.java:103)
C 78.660s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:220)
C 78.660s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:205)
C 78.660s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 78.660s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 78.660s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 78.660s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 78.660s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 78.660s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 78.661s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 78.661s Main
C 78.661s Main [FAIL] org.chromium.android_webview.test.KeySystemTest#testSupportPlatformKeySystem:
C 78.661s Main junit.framework.ComparisonFailure: expected:<"[supported]"> but was:<"[NotSupportedError]">
C 78.661s Main at org.chromium.android_webview.test.KeySystemTest.testSupportPlatformKeySystem(KeySystemTest.java:122)
C 78.661s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:220)
C 78.661s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:205)
C 78.661s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 78.662s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 78.662s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 78.662s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 78.662s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 78.662s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 78.662s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 78.662s Main
C 78.662s Main [FAIL] org.chromium.android_webview.test.KeySystemTest#testSupportPlatformKeySystem with {--webview-sandboxed-renderer}:
C 78.662s Main junit.framework.ComparisonFailure: expected:<"[supported]"> but was:<"[NotSupportedError]">
C 78.663s Main at org.chromium.android_webview.test.KeySystemTest.testSupportPlatformKeySystem(KeySystemTest.java:122)
C 78.663s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:220)
C 78.663s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:205)
C 78.663s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 78.663s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 78.663s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 78.663s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 78.663s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 78.663s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 78.664s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 78.664s Main
C 78.664s Main [FAIL] org.chromium.android_webview.test.KeySystemTest#testSupportWidevineKeySystem:
C 78.664s Main junit.framework.ComparisonFailure: expected:<"[supported]"> but was:<"[NotSupportedError]">
C 78.664s Main at org.chromium.android_webview.test.KeySystemTest.testSupportWidevineKeySystem(KeySystemTest.java:109)
C 78.664s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:220)
C 78.664s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:205)
C 78.664s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 78.664s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 78.664s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 78.664s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 78.664s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 78.664s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 78.664s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 78.664s Main
C 78.664s Main [FAIL] org.chromium.android_webview.test.KeySystemTest#testSupportWidevineKeySystem with {--webview-sandboxed-renderer}:
C 78.664s Main junit.framework.ComparisonFailure: expected:<"[supported]"> but was:<"[NotSupportedError]">
C 78.664s Main at org.chromium.android_webview.test.KeySystemTest.testSupportWidevineKeySystem(KeySystemTest.java:109)
C 78.664s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:220)
C 78.665s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:205)
C 78.665s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 78.665s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 78.665s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 78.665s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 78.665s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 78.665s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 78.665s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 78.665s Main ********************************************************************************
C 78.665s Main Summary
C 78.665s Main ********************************************************************************
C 78.665s Main [==========] 10 tests ran.
C 78.665s Main [ PASSED ] 4 tests.
C 78.665s Main [ FAILED ] 6 tests, listed below:
C 78.665s Main [ FAILED ] org.chromium.android_webview.test.KeySystemTest#testSupportClearKeySystem
C 78.665s Main [ FAILED ] org.chromium.android_webview.test.KeySystemTest#testSupportClearKeySystem with {--webview-sandboxed-renderer}
C 78.665s Main [ FAILED ] org.chromium.android_webview.test.KeySystemTest#testSupportPlatformKeySystem
C 78.665s Main [ FAILED ] org.chromium.android_webview.test.KeySystemTest#testSupportPlatformKeySystem with {--webview-sandboxed-renderer}
C 78.666s Main [ FAILED ] org.chromium.android_webview.test.KeySystemTest#testSupportWidevineKeySystem
C 78.666s Main [ FAILED ] org.chromium.android_webview.test.KeySystemTest#testSupportWidevineKeySystem with {--webview-sandboxed-renderer}
C 78.666s Main
C 78.666s Main 6 FAILED TESTS
,
Mar 8 2017
,
Mar 8 2017
Reproed on ToT without proprietary_codecs = true ffmpeg_branding = "Chrome" If I specified these two then the test passes. I am looking into it.
,
Mar 8 2017
,
Mar 8 2017
Assign to jrummell as I am sheriffing and overloaded with other tasks.
,
Mar 14 2017
Note that these tests are failing for components builds, and I think that is the main issue. Changing the title
,
Mar 14 2017
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99ac9c004a6048ede85584571c4e7a6c23b4b8e8 commit 99ac9c004a6048ede85584571c4e7a6c23b4b8e8 Author: jrummell <jrummell@chromium.org> Date: Fri Mar 17 00:52:08 2017 Fix KeySystemTests on Android It appears that getting back an empty string from JavaScript ends up as "" in Java, so remove the double quotes if they exist. Also modify some of the test to make it clearer what it is testing. As vp8 is more likely to be supported on the Android platform, pass it as one of the capabilities expected. BUG=699310 TEST=updated tests pass on Android Review-Url: https://codereview.chromium.org/2741943003 Cr-Commit-Position: refs/heads/master@{#457635} [modify] https://crrev.com/99ac9c004a6048ede85584571c4e7a6c23b4b8e8/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java [modify] https://crrev.com/99ac9c004a6048ede85584571c4e7a6c23b4b8e8/android_webview/test/shell/assets/key-system-test.html
,
Mar 17 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sgu...@chromium.org
, Mar 8 2017