New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699292 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings release P2 bugs (audit by bettes@)

Project Member Reported by scottchen@chromium.org, Mar 7 2017

Issue description

Various P2 bugs for MD Settings initial release, tracked here: https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4dbKrx4/edit#gid=0
 
Labels: Hotlist-MD-Settings-General
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c

commit 90711039262bcbbc20c28c6b6d79ce2d73aa5e3c
Author: scottchen <scottchen@chromium.org>
Date: Thu Mar 23 00:23:22 2017

MD Settings: move autofill and manage password toggles to their subpages.

Move toggles for autofill and passwords away from the main page, and move it in to their respective subpages.
Also move the extension indicator (and their unit tests) along with the toggle.

BUG= 699292 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2762433002
Cr-Commit-Position: refs/heads/master@{#458950}

[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Comment 5 by dbeam@chromium.org, Mar 27 2017

Blockedon: 703419
Status: Fixed (was: Started)
Blockedon: -703419

Sign in to add a comment