Email drop down is not needed in Guest/Supervised user session feedback window |
|||||||
Issue descriptionGoogle Chrome 58.0.3029.6 (Official Build) dev (64-bit) Revision 0 Platform 9334.2.0 (Official Build) dev-channel peppy What steps will reproduce the problem? 1. Login as guest user or supervised user 2. Alt + Shift + i to open feedback window 3. Check drop down beside Email field What is the expected result? Drop down is not needed as there is only one option available What happens instead? Drop down is shown. Attached screenshot.
,
Mar 10 2017
,
Mar 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/449ca301d5722d443b57ab5fd5db36a57b9f821a commit 449ca301d5722d443b57ab5fd5db36a57b9f821a Author: afakhry <afakhry@chromium.org> Date: Sat Mar 11 00:09:51 2017 Prevent adding an empty email option in the feedback app in guest mode BUG= 699287 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742103002 Cr-Commit-Position: refs/heads/master@{#456223} [modify] https://crrev.com/449ca301d5722d443b57ab5fd5db36a57b9f821a/chrome/browser/resources/feedback/js/feedback.js
,
Mar 11 2017
,
Mar 12 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/644edabf28d40898cfc8180c6ec8b7933b7ab2e4 commit 644edabf28d40898cfc8180c6ec8b7933b7ab2e4 Author: Ahmed Fakhry <afakhry@google.com> Date: Mon Mar 13 17:00:24 2017 [Merge to M58] Prevent adding an empty email option in the feedback app in guest mode TBR=xiyuan@chromium.org BUG= 699287 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742103002 Cr-Commit-Position: refs/heads/master@{#456223} (cherry picked from commit 449ca301d5722d443b57ab5fd5db36a57b9f821a) Review-Url: https://codereview.chromium.org/2747813002 . Cr-Commit-Position: refs/branch-heads/3029@{#153} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/644edabf28d40898cfc8180c6ec8b7933b7ab2e4/chrome/browser/resources/feedback/js/feedback.js
,
Mar 13 2017
,
Mar 15 2017
9334.11.0 / 58.0.3029.19 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sdantul...@chromium.org
, Mar 7 2017Summary: Email drop down is not needed in Guest/Supervised user session feedback window (was: Guest/Supervised user session)
55.1 KB
55.1 KB View Download