Autotest ARCHIVING status is dead |
|||||||
Issue descriptionAutotest ARCHIVING status is dead, it does nothing.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9 commit 3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9 Author: Allen Li <ayatane@chromium.org> Date: Wed Jun 14 04:23:59 2017 [autotest] Skip archiving after parsing Normally, PARSING -> ARCHIVING -> COMPLETED/FAILED but all ARCHIVING does is set the status. So cut the middleman and set the status immediately. BUG= chromium:699275 TEST=None Change-Id: I6d3d69a1e5aa9167405d301fa1e0af382f9c2b4e Reviewed-on: https://chromium-review.googlesource.com/507020 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9/scheduler/monitor_db_functional_test.py [modify] https://crrev.com/3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9/scheduler/postjob_task.py
,
Jun 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/372400ca002ed2367e7aed8c164cd1d9875af520 commit 372400ca002ed2367e7aed8c164cd1d9875af520 Author: Allen Li <ayatane@chromium.org> Date: Sat Jun 17 08:12:43 2017 [autotest] Remove _archive_results() The only remaining caller is in Agent._actually_fail_queue_entry() Agent._actually_fail_queue_entry() is only called prejob tasks. Agent._archive_results() is overridden by a method on SiteAgent. This new method only works on postjob tasks because it uses attributes like queue_entries and _final_status() that are only defined on post job tasks. Therefore, I think it is reasonable to assume nothing is actually using this call to _archive_results() currently. Theres a good way to know for sure, though. SCIENCE! BUG= chromium:699275 TEST=None Change-Id: I26d7d6315f496c17bdb842c6ff7c8eec35982ed9 Reviewed-on: https://chromium-review.googlesource.com/507021 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/372400ca002ed2367e7aed8c164cd1d9875af520/scheduler/site_monitor_db.py [modify] https://crrev.com/372400ca002ed2367e7aed8c164cd1d9875af520/scheduler/agent_task.py
,
Jun 22 2017
,
Jun 22 2017
Oh wait, we should do some cleanup
,
Jun 22 2017
,
Jun 22 2017
,
Jun 22 2017
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8745b0df766fc07c277b55c9b06f4c613f74b2e1 commit 8745b0df766fc07c277b55c9b06f4c613f74b2e1 Author: Allen Li <ayatane@chromium.org> Date: Fri Jun 23 07:51:21 2017 [autotest] Remove final vestiges of ARCHIVING BUG= chromium:699275 TEST=None Change-Id: I1555a7716f1e62e58b71f709afa4c95057282b6b Reviewed-on: https://chromium-review.googlesource.com/544532 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [delete] https://crrev.com/9ea833a44ddedc02399d2d00ebf436e70ace4efa/scheduler/archive_results.control.srv [modify] https://crrev.com/8745b0df766fc07c277b55c9b06f4c613f74b2e1/scheduler/agent_task.py [modify] https://crrev.com/8745b0df766fc07c277b55c9b06f4c613f74b2e1/scheduler/monitor_db.py [modify] https://crrev.com/8745b0df766fc07c277b55c9b06f4c613f74b2e1/scheduler/scheduler_models.py [modify] https://crrev.com/8745b0df766fc07c277b55c9b06f4c613f74b2e1/scheduler/postjob_task.py [modify] https://crrev.com/8745b0df766fc07c277b55c9b06f4c613f74b2e1/client/common_lib/host_queue_entry_states.py [modify] https://crrev.com/8745b0df766fc07c277b55c9b06f4c613f74b2e1/site_utils/collect_suite_time_stats.py
,
Jun 23 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 26 2017