New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699275 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autotest ARCHIVING status is dead

Project Member Reported by ayatane@chromium.org, Mar 7 2017

Issue description

Autotest ARCHIVING status is dead, it does nothing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0779f5fb99cbdb807714a53ee1da0526688fb047

commit 0779f5fb99cbdb807714a53ee1da0526688fb047
Author: Allen Li <ayatane@chromium.org>
Date: Fri May 26 00:15:56 2017

[autotest] Neuter archiving step

The archiving control file is literally just "pass".  To be sure,
though, remove the ARCHIVING step surgically to avoid surprises.

First, remove the core autoserv call.

BUG= chromium:699275 
TEST=None

Change-Id: I406d5b322f6eb02330e5fc38a2fa3d35d6a07c1e
Reviewed-on: https://chromium-review.googlesource.com/507018
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/0779f5fb99cbdb807714a53ee1da0526688fb047/scheduler/postjob_task.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9

commit 3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9
Author: Allen Li <ayatane@chromium.org>
Date: Wed Jun 14 04:23:59 2017

[autotest] Skip archiving after parsing

Normally, PARSING -> ARCHIVING -> COMPLETED/FAILED

but all ARCHIVING does is set the status.  So cut the middleman and
set the status immediately.

BUG= chromium:699275 
TEST=None

Change-Id: I6d3d69a1e5aa9167405d301fa1e0af382f9c2b4e
Reviewed-on: https://chromium-review.googlesource.com/507020
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9/scheduler/monitor_db_functional_test.py
[modify] https://crrev.com/3df0b2bf7e77ee4aecc629b40365d489f9e4cdc9/scheduler/postjob_task.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/372400ca002ed2367e7aed8c164cd1d9875af520

commit 372400ca002ed2367e7aed8c164cd1d9875af520
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jun 17 08:12:43 2017

[autotest] Remove _archive_results()

The only remaining caller is in Agent._actually_fail_queue_entry()

Agent._actually_fail_queue_entry() is only called prejob tasks.

Agent._archive_results() is overridden by a method on SiteAgent.  This
new method only works on postjob tasks because it uses attributes like
queue_entries and _final_status() that are only defined on post job
tasks.

Therefore, I think it is reasonable to assume nothing is actually
using this call to _archive_results() currently.

Theres a good way to know for sure, though.

SCIENCE!

BUG= chromium:699275 
TEST=None

Change-Id: I26d7d6315f496c17bdb842c6ff7c8eec35982ed9
Reviewed-on: https://chromium-review.googlesource.com/507021
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/372400ca002ed2367e7aed8c164cd1d9875af520/scheduler/site_monitor_db.py
[modify] https://crrev.com/372400ca002ed2367e7aed8c164cd1d9875af520/scheduler/agent_task.py

Labels: -Hotlist-Fixit
Status: Fixed (was: Untriaged)
Status: Started (was: Fixed)
Oh wait, we should do some cleanup
Owner: ayanaadylova@google.com
Owner: ayatane@chromium.org
Labels: Hotlist-Fixit
Status: Fixed (was: Started)

Sign in to add a comment