New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699265 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"Open [webapk]" maybe shouldn't launch start_url

Project Member Reported by jakearchibald@chromium.org, Mar 7 2017

Issue description

1. Install https://mobile.twitter.com as a webapk.
2. Navigate to https://mobile.twitter.com/jaffathecake.
3. In Chrome's menu, select "Open Twitter".

Twitter opens, but using the start_url. It feels like, in this case, the current URL should open in the app.
 
Cc: pkotw...@chromium.org
Components: Mobile>WebAPKs
Cc: jakearchibald@chromium.org
Sorry, can you clarify exactly which UI you're talking about when you say:

"In Chrome's menu, select "Open Twitter"."

Thanks!

Comment 3 by zpeng@chromium.org, Mar 7 2017

After a WebAPK is intalled for the current page, the "Add to Home Screen" or "Install Web app" item on Chrome's menu becomes "Open [WebAPK]". This is a recent change.
Labels: -Pri-3 Pri-1
Ah yeah that makes sense. As long as the current URL is in scope anyways (but I think it would have to be to see the "Open X" text.)
Sam, do we have a resolution for this bug? This is the type of bug that I would want UX input for :) UX is awesome

Comment 7 by sbirch@chromium.org, Mar 22 2017

Cc: chowse@chromium.org
Sorry for the delay, but +chowse to consult!

Chris, to summarize:

We currently show "Open <app>" in the overflow menu if you've already installed a WebAPK.

If you select this option while you're in the PWA, should that:
1) Open the PWA as if you had clicked the launcher (opening the start_url)
2) Open the page you're currently on (assuming it's in the scope of the PWA. This would basically remove the toolbar.)

I'm personally inclined to say that (2) makes more sense.
Owner: chowse@chromium.org
Status: Assigned (was: Untriaged)
Agreed but want Chris +1

Comment 9 by chowse@chromium.org, Apr 25 2017

Option (2) seems reasonable to me. The one case I envision people might want to go to the start_url directly rather than the current URL would be directly after installing the PWA, but there are already provisions in the install UI to do so.

How would you feel about labelling the action "Open in <app>", as a counterpart to "Open in Chrome" in PWAs/CCTs? It would make clearer that you're opening the current page in the app, not just launching the app. Would there be localization issues?

Cc: benwells@chromium.org
Owner: dominickn@chromium.org
I should note that detecting whether something is a "comment signed WebAPK" will become much more expensive. It will take around 50ms to detect something is a comment signed WebAPK.

This means that in order to detect whether an APK is a WebAPK we will need to check a cache which might be stale. I recommend removing the "Open WebAPK" option from the context menu.

I mentioned this idea a while ago in
https://docs.google.com/document/d/1-pyXlHMb1gGWN1l4Qegc_FvW-hMLhWy8jWksXsMnqh0
I would be happy with option 2. I think we would just need to do a scope check and set an EXTRA_URL field on the intent used to launch the WebAPK.

c#11: I think that is a discussion for another bug. It's conflating an engineering problem (verifying whether a site is a WebAPK is going to get slower) with a product question (if a user has managed to navigate to a site where the WebAPK is installed, what do we show in the menu). If this issue is urgent you should file a new bug and we can have the discussion there.
Dominick: I have filed Issue 716045
Project Member

Comment 14 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb9cdc06b446bad7a85a602c26098a687bffd911

commit bb9cdc06b446bad7a85a602c26098a687bffd911
Author: dominickn <dominickn@chromium.org>
Date: Mon May 08 05:14:50 2017

Open the current URL if a WebAPK is opened from the context menu.

Currently, when a WebAPK is installed, Chrome displays "Open <appname>"
in the context menu in place of "Add to home screen". When the user taps
the link, the WebAPK is launched to its start_url. This may differ from
the current URL that the user is on.

This CL explicitly sets the URL to be opened to the current page URL.
For example, if the user has installed mobile.twitter.com as a WebAPK,
then navigates to mobile.twitter.com/username, tapping the menu item
will open the Twitter WebAPK at the username's page rather than
Twitter's start_url.

BUG= 699265 

Review-Url: https://codereview.chromium.org/2864613002
Cr-Commit-Position: refs/heads/master@{#469908}

[modify] https://crrev.com/bb9cdc06b446bad7a85a602c26098a687bffd911/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Labels: Merge-Request-59
Requesting merge of c#14 to M59. It's a very small fix that's an important PE improvement for WebAPKs.
Project Member

Comment 16 by sheriffbot@chromium.org, May 10 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, May 10 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1897fd7b954eabba92e440b6fe0d210089b23d14

commit 1897fd7b954eabba92e440b6fe0d210089b23d14
Author: Dominick Ng <dominickn@chromium.org>
Date: Wed May 10 01:20:37 2017

Open the current URL if a WebAPK is opened from the context menu.

Currently, when a WebAPK is installed, Chrome displays "Open <appname>"
in the context menu in place of "Add to home screen". When the user taps
the link, the WebAPK is launched to its start_url. This may differ from
the current URL that the user is on.

This CL explicitly sets the URL to be opened to the current page URL.
For example, if the user has installed mobile.twitter.com as a WebAPK,
then navigates to mobile.twitter.com/username, tapping the menu item
will open the Twitter WebAPK at the username's page rather than
Twitter's start_url.

BUG= 699265 

Review-Url: https://codereview.chromium.org/2864613002
Cr-Commit-Position: refs/heads/master@{#469908}
(cherry picked from commit bb9cdc06b446bad7a85a602c26098a687bffd911)

Review-Url: https://codereview.chromium.org/2873873002 .
Cr-Commit-Position: refs/branch-heads/3071@{#495}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/1897fd7b954eabba92e440b6fe0d210089b23d14/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Status: Fixed (was: Assigned)
This should be fixed on Canary now and I've merged it to M59 as well. :)

Sign in to add a comment