New issue
Advanced search Search tips

Issue 699264 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove unused PreviewsDataSavings and previews/ DEPS on d_r_p/

Project Member Reported by ryansturm@chromium.org, Mar 7 2017 
PreviewsDataSavings is an unused class that is unnecessary. Initially, this was intended to be used by previews to record savings for various previews and hook it into the data_reduction_proxy savings logic. This design doesn't make sense right now for the previews considered, and previews should track their own savings.

The previews/ component ideally should not depend on any previews, instead the previews should depend on previews/. Currently, previews is just the previews blacklist and some classes around that.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2aebea4889eee1f1d960590605a4544da63f51

commit 3f2aebea4889eee1f1d960590605a4544da63f51
Author: ryansturm <ryansturm@chromium.org>
Date: Wed Mar 08 05:56:54 2017

Removing unused PreviewsDataSavings

PreviewsDataSavings is an unused class that is unnecessary. Initially,
this was intended to be used by previews to record savings for various
previews and hook it into the data_reduction_proxy savings logic. This
design doesn't make sense right now for the previews considered, and
previews should track their own savings.

As previews progresses, the data savings can be moved from d_r_p if
necessary into previews, but the dependency from previews to d_r_p is
largely backwards.

BUG= 699264 

Review-Url: https://codereview.chromium.org/2736953003
Cr-Commit-Position: refs/heads/master@{#455388}

[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/data_reduction_proxy/core/common/BUILD.gn
[delete] https://crrev.com/b86c2dc8b581ec650806e80b7c112682078ffb0b/components/data_reduction_proxy/core/common/data_savings_recorder.h
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/previews/core/BUILD.gn
[modify] https://crrev.com/3f2aebea4889eee1f1d960590605a4544da63f51/components/previews/core/DEPS
[delete] https://crrev.com/b86c2dc8b581ec650806e80b7c112682078ffb0b/components/previews/core/previews_data_savings.cc
[delete] https://crrev.com/b86c2dc8b581ec650806e80b7c112682078ffb0b/components/previews/core/previews_data_savings.h
[delete] https://crrev.com/b86c2dc8b581ec650806e80b7c112682078ffb0b/components/previews/core/previews_data_savings_unittest.cc

Comment 2 by ryansturm@chromium.org, Mar 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment