Clean up background scheduler related code. * Clean up device conditions * Move to background_task_offliner when GCM available.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5 commit 4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5 Author: fgorski <fgorski@chromium.org> Date: Wed Mar 08 18:38:14 2017 [Offline pages] Clean up of device conditions related code This change moves all DeviceConditions related code to that class and removes all the static methods for propagating conditions from OfflinePageUtils and other classes, except for the scheduler bridge. The code also adds a ShadowDeviceConditions to enable mocking of static methods for testing. BUG= 699261 Review-Url: https://codereview.chromium.org/2737093002 Cr-Commit-Position: refs/heads/master@{#455498} [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeviceConditions.java [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/java_sources.gni [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java [modify] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTestRunner.java [add] https://crrev.com/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowDeviceConditions.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252 commit c3cf4c7d10c4796ef841fc181d0207cfdc4ad252 Author: fgorski <fgorski@chromium.org> Date: Thu Jun 01 18:10:17 2017 [Offline pages] Updates to background scheduling to use BTS This patch moves offline page scheduling for pre-M OSs to background_task_scheduler component and removes a lot of code in the process: * switches offline page handling in ChromeBackgroundService to reschedule * removes ChromeBackgroundserviceWaiter * removes subclasses of BackgroundScheduler (responsible for scheduling on different OS versions) * Moves useful code from BackgroundOfflinerTask to OfflineBackgroundTask * Simplifies BackgroundSchedulerProcessor (and removes namespace for interfaces) * Updates the tests for classes mentioned above. BUG= 699261 Review-Url: https://codereview.chromium.org/2830843002 Cr-Commit-Position: refs/heads/master@{#476352} [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundServiceWaiter.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundGcmScheduler.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundJobScheduler.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java [add] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerProcessor.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerProcessorImpl.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeviceConditions.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTask.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPacker.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/interfaces/BackgroundSchedulerProcessor.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/java_sources.gni [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackgroundServiceWaiterTest.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java [add] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTaskTest.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowGcmNetworkManager.java [delete] https://crrev.com/4f63947164ec18f2eaed90dd1192d593dad51781/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java [modify] https://crrev.com/c3cf4c7d10c4796ef841fc181d0207cfdc4ad252/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerFactory.java
Comment 1 by bugdroid1@chromium.org
, Mar 8 2017