New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 699258 link

Starred by 1 user
Status: Fixed
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
bjoyce@chromium.org
█ manoranj...@chromium.org
█ wrengr@chromium.org
pucchakayala@chromium.org
ligim...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Predator] Always show culprit cl input textarea

Project Member Reported by kateso...@chromium.org, Mar 7 2017 
[Predator] Always show culprit cl input textarea 

Sometimes we give several suspected cls, but there is only one culprit cl in it. We should always show the culprit cl input textarea, so when we triage it, we can narrow down the correct result to the exact culprit cl.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/eea3f61834445a17c33a840183ea70c28b8212b0

commit eea3f61834445a17c33a840183ea70c28b8212b0
Author: Sharu Jiang <katesonia@google.com>
Date: Fri Mar 24 19:52:11 2017

[Predator] Always show culprit cl input textarea

Previous, when you click Triage-Correct for suspected cls, the input textarea won't show(but Triage-Incorrect, Triage-Unsure will).

But, sometimes, we have several suspected cls instead of just one, in order to get the exact culprit cl as feedback, enabling input textarea for ``Triage-Correct`` as well.

Example testing page: https://katesonia-show-culprit-test-dot-predator-for-me-staging.appspot.com/crash/cracas-result-feedback?key=ahlzfnByZWRhdG9yLWZvci1tZS1zdGFnaW5nckELEhNDcmFjYXNDcmFzaEFuYWx5c2lzIigzODg2ZTVlMDcwMGY5OTgyOTAxMzQ3ZTA1NWMwMWFhZDA1YTc5NjY4DA
BUG= 699258 

Change-Id: I32ce91351cf8b39384138aeb03fb2531599e42b9
Reviewed-on: https://chromium-review.googlesource.com/450914
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Sharu Jiang <katesonia@google.com>

[modify] https://crrev.com/eea3f61834445a17c33a840183ea70c28b8212b0/appengine/findit/handlers/crash/test/result_feedback_test.py
[modify] https://crrev.com/eea3f61834445a17c33a840183ea70c28b8212b0/appengine/findit/templates/crash/result_feedback.html
[modify] https://crrev.com/eea3f61834445a17c33a840183ea70c28b8212b0/appengine/findit/handlers/crash/result_feedback.py

Comment 2 by kateso...@chromium.org, Mar 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment