New issue
Advanced search Search tips

Issue 699257 link

Starred by 0 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

DevTools: calling non-existing method Dialog.detach

Project Member Reported by dgozman@chromium.org, Mar 7 2017 
This was regressed in crrev.com/3e3774f369e1e642d06e895276b08814b279c20c and made it to M58. Will probably need to merge.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e2f711d53961feb53d460fd96073ad47ef4a366

commit 0e2f711d53961feb53d460fd96073ad47ef4a366
Author: dgozman <dgozman@chromium.org>
Date: Wed Mar 08 00:06:18 2017

[DevTools] Do not use Dialog.detach as it doesn't exist.

This is a leftover from refactoring in crrev.com/3e3774f369e1e642d06e895276b08814b279c20c.

BUG= 699257 

Review-Url: https://codereview.chromium.org/2734213003
Cr-Commit-Position: refs/heads/master@{#455302}

[modify] https://crrev.com/0e2f711d53961feb53d460fd96073ad47ef4a366/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Comment 2 by dgozman@chromium.org, Mar 8 2017

Status: Fixed (was: Assigned)

Comment 3 by dgozman@chromium.org, Mar 8 2017

Labels: ReleaseBlock-Stable
We'll need to merge this.
►

Sign in to add a comment