New issue
Advanced search Search tips

Issue 699256 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Add Upstreaming UKM

Project Member Reported by se...@chromium.org, Mar 7 2017

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adcdf2d7c58a495e0f917a50148c2f041a1a6e85

commit adcdf2d7c58a495e0f917a50148c2f041a1a6e85
Author: sebsg <sebsg@chromium.org>
Date: Fri Mar 10 21:41:50 2017

[Autofill] Add upstreaming UKM

BUG= 699256 

Review-Url: https://codereview.chromium.org/2740633002
Cr-Commit-Position: refs/heads/master@{#456173}

[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/DEPS
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/components/ukm/ukm_service.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/adcdf2d7c58a495e0f917a50148c2f041a1a6e85/ios/chrome/browser/ui/autofill/autofill_client_ios.mm

Comment 2 by se...@chromium.org, Mar 13 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 13 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M58, could you please confirm change is well baked/verified in Canary, having enough automation coverage and will be a safe merge to M58?

Comment 5 by se...@chromium.org, Mar 14 2017

It has been in Canary since 59.0.3040.0 and my current version of Canary is 59.0.3041.0. Also it only adds metrics and is behind a flag. It should be safe to merge.

Comment 6 by gov...@chromium.org, Mar 14 2017

Labels: -Merge-Review-58 Merge-Approved-58
Approving merge to M58 branch 3029 based on comment #5. Please merge ASAP. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 15 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9

commit 9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9
Author: sebsg <sebsg@chromium.org>
Date: Wed Mar 15 15:47:28 2017

[Merge-58] Autofill - :Add upstreaming UKM

BUG= 699256 

Review-Url: https://codereview.chromium.org/2740633002
Cr-Commit-Position: refs/heads/master@{#456173}
(cherry picked from commit adcdf2d7c58a495e0f917a50148c2f041a1a6e85)

Review-Url: https://codereview.chromium.org/2755703002 .
Cr-Commit-Position: refs/branch-heads/3029@{#204}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/DEPS
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/components/ukm/ukm_service.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/9e23d5cb10c00d87f2bd9d7bd5f542d5241cfdf9/ios/chrome/browser/ui/autofill/autofill_client_ios.mm

Comment 8 by se...@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Sign in to add a comment