New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699255 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 609316
issue 787176



Sign in to add a comment

Migrate GpuJpegDecodeAccelerator to Mojo

Project Member Reported by chfremer@chromium.org, Mar 7 2017

Issue description

class GpuJpegDecodeAccelerator uses (legacy) Chromium IPC and should be migrated to Mojo.

See class GpuJpegDecoderAccelerator::MessageFilter here
https://cs.chromium.org/chromium/src/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc?q=GpuJpegDecodeAccelerator&dr=CSs&l=140
 
Cc: wuchengli@chromium.org dalecur...@chromium.org posciak@chromium.org sande...@chromium.org
Labels: -Pri-3 OS-Android OS-Chrome OS-Mac OS-Windows Pri-2
adding OWNERS of media/gpu, who might know more of what are the
plans to move the video encode/decode accelerator IPCs to Mojo
MojoVideoDecoder work is in progress by sandersd@; we haven't planned anything for the encoder - that's generally handled by a capture team.
Components: Blink>WebRTC>Video
Status: Available (was: Untriaged)
wuchengli@, posciak@ any plans regarding this? 
Tentatively marking as Available.

mcasas@: no immediate plans currently from our side.

Comment 5 by c.pa...@samsung.com, May 24 2017

If nobody is working on this, can I take this one up?
That's an okay from my side. I have changes for class VideoCaptureGpuJpegDecoder in my local stash, but that should not overlap with this work.
Owner: c.pa...@samsung.com
Status: Assigned (was: Available)
That's great. Assigning to you.

I'm curious. Why do you want to work on this? Is there any other task blocked by this?

Comment 8 by c.pa...@samsung.com, May 25 2017

I came across this bug in the source code. Being new to Mojo (have been using IPCs all this while), I saw this as an opportunity to get some hands on experience of Mojo.

I shall do a quick code analysis w.r.t this and put forward my understanding (on what has to be done) here. Thank you.

Comment 9 by c.pa...@samsung.com, May 26 2017

I think we need to do the following:
[1] Define media::BitstreamBuffer and AcceleratedJpegDecoderMsg_Decode_Params for mojo.
[2] Add interfaces for GpuJpegDecodeAcceleratorHost and GpuJpegDecodeAccelerator.
[3] Register these interfaces.
[4] Set up a connection between the two.

Created https://codereview.chromium.org/2905823002/ for [1] and [2].
Cc: xhw...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eed40bc79df20716a280b62fb3d1f1f0a40df0a1

commit eed40bc79df20716a280b62fb3d1f1f0a40df0a1
Author: c.padhi <c.padhi@samsung.com>
Date: Fri Jun 02 17:45:06 2017

Add Mojo interfaces for GpuJpegDecodeAccelerator and GpuJpegDecodeAcceleratorHost

This CL is the first step towards mojification of GpuJpegDecodeAccelerator(GJDA)
and GpuJpegDecodeAcceleratorHost(GJDAH).

1. Defines media::BitstreamBuffer and AcceleratedJpegDecoderMsg_Decode_Params for mojo.
2. GJDA and GJDAH implement these interfaces. Currently, these implementations are empty.

BUG=699255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2905823002
Cr-Commit-Position: refs/heads/master@{#476712}

[modify] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h
[modify] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
[modify] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h
[add] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/mojo/BUILD.gn
[add] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/mojo/OWNERS
[add] https://crrev.com/eed40bc79df20716a280b62fb3d1f1f0a40df0a1/media/gpu/mojo/jpeg_decoder.mojom

Created https://chromium-review.googlesource.com/c/525672/ for replacing JPEG decoder IPC messages with mojo calls to GpuJpegDecodeAccelerator interface.
Cc: jcliang@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f0388a44a385a22e51fbec4cd61bfe9d148990a

commit 5f0388a44a385a22e51fbec4cd61bfe9d148990a
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Wed Jun 28 18:55:15 2017

Add RequestGPUInfo() method to GpuProcessHost

Currently, VideoCaptureGpuJpegDecoder uses GpuChannelHost
to get GpuInfo. GpuChannelHost will no longer be used when
JPEG Decoder IPC is migrated mojo. In that case, GpuInfo
will be fetched from GpuProcessHost directly.

This CL is in preparation for migration of JPEG Decoder IPC
to mojo in https://chromium-review.googlesource.com/c/525672.

Bug: 699255
Change-Id: I43b177ec8b78c27d8fdf558851af4a306d5e50bc
Reviewed-on: https://chromium-review.googlesource.com/544480
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#483081}
[modify] https://crrev.com/5f0388a44a385a22e51fbec4cd61bfe9d148990a/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/5f0388a44a385a22e51fbec4cd61bfe9d148990a/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/5f0388a44a385a22e51fbec4cd61bfe9d148990a/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/5f0388a44a385a22e51fbec4cd61bfe9d148990a/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642

commit c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Tue Jul 11 12:20:41 2017

Add CreateJpegDecodeAccelerator() method to mojom.Gpu and mojom.GpuService

This CL adds CreateJpegDecodeAccelerator() method to mojom::Gpu
and mojom::GpuService interfaces. It also adds a method with the
same name to ui::Gpu, which will be called in the browser to create
a mojom::GpuJpegDecodeAccelerator implementation in the gpu process.

This CL is in preparation for migration of JPEG Decoder IPC
to mojo in https://chromium-review.googlesource.com/c/525672.

Bug: 699255
Change-Id: I2292cccf3b0be01e6f982ad921f5ae63183552bc
Reviewed-on: https://chromium-review.googlesource.com/544404
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485604}
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/content/browser/gpu/gpu_client.cc
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/content/browser/gpu/gpu_client.h
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/gpu/gpu_service.cc
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/gpu/gpu_service.h
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/gpu/interfaces/BUILD.gn
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/gpu/interfaces/gpu_service.mojom
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/public/cpp/gpu/gpu.h
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/c6a9b97dd562c9f9a52f4a3452d8b36d5bd8a642/services/ui/ws/gpu_client.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ddceeaa46673a5a5158eda50f40f608dbf6442

commit c1ddceeaa46673a5a5158eda50f40f608dbf6442
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Thu Jul 13 07:46:27 2017

media: Add an async version of Initialize() method to JDA

This CL introduces an async Initialize() method to JpegDecodeAccelerator
that would eventually replace the sync method. It also makes Initialize()
method in mojom::GpuJpegDecodeAccelerator interface asynchronous.

It is in preparation for migration of JPEG Decoder IPC to mojo in
https://chromium-review.googlesource.com/c/525672.

Bug: 699255
Change-Id: I405c4422e27ada61ace143d7607209b2aceb2e33
Reviewed-on: https://chromium-review.googlesource.com/567943
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486307}
[modify] https://crrev.com/c1ddceeaa46673a5a5158eda50f40f608dbf6442/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.cc
[modify] https://crrev.com/c1ddceeaa46673a5a5158eda50f40f608dbf6442/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h
[modify] https://crrev.com/c1ddceeaa46673a5a5158eda50f40f608dbf6442/media/gpu/mojo/jpeg_decoder.mojom
[modify] https://crrev.com/c1ddceeaa46673a5a5158eda50f40f608dbf6442/media/video/jpeg_decode_accelerator.h

Blockedon: 609316
Cc: sadrul@chromium.org piman@chromium.org
Hi. What's the status of this? We are planning to use Jpeg HW decoder from camera HAL process. What's the relationship of 609316 and this issue?
Cc: mojahsu@chromium.org
wuchengli@chromium.org: We already have the final CL https://chromium-review.googlesource.com/c/525672 for this task in place. However, it needs gpu client access in browser for which it is dependent on https://crrev.com/2967573002. Please see https://chromium-review.googlesource.com/c/525672/17/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc#273. I think 609316 does this work of using gpu client in browser. Hence, it put 609316 as a blocker for this task.
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/056e78745441ec9f9641b9f59b208ab2ddffe627

commit 056e78745441ec9f9641b9f59b208ab2ddffe627
Author: Valery Arkhangorodsky <varkha@chromium.org>
Date: Fri Sep 08 06:51:20 2017

Implements CreateVideoEncodeAcceleratorProvider

This CL implements ws::GpuClient::CreateVideoEncodeAcceleratorProvider()
which was NOTIMPLEMENTED before.

Bug: 699255
Change-Id: I379b59fd21d56c962d10ccf6f38c58cee750460a
Reviewed-on: https://chromium-review.googlesource.com/656100
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Valery Arkhangorodsky <varkha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500528}
[modify] https://crrev.com/056e78745441ec9f9641b9f59b208ab2ddffe627/services/ui/ws/gpu_client.cc

Hello, 

https://chromium-review.googlesource.com/c/525672 is blocked and looks like it needs some time.
We want to use Jpeg HW decoder from camera HAL process by mojo,
so I want to create media/gpu/ipc/service/gpu_jpeg_decode_accelerator_mojo.[cc|h] files
which use mojo interfaces based on this CL https://chromium-review.googlesource.com/c/525672 for our purpose now.
We can remove them later after the CL merged.
Hello c.padhi@samsung.com,

I think we can skip the dependency of https://crrev.com/2967573002
Please take the following CL as your reference.
https://chromium-review.googlesource.com/c/chromium/src/+/760377/1..2
I tested it on samus.
We can keep https://chromium-review.googlesource.com/c/525672 moving forward.
mojahsu@chromium.org: Thank you for the above information.
I have updated https://chromium-review.googlesource.com/c/525672 accordingly.
c.padhi@samsung.com:

We need the patch 
https://chromium-review.googlesource.com/c/chromium/src/+/760377/1..2/media/gpu/mojo/jpeg_decoder_typemap_traits.cc
otherwise the mojo channel will be broken when we call the remote method Decode.

Sorry, I missed that change. I'll upload another patchset.
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4

commit dc46a0412a516d4668d6bc41a29f243fe7ee4ce4
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Fri Nov 17 04:51:18 2017

Convert accelerated JPEG Decoder IPC to Mojo

This CL adds implementation for GJDA's mojom interface which
was introduced in [1]. GJDA interface that runs in the gpu
process is exposed to the browser process via ui::Gpu.
The mojo connection between browser and gpu is set up by a
call to ui::Gpu::CreateJpegDecodeAccelerator().
Existing JPEG decoder IPC messages between browser and gpu
have been replaced with mojo calls to GJDA interface.

GJDA unittest has been updated to use the new mojo implementation.

[1] https://codereview.chromium.org/2905823002/

Bug: 699255
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I158c2f7c7d77f9a042fef0630c4ac07160c6e903
Reviewed-on: https://chromium-review.googlesource.com/525672
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517304}
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/BUILD.gn
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/DEPS
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.cc
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/common/media_param_traits_macros.h
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/service/gpu_jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/service/media_gpu_channel.cc
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/ipc/service/media_gpu_channel.h
[modify] https://crrev.com/dc46a0412a516d4668d6bc41a29f243fe7ee4ce4/media/gpu/mojo/jpeg_decoder_typemap_traits.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f

commit d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Nov 21 22:43:31 2017

jda: move files from media/gpu to media/mojo

This CL moves the Jpeg decode accelerator-related files from their
locations in //media/gpu/ipc/{client,service} and //media/gpu/mojo
into //media/mojo/{clients,interfaces,services}.

This follows up on the TODOs in [1,2]. Most of the updates are fully
automatic using tools/git/mass-rename.py.

Bug: 699255

[1] https://cs.chromium.org/chromium/src/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h?dr&l=22
[2] https://cs.chromium.org/chromium/src/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h?dr&l=21

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0ed7f94f1bfc258756293cde6bdd228e6f0197c7
Reviewed-on: https://chromium-review.googlesource.com/778000
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518419}
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/content/browser/BUILD.gn
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/gpu/BUILD.gn
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/gpu/ipc/service/BUILD.gn
[delete] https://crrev.com/100328a4719716df4235070b48978414a6007933/media/gpu/mojo/BUILD.gn
[delete] https://crrev.com/100328a4719716df4235070b48978414a6007933/media/gpu/mojo/DEPS
[delete] https://crrev.com/100328a4719716df4235070b48978414a6007933/media/gpu/mojo/OWNERS
[delete] https://crrev.com/100328a4719716df4235070b48978414a6007933/media/gpu/mojo/typemaps.gni
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/clients/BUILD.gn
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/clients/gpu_jpeg_decode_accelerator_host.cc
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/clients/gpu_jpeg_decode_accelerator_host.h
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/interfaces/BUILD.gn
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/interfaces/jpeg_decoder.mojom
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/interfaces/jpeg_decoder.typemap
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/interfaces/jpeg_decoder_typemap_traits.cc
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/interfaces/jpeg_decoder_typemap_traits.h
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/interfaces/typemaps.gni
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/services/BUILD.gn
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/services/gpu_jpeg_decode_accelerator.cc
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/services/gpu_jpeg_decode_accelerator.h
[rename] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/media/mojo/services/gpu_jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/services/viz/privileged/interfaces/gl/BUILD.gn
[modify] https://crrev.com/d9f6e099e9c7b3ab4dfa182e32adc0ae2599f63f/services/viz/privileged/interfaces/gl/gpu_service.mojom

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7898097d74ceb925be4c022034d796440c942d2

commit b7898097d74ceb925be4c022034d796440c942d2
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Nov 22 19:48:09 2017

Rename jpeg_decoder mojom to jpeg_decode_accelerator

This CL follow up on the cleanup of crrev.com/c/778000 by
renaming the file
 jpeg_decoder.mojom --> jpeg_decode_accelerator.mojom
(and the interface inside) to line up with the other
//media/mojo/interfaces, e.g. video_encode_accelerator etc.

The rest of the CL is a lot of
  s/GpuJpegDecodeAccelerator/JpegDecodeAccelerator/
and a few ::media::JpegDecodeAccelerator to disambiguate
where needed.

TBR=avi@chromium.org
for content/browser/gpu/gpu_client.{cc,h}, because the
change is straightforward.

Bug: 699255
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I51fc458182d847cd4601a04be5650cb1a4de06fb
Reviewed-on: https://chromium-review.googlesource.com/783890
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#518712}
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/content/browser/gpu/gpu_client.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/content/browser/gpu/gpu_client.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/clients/gpu_jpeg_decode_accelerator_host.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/clients/gpu_jpeg_decode_accelerator_host.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/interfaces/BUILD.gn
[rename] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/interfaces/jpeg_decode_accelerator.mojom
[rename] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/interfaces/jpeg_decode_accelerator.typemap
[rename] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/interfaces/jpeg_decode_accelerator_typemap_traits.cc
[rename] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/interfaces/jpeg_decode_accelerator_typemap_traits.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/interfaces/typemaps.gni
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/services/gpu_jpeg_decode_accelerator.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/services/gpu_jpeg_decode_accelerator.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/media/mojo/services/gpu_jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/ui/public/cpp/gpu/gpu.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/ui/ws/gpu_client.h
[modify] https://crrev.com/b7898097d74ceb925be4c022034d796440c942d2/services/viz/privileged/interfaces/gl/gpu_service.mojom

Blockedon: 787176
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7

commit e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Nov 24 16:37:19 2017

Rename GpuJpegDecodeAccelerator{Host} files

This CL follows up the naming nits [1] re. JpegDecodeAccelerator:
gpu_jpeg_decode_accelerator... files --> mojo_jpeg_decode_accelerator...

which in turn forces the class renaming:

 s/GpuJpegDecodeAccelerator/MojoJpegDecodeAcceleratorService/

 s/GpuJpegDecodeAcceleratorHost/MojoJpegDecodeAccelerator/

TBR=danakj@chromium.org for the mechanical trivial change in
 components/viz/service/gl/gpu_service_impl.cc

[1] crrev.com/c/783890

Bug: 699255
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I737c52cf8eb02056a3ffce1c674e5067b67fbd73
Reviewed-on: https://chromium-review.googlesource.com/786304
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#519132}
[modify] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
[modify] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/clients/BUILD.gn
[rename] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/clients/mojo_jpeg_decode_accelerator.cc
[rename] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/clients/mojo_jpeg_decode_accelerator.h
[modify] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/services/BUILD.gn
[rename] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/services/mojo_jpeg_decode_accelerator_service.cc
[rename] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/services/mojo_jpeg_decode_accelerator_service.h
[rename] https://crrev.com/e5bc870e3e7c6f91773ab86cf75b27b670c1e6b7/media/mojo/services/mojo_jpeg_decode_accelerator_service_unittest.cc

Sign in to add a comment