New issue
Advanced search Search tips

Issue 699244 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocked on:
issue 807627



Sign in to add a comment

Upstream position:sticky tests to web-platform-tests suite

Project Member Reported by smcgruer@chromium.org, Mar 7 2017

Issue description

Tracking bug for Q1 OKR; begin upstreaming our position:sticky test suites to web-platform-tests repo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b62b50144a75397c298a1cb49f39a1e87abf665d

commit b62b50144a75397c298a1cb49f39a1e87abf665d
Author: smcgruer <smcgruer@chromium.org>
Date: Fri Apr 21 14:43:59 2017

Upstream first set of position:sticky tests to WPT

This first CL contains some basic tests of top/bottom/left/right
constraint support.

BUG=699244

Review-Url: https://codereview.chromium.org/2734203003
Cr-Commit-Position: refs/heads/master@{#466328}

[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-bottom-ref.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-bottom.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-left-ref.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-left.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-right-ref.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-right.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-top-ref.html
[add] https://crrev.com/b62b50144a75397c298a1cb49f39a1e87abf665d/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-top.html
[delete] https://crrev.com/d7a6b51c01f1ad0c3de33a6eb8aa92c0232db1e6/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-left-expected.html
[delete] https://crrev.com/d7a6b51c01f1ad0c3de33a6eb8aa92c0232db1e6/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-left.html
[delete] https://crrev.com/d7a6b51c01f1ad0c3de33a6eb8aa92c0232db1e6/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-expected.html
[delete] https://crrev.com/d7a6b51c01f1ad0c3de33a6eb8aa92c0232db1e6/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top.html

Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/801c4b4606bec92bfa5ec4ef6900905eee920315

commit 801c4b4606bec92bfa5ec4ef6900905eee920315
Author: smcgruer <smcgruer@chromium.org>
Date: Thu May 25 19:16:59 2017

Upstream position: sticky <th> tests to WPT

BUG=699244

Review-Url: https://codereview.chromium.org/2876853003
Cr-Commit-Position: refs/heads/master@{#474744}

[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-bottom-ref.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-bottom.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-left-ref.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-left.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-right-ref.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-right.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-top-ref.html
[add] https://crrev.com/801c4b4606bec92bfa5ec4ef6900905eee920315/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-top.html
[delete] https://crrev.com/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-th-top-expected.html
[delete] https://crrev.com/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-th-top.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf01e4dcb9fce62221d4e3ac0c959f2f5f26f84

commit 9bf01e4dcb9fce62221d4e3ac0c959f2f5f26f84
Author: yigu <yigu@chromium.org>
Date: Thu Jun 01 19:41:34 2017

Sticky position should be observable by getBoundingClientRect.

BUG=699244

Review-Url: https://codereview.chromium.org/2907243002
Cr-Commit-Position: refs/heads/master@{#476392}

[add] https://crrev.com/9bf01e4dcb9fce62221d4e3ac0c959f2f5f26f84/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55d5a79abccc64ebaadadfc41013dd305d3959b9

commit 55d5a79abccc64ebaadadfc41013dd305d3959b9
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Jul 31 17:06:30 2017

Upstream sticky-nested-{top, left, bottom, right}.html to WPT

Bug: 699244
Change-Id: I4cc9d213d5a1ca96631d77388f286592b5bffd1e
Reviewed-on: https://chromium-review.googlesource.com/558495
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490777}
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-bottom-ref.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-bottom.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-left-ref.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-left.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-right-ref.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-right.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-top-ref.html
[add] https://crrev.com/55d5a79abccc64ebaadadfc41013dd305d3959b9/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-nested-top.html
[delete] https://crrev.com/7ad1bb17ff3f134decf7280490c46776c58da1a4/third_party/WebKit/LayoutTests/fast/css/sticky/nested/sticky-nested-left-expected.html
[delete] https://crrev.com/7ad1bb17ff3f134decf7280490c46776c58da1a4/third_party/WebKit/LayoutTests/fast/css/sticky/nested/sticky-nested-left.html
[delete] https://crrev.com/7ad1bb17ff3f134decf7280490c46776c58da1a4/third_party/WebKit/LayoutTests/fast/css/sticky/nested/sticky-nested-top-expected.html
[delete] https://crrev.com/7ad1bb17ff3f134decf7280490c46776c58da1a4/third_party/WebKit/LayoutTests/fast/css/sticky/nested/sticky-nested-top.html

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7430bcf59c21f653a1ab789610fefe662650efa

commit b7430bcf59c21f653a1ab789610fefe662650efa
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Aug 03 15:33:16 2017

Upstream sticky margin tests to WPT

Bug: 699244
Change-Id: Ie7d573bbda8e57cc718137f04a4b1fb0bde14355
Reviewed-on: https://chromium-review.googlesource.com/598589
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491745}
[add] https://crrev.com/b7430bcf59c21f653a1ab789610fefe662650efa/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-margins-ref.html
[add] https://crrev.com/b7430bcf59c21f653a1ab789610fefe662650efa/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-margins.html
[delete] https://crrev.com/af38db52e9cedeca6a7ad920339bf09b36c65255/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margins-expected.html
[delete] https://crrev.com/af38db52e9cedeca6a7ad920339bf09b36c65255/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margins.html
[delete] https://crrev.com/af38db52e9cedeca6a7ad920339bf09b36c65255/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-side-margins-expected.html
[delete] https://crrev.com/af38db52e9cedeca6a7ad920339bf09b36c65255/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-side-margins.html
[delete] https://crrev.com/af38db52e9cedeca6a7ad920339bf09b36c65255/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-margins-expected.html
[delete] https://crrev.com/af38db52e9cedeca6a7ad920339bf09b36c65255/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-margins.html

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151d23f1f23af1a426020f9a906afcc5677a476e

commit 151d23f1f23af1a426020f9a906afcc5677a476e
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Fri Aug 04 13:14:48 2017

Upstream sticky-writing-mode-* to WPT

Bug: 699244
Change-Id: I83055b050cad7f85e8b235f40203d559d1f337aa
Reviewed-on: https://chromium-review.googlesource.com/600853
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492005}
[add] https://crrev.com/151d23f1f23af1a426020f9a906afcc5677a476e/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-writing-modes-ref.html
[add] https://crrev.com/151d23f1f23af1a426020f9a906afcc5677a476e/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-writing-modes.html
[delete] https://crrev.com/8846e970a6ffcc6f3fc5fd554a3969b802899922/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr-expected.html
[delete] https://crrev.com/8846e970a6ffcc6f3fc5fd554a3969b802899922/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html
[delete] https://crrev.com/8846e970a6ffcc6f3fc5fd554a3969b802899922/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl-expected.html
[delete] https://crrev.com/8846e970a6ffcc6f3fc5fd554a3969b802899922/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 23 2017

Blockedon: 807627
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2686180f61962d5fabdc640bfa7b2abb98c13395

commit 2686180f61962d5fabdc640bfa7b2abb98c13395
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Mar 07 15:18:02 2018

Reland "Port another set of sticky tests to JS rather than reftests"

This is a reland of 913109149534a732bdb5461d0ba2759f5d2f50f4

Now that the WPT test infra has been pulled from upstream, the hope is
that changing tests from reftest to jsharness won't cause the bots to
fail horribly.

Original change's description:
> Port another set of sticky tests to JS rather than reftests
>
> Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
> Reviewed-on: https://chromium-review.googlesource.com/882002
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532966}

Bug: 699244
Change-Id: Ib8c16d08f1327765e0bd322a708452373db8581c
Reviewed-on: https://chromium-review.googlesource.com/951662
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541437}
[delete] https://crrev.com/42864292ecfb1a33c65aeafc9a9271140cf85638/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-inflow-position-ref.html
[modify] https://crrev.com/2686180f61962d5fabdc640bfa7b2abb98c13395/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-inflow-position.html
[delete] https://crrev.com/42864292ecfb1a33c65aeafc9a9271140cf85638/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-margins-ref.html
[modify] https://crrev.com/2686180f61962d5fabdc640bfa7b2abb98c13395/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-margins.html
[delete] https://crrev.com/42864292ecfb1a33c65aeafc9a9271140cf85638/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-overflow-padding-ref.html
[modify] https://crrev.com/2686180f61962d5fabdc640bfa7b2abb98c13395/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-overflow-padding.html
[delete] https://crrev.com/42864292ecfb1a33c65aeafc9a9271140cf85638/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-root-scroller-ref.html
[modify] https://crrev.com/2686180f61962d5fabdc640bfa7b2abb98c13395/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-root-scroller.html
[delete] https://crrev.com/42864292ecfb1a33c65aeafc9a9271140cf85638/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-transforms-ref.html
[delete] https://crrev.com/42864292ecfb1a33c65aeafc9a9271140cf85638/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-transforms-translate-ref.html
[modify] https://crrev.com/2686180f61962d5fabdc640bfa7b2abb98c13395/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-transforms-translate.html
[modify] https://crrev.com/2686180f61962d5fabdc640bfa7b2abb98c13395/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-transforms.html

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd94f87e0ba9c78540e989888ae6f32e4546d184

commit fd94f87e0ba9c78540e989888ae6f32e4546d184
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Mar 27 18:17:30 2018

Port nested sticky tests from reftests to JS tests

Bug: 699244
Change-Id: Ia85a44be9d9f7b0d0db382892520f2755523f514
Reviewed-on: https://chromium-review.googlesource.com/980236
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546172}
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-left.html
[delete] https://crrev.com/4c97ba8c9a34159a5951206ecacfb5db3b24cdf2/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-bottom-ref.html
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-bottom.html
[delete] https://crrev.com/4c97ba8c9a34159a5951206ecacfb5db3b24cdf2/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-left-ref.html
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-left.html
[delete] https://crrev.com/4c97ba8c9a34159a5951206ecacfb5db3b24cdf2/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-right-ref.html
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-right.html
[delete] https://crrev.com/4c97ba8c9a34159a5951206ecacfb5db3b24cdf2/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-top-ref.html
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-nested-top.html
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/position-sticky-right.html
[modify] https://crrev.com/fd94f87e0ba9c78540e989888ae6f32e4546d184/third_party/WebKit/LayoutTests/external/wpt/css/css-position/resources/sticky-util.js

Labels: -Type-Bug Type-Task

Sign in to add a comment