New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699232 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Invisible cursor impossible

Reported by xilef...@gmail.com, Mar 7 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Add cursor: none; anywhere
2. Prevent contextmenu from opening
3. Right-click

What is the expected behavior?
Mouse cursor stays invisible

What went wrong?
Mouse cursor appears for a few ms, then gets invisible again

Did this work before? N/A 

Does this work in other browsers? No
 Firefox nightly seems fine

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 10.0
Flash Version: 

Same behaviour with cursor images

 
Labels: Needs-Triage-M56
Cc: hdodda@chromium.org
Labels: Needs-Feedback
@xilefmai-- Could you please provide us the sample test url/test case / test steps to reproduce the issue and possible help us by providing the expected result screenshot.

Thanks!

Comment 3 by xilef...@gmail.com, Mar 8 2017

I can't capture a screenshot, the cursor gets visible and flickers 1 or 2 times until it gets invisible again. Test case attached. I'm using windows 10 on a dell xps 15 9550
cursor_bug.html
132 bytes View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: ligim...@chromium.org
Labels: Needs-Bisect
Labels: -Needs-Bisect -Needs-Triage-M56 M59 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Tested on windows 10 & 7 , ubuntu 14.04 , mac os 10.12.2 using chrome M56 #56.0.2924.87 and M59 #59.0.3035.0 issue is reproduced.

Cursor is visible on the given html page and goes invisible when moved inside the page .Attached screencast for reference.

Issue is seen from M30 #30.0.1549.0 and is a non-regression issue.

Issue is also seen in Mac and linux os also.

Marking it as untraiged for further inputs on this.

Thanks!


699232.mp4
211 KB View Download
Status: Available (was: Untriaged)
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Available)
Setting this back to unconfirmed as the repro doesn't match the original bug description. I.e., the original bug states that the expected behavior is that the cursor remains invisible, and the bug is that it doesn't remain invisible on a right click. The repro states that the cursor remains invisible. 

I can't repro this on Ubuntu 14.04.5 or Mac 10.12.3 on stable version 56.0.2924.87 or canary version 59.0.3035.0
Labels: -OS-Linux -Type-Bug -Pri-2 -Needs-TestConfirmation -OS-Mac -M59 hasbisect-per-revision ReleaseBlock-Stable M58 Pri-1 Type-Bug-Regression
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 using latest canary #59.0.3041.0 but unable to reproduce the issue using chrome reported version #56.0.2924.87.

This is a win-OS specific issue. Issue is not seen in Linux and Mac.

Bisect Information:
=====================
Good build: 58.0.2994.0    Revision(446546)

Bad Build : 58.0.2995.0    Revision(446864)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/c4ac85eec321202ca4ecd56f0364dd49d9fb8236..a05a1702da44842fed11d76a18a1452c06421473

From the above change log suspecting below change

Review url: https://codereview.chromium.org/2637403012

dtapuska@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: This seems to be a recent regression. Hence, adding label ReleaseBlock-Stable.

Thanks...!!

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e40fe40d19b2c766df8d860169b11e2cacd9771

commit 7e40fe40d19b2c766df8d860169b11e2cacd9771
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Mar 16 13:37:02 2017

Remove setting the pointer cursor when the context menu event is sent.

The cursor would flash when the context menu is sent if the event is
preventDefaulted. With a change https://codereview.chromium.org/2637403012
this occurred more frequently because the move event would get suppressed.

Ultimately I found when this code was activated in
https://codereview.chromium.org/7270 and it seems it was mis-guided in
being added. I've check on Windows removing this code makes everything
work fine.

BUG= 699232 

Review-Url: https://codereview.chromium.org/2755783002
Cr-Commit-Position: refs/heads/master@{#457418}

[modify] https://crrev.com/7e40fe40d19b2c766df8d860169b11e2cacd9771/third_party/WebKit/Source/web/WebViewImpl.cpp

Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
Removing RB-Stable. This issue existed for a long time (in all versions of Chrome); it was made a little worse by my change but I don't think it necessitates a RB-Stable label.

Labels: Hotlist-Input-Dev
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e316e960818110e3c1378c75cedb6372fd2792

commit 05e316e960818110e3c1378c75cedb6372fd2792
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Mar 17 00:41:04 2017

Remove setting the pointer cursor when the context menu event is sent.

I thought I checked WebFrameWidgetImpl as well but it appears I hadn't.
Remove the useless code there as well. WebViewImpl change was originally
done in https://chromium.googlesource.com/chromium/src.git/+/7e40fe40d19b2c766df8d860169b11e2cacd9771

BUG= 699232 
R=bokan@chromium.org

Review-Url: https://codereview.chromium.org/2754003004
Cr-Commit-Position: refs/heads/master@{#457629}

[modify] https://crrev.com/05e316e960818110e3c1378c75cedb6372fd2792/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 10 using chrome dev version #59.0.3043.0 as per comment #0 and #3.

Observed that after opening the cursor_bug.html in chrome browser and applying right click the cursor appeared for a few ms, then became invisible again.
This doesn't seem to work as expected.

Attaching screen cast for reference.

dtapuska@ - Could you please verify the screen cast and please confirm the behavior.

Thanks...!!
699232.mp4
453 KB View Download
Labels: -Needs-Feedback TE-Verified-M59 TE-Verified-59.0.3044.0
It seems that fix missed chrome version #59.0.3043.0 and is available in chrome version #59.0.3044.0 revision(457648).
Observed that the fix is working as expected on windows 10 using chrome version #59.0.3044.0.

Attaching screen cast for reference.

Hence, adding the verified labels.

Thanks...!!

699232.mp4
480 KB View Download
Labels: Merge-Request-58
Labels: -M58 M59
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 18 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 20 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7826aa234283f17ebd376da3dda80ea1c31fe080

commit 7826aa234283f17ebd376da3dda80ea1c31fe080
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Mar 20 13:12:09 2017

Remove setting the pointer cursor when the context menu event is sent.

The cursor would flash when the context menu is sent if the event is
preventDefaulted. With a change https://codereview.chromium.org/2637403012
this occurred more frequently because the move event would get suppressed.

Ultimately I found when this code was activated in
https://codereview.chromium.org/7270 and it seems it was mis-guided in
being added. I've check on Windows removing this code makes everything
work fine.

BUG= 699232 

Review-Url: https://codereview.chromium.org/2755783002
Cr-Commit-Position: refs/heads/master@{#457418}
(cherry picked from commit 7e40fe40d19b2c766df8d860169b11e2cacd9771)

Review-Url: https://codereview.chromium.org/2757243002 .
Cr-Commit-Position: refs/branch-heads/3029@{#295}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7826aa234283f17ebd376da3dda80ea1c31fe080/third_party/WebKit/Source/web/WebViewImpl.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/814b1ba05c324df5e8c1499c4b22eb397b9864c8

commit 814b1ba05c324df5e8c1499c4b22eb397b9864c8
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Mar 20 13:14:54 2017

Remove setting the pointer cursor when the context menu event is sent.

I thought I checked WebFrameWidgetImpl as well but it appears I hadn't.
Remove the useless code there as well. WebViewImpl change was originally
done in https://chromium.googlesource.com/chromium/src.git/+/7e40fe40d19b2c766df8d860169b11e2cacd9771

BUG= 699232 
R=bokan@chromium.org

Review-Url: https://codereview.chromium.org/2754003004
Cr-Commit-Position: refs/heads/master@{#457629}
(cherry picked from commit 05e316e960818110e3c1378c75cedb6372fd2792)

Review-Url: https://codereview.chromium.org/2763583002 .
Cr-Commit-Position: refs/branch-heads/3029@{#296}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/814b1ba05c324df5e8c1499c4b22eb397b9864c8/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Labels: TE-Verified-M58 TE-Verified-58.0.3029.33
Observed that the fix is working as expected on windows 7 & 10 using chrome version #58.0.3029.33.

Attaching screen cast for reference.

Hence, adding the verified labels.

Thanks...!!

699232_Cl.mp4
420 KB View Download
Labels: -M59 M-59

Sign in to add a comment