New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 699230 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Replace media_router::RouteMessage with PresentationConnectionMessage

Project Member Reported by mfo...@chromium.org, Mar 7 2017 
The former is nearly identical to the latter, it should be possible to replace it.  This would save a data copy for messages arriving from the MRPM and getting passed to the RouteMessagesObserver.

We should figure out whether we need multiple message observers per route. If not, we can potentially move message contents directly via PresentationService (saving the need to make another copy).

Comment 1 by sko...@chromium.org, Mar 9 2017

Status: Available (was: Untriaged)

Comment 2 by mfo...@chromium.org, Mar 9 2017

Labels: -Hotlist-Fixit Hotlist-CodeHealth

Comment 3 by mfo...@chromium.org, May 10 2017

Labels: Hotlist-Fixit-PE2017

Comment 4 by imch...@chromium.org, Jun 30 2017

Owner: imch...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea

commit a9332ac8182d3ed2f84717e669d8a62ff8ab58ea
Author: imcheng <imcheng@chromium.org>
Date: Fri Jul 07 03:57:17 2017

[MediaRouter] Replace RouteMessage with PresentationConnectionMessage

- move ToHumanReadableString() from RouteMessage (deleted) to test_helper
- make PCM move constructor noexcept to optimize for std::move_if_noexcept in std::vector and other STL containers

TODO in future patches:
- consider making PCM move-only after xjz@'s remoting patch lands, though I am less inclined to make this optimization to overly restrict the API.
- replace RouteMessage mojo type with PCM

BUG= 699230 

Review-Url: https://codereview.chromium.org/2947403004
Cr-Commit-Position: refs/heads/master@{#484825}

[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/cast_remoting_connector.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/cast_remoting_connector.h
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/cast_remoting_connector_unittest.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/route_message_observer.h
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/common/media_router/BUILD.gn
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/chrome/common/media_router/mojo/media_router_struct_traits.h
[delete] https://crrev.com/4b357464fd8f1590de9493bd7a7f5be5870377ec/chrome/common/media_router/route_message.cc
[delete] https://crrev.com/4b357464fd8f1590de9493bd7a7f5be5870377ec/chrome/common/media_router/route_message.h
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/content/public/common/presentation_connection_message.cc
[modify] https://crrev.com/a9332ac8182d3ed2f84717e669d8a62ff8ab58ea/content/public/common/presentation_connection_message.h

Comment 6 by mfo...@chromium.org, Apr 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment