New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add TLS 1.3 specific metrics for error rates and latency.

Project Member Reported by svaldez@chromium.org, Mar 7 2017

Issue description

Adding metrics for TLS 1.3 so we can get accurate measurements in the M58 TLS 1.3 experiment.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a52e21fed09cb51aabfa18b632f754b6c9c68a21

commit a52e21fed09cb51aabfa18b632f754b6c9c68a21
Author: svaldez <svaldez@chromium.org>
Date: Thu Mar 09 17:00:25 2017

Adding new SSL Connection Error/Latency metrics

This adds TLS 1.3 specific metrics for SSL connection errors and
latency and a Google specific metric for SSL connection errors.

BUG= 699226 

Review-Url: https://codereview.chromium.org/2732103003
Cr-Commit-Position: refs/heads/master@{#455775}

[modify] https://crrev.com/a52e21fed09cb51aabfa18b632f754b6c9c68a21/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/a52e21fed09cb51aabfa18b632f754b6c9c68a21/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 13 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b437e8bec77132bde09d8116fbbc76067609e7db

commit b437e8bec77132bde09d8116fbbc76067609e7db
Author: Steven Valdez <svaldez@chromium.org>
Date: Mon Mar 13 14:15:19 2017

Adding new SSL Connection Error/Latency metrics

This adds TLS 1.3 specific metrics for SSL connection errors and
latency and a Google specific metric for SSL connection errors.

BUG= 699226 

Review-Url: https://codereview.chromium.org/2732103003
Cr-Commit-Position: refs/heads/master@{#455775}
(cherry picked from commit a52e21fed09cb51aabfa18b632f754b6c9c68a21)

Review-Url: https://codereview.chromium.org/2742373002 .
Cr-Commit-Position: refs/branch-heads/3029@{#148}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b437e8bec77132bde09d8116fbbc76067609e7db/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/b437e8bec77132bde09d8116fbbc76067609e7db/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7e2d37fded9c962ba2f3a708d10bba1237d373

commit 2d7e2d37fded9c962ba2f3a708d10bba1237d373
Author: svaldez <svaldez@chromium.org>
Date: Thu Apr 06 22:39:11 2017

Fix SSL Connection Error metrics

The original metrics used units instead of enum.

BUG= 699226 

Review-Url: https://codereview.chromium.org/2802923003
Cr-Commit-Position: refs/heads/master@{#462657}

[modify] https://crrev.com/2d7e2d37fded9c962ba2f3a708d10bba1237d373/tools/metrics/histograms/histograms.xml

Sign in to add a comment