[PresentationAPI] Remove RunLoop::Quit() from presentation unit tests |
|||||
Issue descriptionThere is a persistent pattern of manual invocation of RunLoop::Quit() in various Presentation* unittests. Instead the tests should just call RunLoop::QuitWhenIdle() in the test teardown code. As part of the cleanup we can also remove any unnecessary nested RunLoops.
,
Mar 9 2017
,
May 10 2017
,
Jun 14 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fafb67d05a69c02a39a451f36a169bd76f10f453 commit fafb67d05a69c02a39a451f36a169bd76f10f453 Author: imcheng <imcheng@chromium.org> Date: Thu Jun 15 17:30:34 2017 [PresentationService] Improve PresentationServiceImplTest. - Remove PresentationServicePtr - the unit tests should just invoke the PresentationServiceImpl directly for simplicity. This also allows us to remove the usage of RunLoop::QuitClosure and RunLoop::Run and replace with RunLoop::RunUntilIdle. - Remove a bunch of FRIEND_CLASS_TEST_PREFIX and move the Mojo PresentationService overrides to public. - Remove other unused functions in the test. BUG= 699225 Review-Url: https://codereview.chromium.org/2938023002 Cr-Commit-Position: refs/heads/master@{#479748} [modify] https://crrev.com/fafb67d05a69c02a39a451f36a169bd76f10f453/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/fafb67d05a69c02a39a451f36a169bd76f10f453/content/browser/presentation/presentation_service_impl_unittest.cc
,
Jun 15 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sko...@chromium.org
, Mar 9 2017