Regression: Views omnibox highlighting incorrectly paints scheme |
||||||
Issue descriptionChrome Version: 59.3033 OS: Windows/Linux/CrOS What steps will reproduce the problem? (1) Type about:blank in omnibox. Observe emphasis. Hit Enter. Observe emphasis changes. (2) Type chrome-extension://fake/fake in omnibox. Observe emphasis. Hit Enter. Observe emphasis changes. Regression from https://chromium.googlesource.com/chromium/src/+/addb1704b598c3f446e3d2cc1c0bab31ae0b4946 The refactoring of the code led to the loss of a conditional ((security_level_ != security_state::NONE)) from the original.
,
Mar 8 2017
Another scenario is with passive mixed content: https://mixed.badssl.com/ should show the scheme in grey, not black.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f079e7398cefd26400234c38a83630d2f5730969 commit f079e7398cefd26400234c38a83630d2f5730969 Author: elawrence <elawrence@chromium.org> Date: Thu Mar 09 17:35:07 2017 Update scheme text color in Omnibox only in non-default Security Levels A recent refactoring dropped a test from the conditional which caused the Omnibox to paint the scheme text in black in cases where it should not. Restore the conditional so that the Omnibox only colors the scheme text in the correct scenarios. BUG= 699222 TEST=Type about:blank in the omnibox and hit enter. "about:" should be grey and "blank" should be black Review-Url: https://codereview.chromium.org/2734783007 Cr-Commit-Position: refs/heads/master@{#455783} [modify] https://crrev.com/f079e7398cefd26400234c38a83630d2f5730969/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Mar 9 2017
,
Mar 10 2017
Requesting merge to M58 as the CL that introduced the regression was merged to M58 earlier this week.
,
Mar 10 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df154b0f0305d236a6d71a63a6a120bfe55b3bec commit df154b0f0305d236a6d71a63a6a120bfe55b3bec Author: Eric Lawrence <elawrence@chromium.org> Date: Fri Mar 10 17:43:28 2017 Update scheme text color in Omnibox only in non-default Security Levels A recent refactoring dropped a test from the conditional which caused the Omnibox to paint the scheme text in black in cases where it should not. Restore the conditional so that the Omnibox only colors the scheme text in the correct scenarios. BUG= 699222 TEST=Type about:blank in the omnibox and hit enter. "about:" should be grey and "blank" should be black Review-Url: https://codereview.chromium.org/2734783007 Cr-Commit-Position: refs/heads/master@{#455783} (cherry picked from commit f079e7398cefd26400234c38a83630d2f5730969) Review-Url: https://codereview.chromium.org/2742033002 . Cr-Commit-Position: refs/branch-heads/3029@{#112} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/df154b0f0305d236a6d71a63a6a120bfe55b3bec/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Mar 14 2017
Tested the issue on Windows, Ubuntu using Chrome Dev# 58.0.3029.19 and Chrome OS Platform 9334.10.0 (Official Build) dev-channel veyron_minnie using Chrome Dev# 58.0.3029.18. Navigated to about:blank and observed "about" in grey color and "blank" in black color. Hence adding TE-Verified Labels. Adding screen shot for reference. Thank You. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by elawrence@chromium.org
, Mar 7 2017