Null Pointer Exceptions when entering VR with DON flow skipped |
||||||||
Issue descriptionLooks similar to Issue 690625 , but not caused by initialization. Entering VR with the DON flow skipped results in the following stack trace as of 59.0.3032.0: 03-07 11:38:09.649 16289 16289 E AndroidRuntime: java.lang.RuntimeException: Unable to pause activity {com.chrome.canary/org.chromium.chrome.browser.ChromeTabbedActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void org.chromium.chrome.browser.tabmodel.TabModelSelector.addObserver(org.chromium.chrome.browser.tabmodel.TabModelSelectorObserver)' on a null object reference 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3752) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3718) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3692) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3666) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.-wrap16(ActivityThread.java) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1490) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:102) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.os.Looper.loop(Looper.java:154) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6121) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void org.chromium.chrome.browser.tabmodel.TabModelSelector.addObserver(org.chromium.chrome.browser.tabmodel.TabModelSelectorObserver)' on a null object reference 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at org.chromium.chrome.browser.compositor.CompositorViewHolder.attachToTabModelSelector(CompositorViewHolder.java:1000) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at org.chromium.chrome.browser.vr_shell.VrShellDelegate.shutdownVR(VrShellDelegate.java:8994) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at org.chromium.chrome.browser.vr_shell.VrShellDelegate.pauseVR(VrShellDelegate.java:592) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at org.chromium.chrome.browser.ChromeActivity.onPauseWithNative(ChromeActivity.java:41146) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at org.chromium.chrome.browser.ChromeTabbedActivity.onPauseWithNative(ChromeTabbedActivity.java:542) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at org.chromium.chrome.browser.init.AsyncInitializationActivity.onPause(AsyncInitializationActivity.java:7191) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.Activity.performPause(Activity.java:6822) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1322) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3741) 03-07 11:38:09.649 16289 16289 E AndroidRuntime: ... 11 more
,
Mar 7 2017
Users won't encounter this, but it is affecting automated testing. Also, it's possible there are other ways to hit this.
,
Mar 9 2017
,
Mar 9 2017
After some investigation, I believe it is the same reason. I'll reupload my patch.
,
Mar 13 2017
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b17535a3287b3a6e4b04e34106ee778736747312 commit b17535a3287b3a6e4b04e34106ee778736747312 Author: mthiesse <mthiesse@chromium.org> Date: Mon Mar 13 22:05:48 2017 Fix crash entering VR with debug settings on to skip DON flow. BUG= 699220 Review-Url: https://codereview.chromium.org/2747923002 Cr-Commit-Position: refs/heads/master@{#456501} [modify] https://crrev.com/b17535a3287b3a6e4b04e34106ee778736747312/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Mar 13 2017
,
Mar 1 2018
,
Mar 2 2018
,
Aug 29
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bsheedy@chromium.org
, Mar 7 2017