New issue
Advanced search Search tips

Issue 699217 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Enable Form-Not-Secure warnings in ChromeOS captive portal dialog

Project Member Reported by est...@chromium.org, Mar 7 2017

Issue description

SimpleWebViewDialog does not create an AutofillClient, so PasswordAutofillManager ends up with a null |autofill_client_|.

SimpleWebViewDialog doesn't seem to trigger any code paths in PasswordAutofillManager that use |autofill_client_| except for OnShowNotSecureWarning().

We temporarily added a null check to OnShowNotSecureWarning in https://codereview.chromium.org/2733043005/, but that doesn't seem like the right solution. We could instead create an AutofillClient for SimpleWebViewDialog to use, but that triggers other crashes (see https://codereview.chromium.org/2727813006/#msg15). We should figure out if it's possible to use the password_manager component with SimpleWebViewDialog for FNS warnings and if so, re-enable OnShowNotSecureWarning for this case.
 
Thanks for filing this. I think this change might be blocked on bug 699197 (I haven't verified, but it very much looks so because otherwise webcontents would be null everywhere).

Comment 2 by est...@chromium.org, Jul 12 2017

Status: WontFix (was: Assigned)
Closing this out because we're not planning to launch FNS right now.

Sign in to add a comment