New issue
Advanced search Search tips

Issue 699216 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Make "void WaitFor" EG methods all assert for expected conditions

Project Member Reported by eugene...@chromium.org, Mar 7 2017

Issue description

Search for "void WaitFor" in egtest files.
Most methods contain GREYAssert, but some of them don't.
Silently returning from WaitFor methods may lead to bugs like this: 
https://bugs.chromium.org/p/chromium/issues/detail?id=685439
 
Cc: liaoyuke@chromium.org huangml@chromium.org
Status: Available (was: Untriaged)
Thank you for filing.

I think another alternative is to have the method return bool, and have the test do the assert. This gives the advantage of them being able to use their own error message. It also give them the option to ignore cases where it fails (for example, waiting for a live page to load, which may not be done within timeout, though the page is ready for interaction and the test can assert something they expect to be there on the next line)
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: huangml@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Menglu, since this would probably get triaged to her anyway.  Are you the owner of these EG cleanup bugs?
Cc: -baxley@chromium.org -liaoyuke@chromium.org -huangml@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: -Type-Feature Type-Task

Sign in to add a comment