Implement a work around for Wikipedia distillation |
||||||||
Issue descriptionThis is a duplicate of crbug.com/647667 to track cherry-picking.
,
Mar 7 2017
This bug requires manual review: Less than 3 days to go before AppStore submit on M57 Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2 commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2 Author: olivierrobin <olivierrobin@chromium.org> Date: Tue Mar 07 20:07:02 2017 [Reading List] Expand all Wikipedia sections on distillation. Most part of Wikipedia articles is hidden when the page loads. DOM distiller will eventually handle this issue, but for the time being, this is a workaround. The workaround set the style to block before distilling the page. BUG=647667, 699215 Review-Url: https://codereview.chromium.org/2730863002 Cr-Commit-Position: refs/heads/master@{#455186} [modify] https://crrev.com/f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2/ios/chrome/browser/reading_list/reading_list_distiller_page.h [modify] https://crrev.com/f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2/ios/chrome/browser/reading_list/reading_list_distiller_page.mm
,
Mar 7 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2017
,
Mar 8 2017
Tested on Canary Distillation works correctly for text. Images in sections are *not* present (works as expected).
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7135f8eb25e16eadab36355f6684836122c24ef commit d7135f8eb25e16eadab36355f6684836122c24ef Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Mar 08 08:26:30 2017 [Reading List] Expand all Wikipedia sections on distillation. Most part of Wikipedia articles is hidden when the page loads. DOM distiller will eventually handle this issue, but for the time being, this is a workaround. The workaround set the style to block before distilling the page. BUG=647667, 699215 Review-Url: https://codereview.chromium.org/2730863002 Cr-Commit-Position: refs/heads/master@{#455186} (cherry picked from commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2) Review-Url: https://codereview.chromium.org/2733323004 . Cr-Commit-Position: refs/branch-heads/2987@{#799} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/d7135f8eb25e16eadab36355f6684836122c24ef/ios/chrome/browser/reading_list/reading_list_distiller_page.h [modify] https://crrev.com/d7135f8eb25e16eadab36355f6684836122c24ef/ios/chrome/browser/reading_list/reading_list_distiller_page.mm
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8 commit 3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8 Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Mar 08 08:30:55 2017 [Reading List] Expand all Wikipedia sections on distillation. Most part of Wikipedia articles is hidden when the page loads. DOM distiller will eventually handle this issue, but for the time being, this is a workaround. The workaround set the style to block before distilling the page. BUG=647667, 699215 Review-Url: https://codereview.chromium.org/2730863002 Cr-Commit-Position: refs/heads/master@{#455186} (cherry picked from commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2) Review-Url: https://codereview.chromium.org/2737743003 . Cr-Commit-Position: refs/branch-heads/3029@{#59} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8/ios/chrome/browser/reading_list/reading_list_distiller_page.h [modify] https://crrev.com/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8/ios/chrome/browser/reading_list/reading_list_distiller_page.mm
,
Mar 10 2017
Issue is fixed. Checked on chrome dev version 57.0.2987.101 on iPhone 6 plus with iOS 10.3 iPhone 7 with iOS 10.2.1 iPhone 7 plus with iOS 10.3 following the steps mentioned in #0 and issue 697887 . Verified that content under subsections are displayed in offline mode. (Images under subsections are not displayed). Headings of subsections are displayed.
,
Mar 15 2017
Issue is fixed. Checked on chrome beta version 58.0.3029.19 on iPhone 6 plus with iOS 10.3 beta 6 iPhone 6s plus with iOS 10.2.1 iPhone 7 plus with iOS 10.2.1 following the steps mentioned in #0 and issue 697887 . Verified that content under subsections are displayed in offline mode. (Images under subsections are not displayed). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by olivierrobin@chromium.org
, Mar 7 2017Labels: M-57 Merge-Request-57 Merge-Request-58 M-58