New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699215 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Implement a work around for Wikipedia distillation

Project Member Reported by olivierrobin@chromium.org, Mar 7 2017

Issue description

This is  a duplicate of crbug.com/647667 to track cherry-picking.
 
Cc: mard...@chromium.org noyau@chromium.org cma...@chromium.org
Labels: M-57 Merge-Request-57 Merge-Request-58 M-58
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Less than 3 days to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2

commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2
Author: olivierrobin <olivierrobin@chromium.org>
Date: Tue Mar 07 20:07:02 2017

[Reading List] Expand all Wikipedia sections on distillation.

Most part of Wikipedia articles is hidden when the page loads.
DOM distiller will eventually handle this issue, but for the time being, this is a workaround.
The workaround set the style to block before distilling the page.

BUG=647667,  699215 

Review-Url: https://codereview.chromium.org/2730863002
Cr-Commit-Position: refs/heads/master@{#455186}

[modify] https://crrev.com/f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2/ios/chrome/browser/reading_list/reading_list_distiller_page.h
[modify] https://crrev.com/f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2/ios/chrome/browser/reading_list/reading_list_distiller_page.mm

Project Member

Comment 4 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-57 Merge-Approved-57
Status: Fixed (was: Started)
Tested on Canary
Distillation works correctly for text.
Images in sections are *not* present (works as expected).
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7135f8eb25e16eadab36355f6684836122c24ef

commit d7135f8eb25e16eadab36355f6684836122c24ef
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Mar 08 08:26:30 2017

[Reading List] Expand all Wikipedia sections on distillation.

Most part of Wikipedia articles is hidden when the page loads.
DOM distiller will eventually handle this issue, but for the time being, this is a workaround.
The workaround set the style to block before distilling the page.

BUG=647667,  699215 

Review-Url: https://codereview.chromium.org/2730863002
Cr-Commit-Position: refs/heads/master@{#455186}
(cherry picked from commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2)

Review-Url: https://codereview.chromium.org/2733323004 .
Cr-Commit-Position: refs/branch-heads/2987@{#799}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d7135f8eb25e16eadab36355f6684836122c24ef/ios/chrome/browser/reading_list/reading_list_distiller_page.h
[modify] https://crrev.com/d7135f8eb25e16eadab36355f6684836122c24ef/ios/chrome/browser/reading_list/reading_list_distiller_page.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8

commit 3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Mar 08 08:30:55 2017

[Reading List] Expand all Wikipedia sections on distillation.

Most part of Wikipedia articles is hidden when the page loads.
DOM distiller will eventually handle this issue, but for the time being, this is a workaround.
The workaround set the style to block before distilling the page.

BUG=647667,  699215 

Review-Url: https://codereview.chromium.org/2730863002
Cr-Commit-Position: refs/heads/master@{#455186}
(cherry picked from commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2)

Review-Url: https://codereview.chromium.org/2737743003 .
Cr-Commit-Position: refs/branch-heads/3029@{#59}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8/ios/chrome/browser/reading_list/reading_list_distiller_page.h
[modify] https://crrev.com/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8/ios/chrome/browser/reading_list/reading_list_distiller_page.mm

Status: Verified (was: Fixed)
Issue is fixed.  Checked on chrome dev version 57.0.2987.101 on 
iPhone 6 plus with iOS 10.3
iPhone 7 with iOS 10.2.1
iPhone 7 plus with iOS 10.3 
following the steps mentioned in #0 and  issue 697887 .

Verified that content under subsections are displayed in offline mode. (Images under subsections are not displayed).
Headings of subsections are displayed.
Issue is fixed.  Checked on chrome beta version 58.0.3029.19 on 
iPhone 6 plus with iOS 10.3 beta 6
iPhone 6s plus with iOS 10.2.1
iPhone 7 plus with iOS 10.2.1 
following the steps mentioned in #0 and  issue 697887 .

Verified that content under subsections are displayed in offline mode. (Images under subsections are not displayed).

Sign in to add a comment