New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699213 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 692282



Sign in to add a comment

Sub-windows of a modal ServerWindow should be able receive events.

Project Member Reported by moshayedi@chromium.org, Mar 7 2017

Issue description

If a non-client frame is set to modal, its embedded sub-window should be able to receive events.

For example, creating a js modal creates a non-client frame and sets it to MODAL_TYPE_SYSTEM. Currently we cannot click on the OK inside the client window since all events are routed to the non-client frame.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8a6330d36c11874bb8aaf136f3ea4e508ae8ee

commit 5f8a6330d36c11874bb8aaf136f3ea4e508ae8ee
Author: moshayedi <moshayedi@chromium.org>
Date: Fri Mar 10 14:51:03 2017

Fix event targeting for sub-windows of system modal windows in mus+ash.

If a non-client frame is set to a system modal, its embedded sub-window
should be able to receive events.

For example, creating a JS alert() creates a non-client frame and sets it
to MODAL_TYPE_SYSTEM. Previously users couldn't click on the OK inside
the client window since all events were routed to the non-client frame.

BUG= 699213 

Review-Url: https://codereview.chromium.org/2737003002
Cr-Commit-Position: refs/heads/master@{#456058}

[modify] https://crrev.com/5f8a6330d36c11874bb8aaf136f3ea4e508ae8ee/services/ui/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/5f8a6330d36c11874bb8aaf136f3ea4e508ae8ee/services/ui/ws/modal_window_controller.cc

Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment