New issue
Advanced search Search tips

Issue 699181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

webkit_tests failing on 3 Mac builders: custom-properties/register-property-syntax-parsing.html

Project Member Reported by tmartino@chromium.org, Mar 7 2017

Issue description

webkit_tests failing on 3 builders

Builders failed on: 
- WebKit Mac10.10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10
- WebKit Mac10.11 (retina): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29
- WebKit Mac10.9: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9

Test:
custom-properties/register-property-syntax-parsing.html 

Also seeing failures on 10.11 only for:
external/wpt/editing/run/removeformat.html 

Strongly suspecting:
https://chromium.googlesource.com/chromium/src/+/06774644d8e652dd8297b14b603f237ad07394d0
 
Cc: qyears...@chromium.org
+qyearsley who was the reviewer on this automated change
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
That CL was the cause; in that CL, the auto-import removed an expectation line that it shouldn't have removed from TestExpectations:

Specifically it shouldn't have removed
- crbug.com/696903  [ Mac ] custom-properties/register-property-syntax-parsing.html [ Crash ]

https://chromium.googlesource.com/chromium/src/+/06774644d8e652dd8297b14b603f237ad07394d0%5E%21/#F0
Cc: -qyears...@chromium.org
Status: Started (was: Assigned)
This was caused by  bug 687442 .

Quick fix CL to re-add this expectation: https://codereview.chromium.org/2736063002
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8f77d07a1ef0935866b363b1bd0370954d3a3b8

commit d8f77d07a1ef0935866b363b1bd0370954d3a3b8
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Mar 07 22:08:10 2017

Re-add expectation for custom-properties/register-property-syntax-parsing.html

BUG= 699181 

Review-Url: https://codereview.chromium.org/2736063002
Cr-Commit-Position: refs/heads/master@{#455240}

[modify] https://crrev.com/d8f77d07a1ef0935866b363b1bd0370954d3a3b8/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment