New issue
Advanced search Search tips

Issue 699177 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UMA for CPU profile taken jumped 10x recently

Project Member Reported by alph@chromium.org, Mar 7 2017

Issue description

UMA for CPU profile taken jumped 10x recently and it is a fake.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e8ccb78db8330156b6ad7211a186ac1530df25

commit 84e8ccb78db8330156b6ad7211a186ac1530df25
Author: alph <alph@chromium.org>
Date: Tue Mar 07 22:20:28 2017

DevTools: Move CPU profile taken UMA from model to UI

CPU profile model is used in other places, e.g. in Peformance panel.

BUG= 699177 

Review-Url: https://codereview.chromium.org/2736053002
Cr-Commit-Position: refs/heads/master@{#455249}

[modify] https://crrev.com/84e8ccb78db8330156b6ad7211a186ac1530df25/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/84e8ccb78db8330156b6ad7211a186ac1530df25/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js

Comment 2 by alph@chromium.org, Mar 7 2017

Labels: Merge-Request-58 M-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 13 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/461e10004877d3ac33d3f6cd5d26fc27b4123600

commit 461e10004877d3ac33d3f6cd5d26fc27b4123600
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Mar 13 19:27:53 2017

DevTools: Move CPU profile taken UMA from model to UI

CPU profile model is used in other places, e.g. in Peformance panel.

BUG= 699177 

Review-Url: https://codereview.chromium.org/2736053002
Cr-Commit-Position: refs/heads/master@{#455249}
(cherry picked from commit 84e8ccb78db8330156b6ad7211a186ac1530df25)

Review-Url: https://codereview.chromium.org/2748833002 .
Cr-Commit-Position: refs/branch-heads/3029@{#160}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/461e10004877d3ac33d3f6cd5d26fc27b4123600/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/461e10004877d3ac33d3f6cd5d26fc27b4123600/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js

Comment 6 by alph@chromium.org, Mar 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment