The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f5f9f1efc1283d1bb7c284ab0798ac842265fd

commit 34f5f9f1efc1283d1bb7c284ab0798ac842265fd
Author: hamelphi <hamelphi@chromium.org>
Date: Tue Mar 07 23:18:36 2017

Revert "[Translate] Add translate ranker model loader."

This reverts commit d005809c83c0ad0b9cbbda6b10b7ed2c3dcd5120.

This CL causes regression in "Time To First Contentful Pane" for Windows and crashes for ChromeOS

BUG= 697665 , 646711, 698057,  699168 

TBR=asanka@chromium.org, groby@chromium.org, fdoray@chromium.org, rkaplow@chromium.org, sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2736853004
Cr-Commit-Position: refs/heads/master@{#455280}

[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/chrome/browser/BUILD.gn
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/chrome/browser/translate/chrome_translate_client.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/chrome/browser/translate/translate_ranker_factory.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/chrome/browser/translate/translate_ranker_factory.h
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/chrome/browser/translate/translate_ranker_metrics_provider.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/chrome/browser/translate/translate_ranker_metrics_provider.h
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/BUILD.gn
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/mock_translate_ranker.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/mock_translate_ranker.h
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/proto/BUILD.gn
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/proto/ranker_model.proto
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/proto/translate_ranker_model.proto
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/ranker_model.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/ranker_model.h
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/ranker_model_loader.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/ranker_model_loader.h
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/ranker_model_loader_unittest.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_manager.h
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_manager_unittest.cc
[add] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_ranker.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_ranker.h
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/translate_ranker_impl.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/translate_ranker_impl.h
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/components/translate/core/browser/translate_ranker_impl_unittest.cc
[add] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_ranker_metrics_provider.cc
[rename] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_ranker_metrics_provider.h
[add] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_ranker_unittest.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_ui_delegate_unittest.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/components/translate/core/browser/translate_url_fetcher.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/ios/chrome/browser/translate/translate_ranker_factory.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/ios/chrome/browser/translate/translate_ranker_factory.h
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/ios/web_view/internal/translate/BUILD.gn
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/ios/web_view/internal/translate/web_view_translate_client.mm
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
[delete] https://crrev.com/91fd02a5a3da3376ae161b8358d3a4e8e78d693e/ios/web_view/internal/translate/web_view_translate_ranker_factory.h
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/net/url_request/test_url_fetcher_factory.cc
[modify] https://crrev.com/34f5f9f1efc1283d1bb7c284ab0798ac842265fd/tools/metrics/histograms/histograms.xml

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Seems reasonable to me as a revert, we would like to get this in for the next dev for Chrome OS (build next Monday evening) if possible due to the high crash rate. 

Since this impacts other platforms I'll defer to Krishna for approval.

Before we approve merge to M58, will this be a safe revert from M58? Also is this revert looking good in Canary?

If we cannot revert in 58 can we get a Chrome branch for Chrome OS to use for a new Dev tomorrow?

Dev on Chrome OS is currently at ~10x beta/stable crash wise, and this is causing ~70% of them.

Philippe, given this merged over a day ago and this is causing some nasty crashes on CrOS, if you believe the revert to be safe at this point please go ahead and merge into R58.

If at all possible we would like to land this afternoon so we can get a new Chrome for Chrome OS built for a new dev tomorrow.

I am not familiar with the merge procedure. 
http://www.chromium.org/developers/how-tos/drover mentions that I need to be a committer. Can I still do the merge without being a committer? 
Also, I am busy teaching a seminar this PM, so I can try to do this during the break, but if it is time sensitive and someone else can take care of it, it might go more smoothly.

My understanding is that if you get an LGTM from a committer, drover should allow you to merge. 

Ok, I am trying to merge now, will update in a few minutes...

The crash did not happen in Desktop but only in CrOS. Below is the historical data of crash rate in CrOS.

59.0.3033.0	16.99%	210	
59.0.3030.0	36.81%	455	
58.0.3029.3	12.14%	150	
58.0.3028.0	17.23%	213	
58.0.3027.0	16.83%	208	

The revert mentioned in #1 landed in - 59.0.3034.0 and confirming that crash is gone in latest CroS canary - 59.0.3035.0.

More Info:
https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27policy%3A%3AUserPolicyManagerFactoryChromeOS%3A%3ACreateManagerForProfile%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports:5,productversion

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21042f6367e2c6a1b8a4207322071eeb3bec660

commit f21042f6367e2c6a1b8a4207322071eeb3bec660
Author: hamelphi <hamelphi@chromium.org>
Date: Thu Mar 09 19:16:40 2017

Revert "[Translate] Add translate ranker model loader."

This reverts commit d005809c83c0ad0b9cbbda6b10b7ed2c3dcd5120.

This CL causes regression in "Time To First Contentful Pane" for Windows and crashes for ChromeOS

BUG= 697665 , 646711, 698057,  699168 
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2736853004
Cr-Commit-Position: refs/heads/master@{#455280}
(cherry picked from commit 34f5f9f1efc1283d1bb7c284ab0798ac842265fd)

Review-Url: https://codereview.chromium.org/2738263002
Cr-Commit-Position: refs/branch-heads/3029@{#91}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/chrome/browser/BUILD.gn
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/chrome/browser/translate/chrome_translate_client.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/chrome/browser/translate/translate_ranker_factory.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/chrome/browser/translate/translate_ranker_factory.h
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/chrome/browser/translate/translate_ranker_metrics_provider.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/chrome/browser/translate/translate_ranker_metrics_provider.h
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/BUILD.gn
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/mock_translate_ranker.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/mock_translate_ranker.h
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/proto/BUILD.gn
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/proto/ranker_model.proto
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/proto/translate_ranker_model.proto
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/ranker_model.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/ranker_model.h
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/ranker_model_loader.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/ranker_model_loader.h
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/ranker_model_loader_unittest.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_manager.h
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_manager_unittest.cc
[add] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_ranker.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_ranker.h
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/translate_ranker_impl.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/translate_ranker_impl.h
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/components/translate/core/browser/translate_ranker_impl_unittest.cc
[add] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_ranker_metrics_provider.cc
[rename] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_ranker_metrics_provider.h
[add] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_ranker_unittest.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_ui_delegate_unittest.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/components/translate/core/browser/translate_url_fetcher.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/ios/chrome/browser/translate/translate_ranker_factory.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/ios/chrome/browser/translate/translate_ranker_factory.h
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/ios/web_view/internal/translate/BUILD.gn
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/ios/web_view/internal/translate/web_view_translate_client.mm
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
[delete] https://crrev.com/3d2264d80c9c0b146a6ace8046ed79cc6620d5c6/ios/web_view/internal/translate/web_view_translate_ranker_factory.h
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/net/url_request/test_url_fetcher_factory.cc
[modify] https://crrev.com/f21042f6367e2c6a1b8a4207322071eeb3bec660/tools/metrics/histograms/histograms.xml