Make custom matchers simple and if they must do extra checks, make it clear in the method name |
|||
Issue descriptionMost EarlGrey matchers should just have to match an accessibility ID, or label. For some cases, we also need to check visibility (for cases where there may be some other element present in the hierarchy, but not tappable). For example, ShowTabsButton() in chrome_matchers.mm. For this case we need to see if we can simplify the matcher, and if not, the name should be updated. In some cases we need extra checks, but if it affects the user, it should be reflected in the name of the method.
,
Mar 8 2018
,
May 31 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Mar 8 2018Status: Untriaged (was: Available)