New issue
Advanced search Search tips

Issue 699165 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Make custom matchers simple and if they must do extra checks, make it clear in the method name

Project Member Reported by baxley@chromium.org, Mar 7 2017

Issue description

Most EarlGrey matchers should just have to match an accessibility ID, or label.

For some cases, we also need to check visibility (for cases where there may be some other element present in the hierarchy, but not tappable). For example, ShowTabsButton() in chrome_matchers.mm. For this case we need to see if we can simplify the matcher, and if not, the name should be updated.

In some cases we need extra checks, but if it affects the user, it should be reflected in the name of the method.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 8 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: huangml@chromium.org
Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment