New issue
Advanced search Search tips

Issue 699160 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Make snack bars persist for accessibility services

Project Member Reported by vtsaran@chromium.org, Mar 7 2017

Issue description

Chrome Version: latest Canary build
OS: Any Android

What steps will reproduce the problem?
(1) Open Chrome and go to http://www.csun.edu/cod/conference/2017/sessions/index.php/public/presentations/view/97
(2) Start TalkBack via Settings -> Accessibility -> TalkBack.
(3) Return to Chrome and tap on the link that says "Add to Outlook / iCal". After the file is downloaded, you should hear the message that says "options are available at the bottom of the screen".
(4) Try locating the options by either swiping (linear navigation) or by dragging the finger (touch exploration) and observe the result.

What is the expected result?
It should be easy to locate the options at the bottom of the screen by either method.

What happens instead?
The options time out and disappear from the screen if you do not touch them at the exact location.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
 
Labels: NewComponent-Accessibility NewComponent-Accessibility-Compatibility
Components: UI>Accessibility>Compatibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility
Labels: triage-android-remaining
Labels: -Pri-1 Pri-2
Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)
@twellington, what do you think about increasing the timeout when accessibility is enabled?

We do increase the timeout when accessibility is enabled: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java?q=snackbar+manager&sq=package:chromium&dr=CSs&l=61

If 6 seconds isn't enough time (it does seem pretty low), we could increase it. Do you have a recommended duration?
Cc: dmazz...@chromium.org twelling...@chromium.org
Components: UI>Browser>Core
Labels: android-fe-triaged Needs-Feedback
Owner: ----
Status: Available (was: Assigned)
dmazzoni@ - do you have a recommendation on the timeout duration?

Removing owner and adding android-fe-triaged label per front-end triage process.
Owner: lethalantidote@chromium.org
Status: Assigned (was: Available)
CJ, could you take a look?
Owner: dtrainor@chromium.org
This looks more like a downloads related issue

Assigning to dtrainor@ for triage.
Cc: dtrainor@chromium.org jianli@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't think this is really a feature specific issue. There's a timeout set in SnackbarManager.java (ACCESSIBILITY_MODE_SNACKBAR_DURATION_MS) that needs to be increased. This is a one-line change so it should be really easy for anyone to pick up.

There was another request to increase the timeout to 10s in issue 883611 (the accessibility review for the offline indicator banner UI).

+jianli@ - since this seems pressing for accessibility review for your feature, maybe it makes sense for you to pick up this bug?
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b1f37cddf3d8d478ca74a4800f87d23b4f8906

commit 84b1f37cddf3d8d478ca74a4800f87d23b4f8906
Author: Jian Li <jianli@chromium.org>
Date: Fri Nov 09 00:42:58 2018

Some changes to improve snackback duration for accessibility.

Increase the default snackbar duration to 10s when accessibility
mode is on. Also make SnackbarManager to double the custom
duration automatically when accessibility mode is on.

Bug:  699160 
Change-Id: If3762db7eea56eed614ce15ff69a6591c7ae7706
Reviewed-on: https://chromium-review.googlesource.com/c/1327330
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606673}
[modify] https://crrev.com/84b1f37cddf3d8d478ca74a4800f87d23b4f8906/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
[modify] https://crrev.com/84b1f37cddf3d8d478ca74a4800f87d23b4f8906/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

Status: Fixed (was: Available)

Sign in to add a comment