New issue
Advanced search Search tips

Issue 699153 link

Starred by 6 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression

Blocking:
issue 700543
issue 735920



Sign in to add a comment

GN generates .dSYM bundles with wrong names for both .frameworks and .apps

Reported by mbl...@yandex-team.ru, Mar 7 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 YaBrowser/17.3.1.407 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Generate ninja files using "enable_dsyms = true"
2. ninja chrome

What is the expected behavior?
These debug symbols will be generated:
Chromium Framework.dSYM
Chromium.dSYM

What went wrong?
Previously when using GYP these names would be used instead:
Chromium Framework.framework.dSYM
Chromium.app.dSYM

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.12.3
Flash Version: 

Current .dSYM file names make it harder to debug Chromium, because debugger expects to find .dSYMs under different names.

 
Components: Build
Labels: TE-NeedsTriageHelp
> Current .dSYM file names make it harder to debug Chromium, because debugger expects to find .dSYMs under different names.

Last I checked, lldb found symbols using Spotlight, based on the module's LC_UUID, rather than path. I have not had issues debugging based on dSYMS produced by GN currently.

Comment 3 by thakis@chromium.org, Mar 10 2017

Blocking: 700543
> Last I checked, lldb found symbols using Spotlight, based on the module's LC_UUID, rather than path. I have not had issues debugging based on dSYMS produced by GN currently.

This partly solves the problem, but there are still two concerns:
1. Spotlight could be (partially) disabled for performance reasons. I haven't tested it recently but in the past disabling it for Chromium working directory significantly sped up compilation time.

2. Some tools could rely on dSYM names to match the frameworks/apps.

For reference, here's my proposed fix: https://codereview.chromium.org/2731313004/

Comment 5 by rsesek@chromium.org, Mar 16 2017

Re: #4: The CL will not work for the reasons I wrote on the review.

The proper way to fix this would be to pass the right name to linker_driver.py, which will require plumbing the bundle base name or output extension to the tool.
Status: WontFix (was: Unconfirmed)
rsesek@ has proposed a solution that should be fixable without modifying Chromium.

Comment 7 by thakis@chromium.org, Mar 20 2017

Labels: -Pri-2 Pri-3
Status: Available (was: WontFix)
I think this is is a valid bug. It's not super important, but it's valid.

Comment 8 by capn@chromium.org, Jun 23 2017

Blocking: 735920
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 25 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment