ContentSuggestionsMediator is an observer of the ContentSuggestionsService but most of the notification methods are noop. Make sure the notifications are propagated to the UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31069226a11b4a51b02b794fe6ca04342703a069 commit 31069226a11b4a51b02b794fe6ca04342703a069 Author: gambard <gambard@chromium.org> Date: Thu Mar 09 13:58:50 2017 Remove suggestions notified as invalid Remove from the UI the suggestions marked as invalid by the backend content suggestion service. BUG= 699124 Review-Url: https://codereview.chromium.org/2739873003 Cr-Commit-Position: refs/heads/master@{#455733} [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/content_suggestions/content_suggestions_service_bridge_observer.h [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/content_suggestions/content_suggestions_service_bridge_observer.mm [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/31069226a11b4a51b02b794fe6ca04342703a069/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f06328ee263de78077aee45fde48cefa9d3d4d5d commit f06328ee263de78077aee45fde48cefa9d3d4d5d Author: gambard <gambard@chromium.org> Date: Thu Mar 09 16:09:39 2017 Reload all ContentSuggestions on notification On backend notification, the UI must remove all displayed suggestions and reload all suggestions. BUG= 699124 Review-Url: https://codereview.chromium.org/2739153002 Cr-Commit-Position: refs/heads/master@{#455756} [modify] https://crrev.com/f06328ee263de78077aee45fde48cefa9d3d4d5d/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/f06328ee263de78077aee45fde48cefa9d3d4d5d/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/f06328ee263de78077aee45fde48cefa9d3d4d5d/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b229390f77b9f716a57e17f9c5b9d93874917f88 commit b229390f77b9f716a57e17f9c5b9d93874917f88 Author: gambard <gambard@chromium.org> Date: Tue Mar 14 10:42:04 2017 Remove categories notified as invalid Remove from the UI the categories marked as invalid by the backend content suggestion service. BUG= 699124 Review-Url: https://codereview.chromium.org/2745593002 Cr-Commit-Position: refs/heads/master@{#456668} [modify] https://crrev.com/b229390f77b9f716a57e17f9c5b9d93874917f88/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/b229390f77b9f716a57e17f9c5b9d93874917f88/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/b229390f77b9f716a57e17f9c5b9d93874917f88/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h [modify] https://crrev.com/b229390f77b9f716a57e17f9c5b9d93874917f88/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/b229390f77b9f716a57e17f9c5b9d93874917f88/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8401d78afcd1cf80cbe547f597b3bad9edf83694 commit 8401d78afcd1cf80cbe547f597b3bad9edf83694 Author: gambard <gambard@chromium.org> Date: Tue Mar 14 16:27:06 2017 Fetch Suggestions by category This CL changes the behavior of the ContentSuggestions fetching. Instead of throwing away all the suggestions and reloading the new ones, the data sink only loads new suggestions if they are in an empty category. BUG= 699124 Review-Url: https://codereview.chromium.org/2751713002 Cr-Commit-Position: refs/heads/master@{#456725} [modify] https://crrev.com/8401d78afcd1cf80cbe547f597b3bad9edf83694/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/8401d78afcd1cf80cbe547f597b3bad9edf83694/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/8401d78afcd1cf80cbe547f597b3bad9edf83694/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h [modify] https://crrev.com/8401d78afcd1cf80cbe547f597b3bad9edf83694/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a87cbc4fe0ad88df511929517797a10b9879361 commit 3a87cbc4fe0ad88df511929517797a10b9879361 Author: gambard <gambard@chromium.org> Date: Wed Mar 15 15:14:04 2017 ContentSuggestions collection adds items with animation This CL changes the ContentSuggestions collection to add items with an animation instead of reloading the entire collection. BUG= 699124 , 700296 Review-Url: https://codereview.chromium.org/2741343005 Cr-Commit-Position: refs/heads/master@{#457083} [modify] https://crrev.com/3a87cbc4fe0ad88df511929517797a10b9879361/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/3a87cbc4fe0ad88df511929517797a10b9879361/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/3a87cbc4fe0ad88df511929517797a10b9879361/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/3a87cbc4fe0ad88df511929517797a10b9879361/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
Comment 1 by bugdroid1@chromium.org
, Mar 9 2017