Issue metadata
Sign in to add a comment
|
Magenta/green color seen when video has border-radius
Reported by
jleedev@gmail.com,
Mar 7 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.88 Safari/537.36 Example URL: https://gfycat.com/EnormousValuableGar Steps to reproduce the problem: Open a video that has border-radius set. What is the expected behavior? What went wrong? The video shows in magenta/green colors. Did this work before? Yes 451446 Is it a problem with Flash or HTML5? N/A Does this work in other browsers? N/A Chrome version: 58.0.3017.0 Channel: canary OS Version: OS X 10.12.3 Flash Version: Contents of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Hardware accelerated Rasterization: Hardware accelerated Video Decode: Hardware accelerated Video Encode: Hardware accelerated VPx Video Decode: Hardware accelerated WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds add_and_true_to_loop_condition adjust_src_dst_region_for_blitframebuffer decode_encode_srgb_for_generatemipmap disable_framebuffer_cmaa disable_multimonitor_multisampling disable_webgl_rgb_multisampling_usage emulate_abs_int_function get_frag_data_info_bug init_two_cube_map_levels_before_copyteximage msaa_is_slow pack_parameters_workaround_with_pack_buffer rebind_transform_feedback_before_resume regenerate_struct_names remove_invariant_and_centroid_for_essl3 reset_base_mipmap_level_before_texstorage rewrite_texelfetchoffset_to_texelfetch scalarize_vec_and_mat_constructor_args set_zero_level_before_generating_mipmap swizzle_rgba_for_async_readpixels unfold_short_circuit_as_ternary_operation unpack_alignment_workaround_with_unpack_buffer unpack_image_height_workaround_with_unpack_buffer use_intermediary_for_copy_texture_image use_unused_standard_shared_blocks Problems Detected Async Readpixels with GL_BGRA format is broken on Haswell chipset on Macs: 265115 Applied Workarounds: swizzle_rgba_for_async_readpixels Multisampling is buggy on OSX when multiple monitors are connected: 237931 Applied Workarounds: disable_multimonitor_multisampling Unfold short circuit on Mac OS X: 307751 Applied Workarounds: unfold_short_circuit_as_ternary_operation Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args Mac drivers handle struct scopes incorrectly: 403957 Applied Workarounds: regenerate_struct_names On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499 Applied Workarounds: set_zero_level_before_generating_mipmap Pack parameters work incorrectly with pack buffer bound: 563714 Applied Workarounds: pack_parameters_workaround_with_pack_buffer Alignment works incorrectly with unpack buffer bound: 563714 Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777 Applied Workarounds: use_intermediary_for_copy_texture_image Multisample renderbuffers with format GL_RGB8 have performance issues on Intel GPUs.: 607130 Applied Workarounds: disable_webgl_rgb_multisampling_usage Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa glGetFragData{Location|Index} works incorrectly on Max: 638340 Applied Workarounds: get_frag_data_info_bug glResumeTransformFeedback works incorrectly on Intel GPUs: 638514 Applied Workarounds: rebind_transform_feedback_before_resume glTexStorage* are buggy when base mipmap level is not 0: 640506 Applied Workarounds: reset_base_mipmap_level_before_texstorage Result of abs(i) where i is an integer in vertex shader is wrong: 642227 Applied Workarounds: emulate_abs_int_function Rewrite texelFetchOffset to texelFetch for Intel Mac: 642605 Applied Workarounds: rewrite_texelfetchoffset_to_texelfetch Rewrite condition in for and while loops for Intel Mac: 644669 Applied Workarounds: add_and_true_to_loop_condition Decode and encode before generateMipmap for srgb format textures on macosx: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap Init first two levels before CopyTexImage2D for cube map texture on Intel Mac 10.12: 648197 Applied Workarounds: init_two_cube_map_levels_before_copyteximage Insert statements to reference all members in unused std140/shared blocks on Mac: 618464 Applied Workarounds: use_unused_standard_shared_blocks Tex(Sub)Image3D performs incorrectly when uploading from unpack buffer with GL_UNPACK_IMAGE_HEIGHT greater than zero on Intel Macs: 654258 Applied Workarounds: unpack_image_height_workaround_with_unpack_buffer adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740 Applied Workarounds: adjust_src_dst_region_for_blitframebuffer Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129 Applied Workarounds: remove_invariant_and_centroid_for_essl3 Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Version Information Data exported 3/7/2017, 11:07:29 AM Chrome version Chrome/58.0.3017.0 Operating system Mac OS X 10.12.3 Software rendering list version 12.14 Driver bug list version 9.30 ANGLE commit id abe89c7d32d7 2D graphics backend Skia/58 7fc4a2d2f0eb57f94f5ef9a0f759a099a4320a54 Command Line Args 451448.app/Contents/MacOS/Chromium --flag-switches-begin --flag-switches-end Driver Information Initialization time 99 In-process GPU false Passthrough Command Decoder false Sandboxed true GPU0 VENDOR = 0x8086, DEVICE= 0x0a26 *ACTIVE* Optimus false AMD switchable false Driver vendor Driver version 10.22.29 Driver date Pixel shader version 4.10 Vertex shader version 4.10 Max. MSAA samples 8 Machine model name MacBookAir Machine model version 6.1 GL_VENDOR Intel Inc. GL_RENDERER Intel HD Graphics 5000 OpenGL Engine GL_VERSION 4.1 INTEL-10.22.29 GL_EXTENSIONS GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Window system binding vendor Window system binding version Window system binding extensions Direct rendering Yes Reset notification strategy 0x0000 GPU process crash count 0 Compositor Information Tile Update Mode Zero-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 GPU_READ, SCANOUT BGRX_8888 GPU_READ, SCANOUT BGRA_8888 GPU_READ, SCANOUT, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT YVU_420 Software only YUV_420_BIPLANAR GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT UYVY_422 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT Broken by https://chromium.googlesource.com/chromium/src/+/ecdfdf5b38b44e99023608dac72afa4f6d293d8a
,
Mar 7 2017
I can reproduce this on Canary and ToT
,
Mar 7 2017
FYI: I tried this on Linux and was not able to reproduce it. (tried Stable, ToT and ToT + video-color-management)
,
Mar 7 2017
Issue 698860 has been merged into this issue.
,
Mar 7 2017
Issue 698977 has been merged into this issue.
,
Mar 7 2017
The bug here is YUV to RGB conversion is being double-applied. Fix at https://codereview.chromium.org/2734223002/
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7100c1b09f742260b741c1cd717b8f449e0f8eb2 commit 7100c1b09f742260b741c1cd717b8f449e0f8eb2 Author: ccameron <ccameron@chromium.org> Date: Tue Mar 07 22:46:26 2017 cc: Don't apply YUV color conversion to non-YUV draw quads Some video frames are passed as RGBA textures to the compositor. RGBA conversion is done beforehand in various ways (for 422 textures, this can be done in hardware at texture fetch time, for 420 textures, this has to be done manually in the command buffer bowels). The root problem is that, despite the fact that YUV to RGB conversion has been applied, these textures are tagged with a YUV color space. The full fix is to audit all of the places where TextureMailboxes are populated by media code, and ensure that the ColorSpace attached to the mailbox is the ColorSpace that we will get from texturing out of the resource we create from the TextureMailbox. For the moment, fix this regression by ensuring that no color conversion be applied to any DrawQuads except for YUV video draw quads. BUG= 699123 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2734223002 Cr-Commit-Position: refs/heads/master@{#455265} [modify] https://crrev.com/7100c1b09f742260b741c1cd717b8f449e0f8eb2/cc/output/gl_renderer.cc
,
Mar 7 2017
Just tried r455269 which includes the fix in #7 and cannot repro https://crbug.com/698860 , thanks ccameron@ !
,
Mar 9 2017
,
Mar 11 2017
Should this be merged to 58?
,
Mar 13 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d638daebc3bb80e2af81c2e3a80eb5009b34bb09 commit d638daebc3bb80e2af81c2e3a80eb5009b34bb09 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Mar 13 07:48:20 2017 cc: Don't apply YUV color conversion to non-YUV draw quads Some video frames are passed as RGBA textures to the compositor. RGBA conversion is done beforehand in various ways (for 422 textures, this can be done in hardware at texture fetch time, for 420 textures, this has to be done manually in the command buffer bowels). The root problem is that, despite the fact that YUV to RGB conversion has been applied, these textures are tagged with a YUV color space. The full fix is to audit all of the places where TextureMailboxes are populated by media code, and ensure that the ColorSpace attached to the mailbox is the ColorSpace that we will get from texturing out of the resource we create from the TextureMailbox. For the moment, fix this regression by ensuring that no color conversion be applied to any DrawQuads except for YUV video draw quads. BUG= 699123 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2734223002 Cr-Commit-Position: refs/heads/master@{#455265} (cherry picked from commit 7100c1b09f742260b741c1cd717b8f449e0f8eb2) Review-Url: https://codereview.chromium.org/2746863002 . Cr-Commit-Position: refs/branch-heads/3029@{#140} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/d638daebc3bb80e2af81c2e3a80eb5009b34bb09/cc/output/gl_renderer.cc
,
Mar 13 2017
Should be fixed in M58 now.
,
Mar 13 2017
(err, at the next build)
,
Mar 14 2017
Re-checked the issue on Latest Dev# 58.0.3029.19 on Mac OS X 10.12.2 and found to be fixed. The video is displayed clearly when border radius is checked/unchecked. Hence adding TE-Verified Labels. Note: Adding screen cast for reference. Issue is also not seen in Windows and Linux. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dalecur...@chromium.org
, Mar 7 2017