New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699120 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 705791
issue 705792
issue 709260
issue 709403
issue 713267

Blocking:
issue 693058



Sign in to add a comment

Rewrite recipe tests command

Project Member Reported by phajdan.jr@chromium.org, Mar 7 2017

Issue description

Rewrite recipe tests command

- make it easier to make changes necessary for strict recipe modules coverage ( issue 693058 )
- less code, less layers of indirection
- preparation for better JSON output for more robust downstream recipe trybot
- overall robustness improvements (CLs will follow)

Initial CL: https://codereview.chromium.org/2721613004/ .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/42fb1824a16988676c015741261cdeedf84c5a45

commit 42fb1824a16988676c015741261cdeedf84c5a45
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Mar 07 16:14:25 2017

Remove buildbot recipe module (unused)

This was found with new recipe simulation command
I've been working on.

BUG= 699120 

Change-Id: I3f4e05d43e399bce0b56c15fa93b972d2cdab0ec
Reviewed-on: https://chromium-review.googlesource.com/451420
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[delete] https://crrev.com/afb983f4769e6e0ff732fafd4349152eebf7f130/scripts/slave/recipe_modules/buildbot/__init__.py
[delete] https://crrev.com/afb983f4769e6e0ff732fafd4349152eebf7f130/scripts/slave/recipe_modules/buildbot/api.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0e9959c1e1d9d2858b8298171204d3a7728ac054

commit 0e9959c1e1d9d2858b8298171204d3a7728ac054
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Mar 07 16:17:12 2017

Remove conda recipe module (unused)

This was found with new recipe simulation command
I've been working on.

BUG= 699120 

Change-Id: I0b352555ebf0a3231328ff0ebc5d82b7c0b8ab49
Reviewed-on: https://chromium-review.googlesource.com/451381
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[delete] https://crrev.com/42fb1824a16988676c015741261cdeedf84c5a45/scripts/slave/recipe_modules/conda/api.py
[delete] https://crrev.com/42fb1824a16988676c015741261cdeedf84c5a45/scripts/slave/recipe_modules/conda/__init__.py
[delete] https://crrev.com/42fb1824a16988676c015741261cdeedf84c5a45/scripts/slave/recipe_modules/conda/resources/butcher_conda.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3b1448ea08d51a8ac9e3f6c18d172c9ef04cc942

commit 3b1448ea08d51a8ac9e3f6c18d172c9ef04cc942
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Mar 07 16:17:44 2017

Remove unused omahaproxy recipe module (moved to infra repo)

Also see https://chromium-review.googlesource.com/c/451321/

Note that this was found with new recipe simulation command
I've been working on.

BUG= 699120 

Change-Id: I4617869c3b7454dce88f685b9a154038db30f99f
Reviewed-on: https://chromium-review.googlesource.com/451419
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[delete] https://crrev.com/0e9959c1e1d9d2858b8298171204d3a7728ac054/scripts/slave/recipe_modules/omahaproxy/api.py
[delete] https://crrev.com/0e9959c1e1d9d2858b8298171204d3a7728ac054/scripts/slave/recipe_modules/omahaproxy/__init__.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/742adbd76f8d4c730866ba02d2e4b71524ce9049

commit 742adbd76f8d4c730866ba02d2e4b71524ce9049
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Mon Mar 20 20:16:29 2017

Run new recipes 'test' command

BUG= chromium:699120 

Change-Id: Ie498bec2e2e38cbde8fac6409b13d2032b2e1a1b
Reviewed-on: https://chromium-review.googlesource.com/457318
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/742adbd76f8d4c730866ba02d2e4b71524ce9049/tests/recipes_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/742adbd76f8d4c730866ba02d2e4b71524ce9049

commit 742adbd76f8d4c730866ba02d2e4b71524ce9049
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Mon Mar 20 20:16:29 2017

Run new recipes 'test' command

BUG= chromium:699120 

Change-Id: Ie498bec2e2e38cbde8fac6409b13d2032b2e1a1b
Reviewed-on: https://chromium-review.googlesource.com/457318
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/742adbd76f8d4c730866ba02d2e4b71524ce9049/tests/recipes_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a14699eda6eb7971c71167d36901e2a374f6b744

commit a14699eda6eb7971c71167d36901e2a374f6b744
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Mon Mar 20 20:40:13 2017

Remove old recipe expectations

Detected using new recipe engine 'test' command (see bug
and https://codereview.chromium.org/2758923002/)

BUG= 699120 

Change-Id: I7416e8aed2248704b2d5467d6d85f14a59746f69
Reviewed-on: https://chromium-review.googlesource.com/456706
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/basic_return_code_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/basic.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/broken_good_revision_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a14699eda6eb7971c71167d36901e2a374f6b744

commit a14699eda6eb7971c71167d36901e2a374f6b744
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Mon Mar 20 20:40:13 2017

Remove old recipe expectations

Detected using new recipe engine 'test' command (see bug
and https://codereview.chromium.org/2758923002/)

BUG= 699120 

Change-Id: I7416e8aed2248704b2d5467d6d85f14a59746f69
Reviewed-on: https://chromium-review.googlesource.com/456706
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/basic_return_code_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/basic.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect.expected/broken_good_revision_test.json
[delete] https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75/scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2017

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1f580164c505a6d5f4c80c1a298cdb461e3fafdc

commit 1f580164c505a6d5f4c80c1a298cdb461e3fafdc
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Mar 21 22:08:17 2017

Remove unused recipe expectations

This was detected by the new 'test' command, see bug.

BUG= 699120 

Change-Id: I622b68e26f4b156086300b6c9a5c417bb570c3c1
Reviewed-on: https://chromium-review.googlesource.com/456289
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_1m_SKPs_2slaves_failure.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/recipe_with_gerrit_patch.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Release-RemoteRun.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_IMG_DECODE_10k_SKPs_Trybot.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_1m_SKPs_slave3_failure.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_CPU_BENCH_10k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_1m_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win-MSVC-x86_64-Release-Vulkan.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_100k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/No_downloaded_SKP_VERSION.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_win_toolchain.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Housekeeper-PerCommit.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Release-Trybot.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_GPU_BENCH_1k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_android_sdk.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Debug.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_GPU_BENCH_10k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Mac-Clang-x86_64-Release.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Infra-PerCommit.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_IMG_DECODE_100k_SKPs.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-Arm64-Debug-Android_Vulkan.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Missing_android_sdk_hash.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win-MSVC-x86_64-Release.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_Trybot.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skp_version.json
[delete] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleA-GPU-HD7770-x86_64-Release.json

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/78eaaf5947ea93387ec9ff7c578bf32676500194

commit 78eaaf5947ea93387ec9ff7c578bf32676500194
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Mar 22 07:47:10 2017

Run new recipes 'test' command

Also see depot_tools CL https://chromium-review.googlesource.com/c/457318/ .

BUG= chromium:699120 

Change-Id: I8dce4dd7139802e74dc383a861a9579a5b17b971
Reviewed-on: https://chromium-review.googlesource.com/457537
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[add] https://crrev.com/78eaaf5947ea93387ec9ff7c578bf32676500194/scripts/slave/unittests/recipe_test.py

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/028b15146a3dc00629e4db0cd7012e2d36bf7121

commit 028b15146a3dc00629e4db0cd7012e2d36bf7121
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Mar 22 17:39:30 2017

Run new recipes 'test' command

Also see depot_tools CL https://chromium-review.googlesource.com/c/457318/
and build https://chromium-review.googlesource.com/c/457537/ .

In the infra repo, recipe tests are run on trybots.

BUG= chromium:699120 

Change-Id: I17dc0fc430492249c2c45c5b6629de2fb85564c6
Reviewed-on: https://chromium-review.googlesource.com/458218
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_go.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_DEPS.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_glyco_python.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.py
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/basic.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_python.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_js.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/rietveld_tests.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/basic_gerrit.json

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/028b15146a3dc00629e4db0cd7012e2d36bf7121

commit 028b15146a3dc00629e4db0cd7012e2d36bf7121
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Mar 22 17:39:30 2017

Run new recipes 'test' command

Also see depot_tools CL https://chromium-review.googlesource.com/c/457318/
and build https://chromium-review.googlesource.com/c/457537/ .

In the infra repo, recipe tests are run on trybots.

BUG= chromium:699120 

Change-Id: I17dc0fc430492249c2c45c5b6629de2fb85564c6
Reviewed-on: https://chromium-review.googlesource.com/458218
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_go.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_DEPS.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_glyco_python.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.py
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/basic.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_python.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/only_js.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/rietveld_tests.json
[modify] https://crrev.com/028b15146a3dc00629e4db0cd7012e2d36bf7121/recipes/recipes/infra_repo_trybot.expected/basic_gerrit.json

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 22 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f14709556d5d51394ac8f7d603d14795eba2c883

commit f14709556d5d51394ac8f7d603d14795eba2c883
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Fri Mar 24 08:32:52 2017

Move recipes to their own subdirectory

This will help remove confusion when depot_tools' recipes.py
ends up in PATH.

BUG= 699120 

Change-Id: Id4c21b0cc6bb022ea2c21145abe76bebb0a8d9c1
Reviewed-on: https://chromium-review.googlesource.com/458430
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/count-objects_with_bad_output.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gsutil/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_v8.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/test_api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gsutil/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/presubmit/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/presubmit/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/clobber.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/__init__.py
[modify] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/infra/config/recipes.cfg
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gerrit/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/presubmit/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/basic_with_branch_heads.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_fail.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/resources/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/rietveld/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/basic_ref.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/presubmit/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_kitchen_win.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/basic_tags.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/count-objects_delta.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_wrong_patch_new.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/can_fail_build.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/no_shallow.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/config.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/basic_submodule_update_force.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/presubmit/bundle_extra_paths.txt
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/cannot_fail_build.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_swarmbucket_mac.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_kitchen_linux.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/rietveld/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/trychange_oauth2_json.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/rebase_failed.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/rietveld/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/trychange.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/apply_gerrit_ref.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_swarmbucket_linux.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/mac64.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/basic_hash.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gerrit/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_rietveld_patch.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/set_got_revision.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_git_patch.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git_cl/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/buildbot.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gsutil/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/resources/apply_gerrit.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_swarmbucket_win.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/set_failure_hash_with_no_steps.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/bundle_extra_paths.txt
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/test_api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/pkg_bad_file.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_gerrit_patch_deprecated.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/trychange_oauth2.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/OWNERS
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/example.expected/revision.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/rietveld/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/resources/git_setup.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/platform_win.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/depot_tools/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/describe-failed.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/pkg_bad_verfile.json
[modify] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/.gitignore
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/resources/bot_update.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/trychange_oauth2_buildbot.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipes.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle_deprecated.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/rietveld/example.expected/buildbot.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git_cl/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_buildbot_linux.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git_cl/config.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/example.expected/tryserver.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/test_api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/describe-many-instances.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/test_api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gerrit/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_kitchen_mac.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_gerrit_patch.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/basic_branch.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git_cl/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git_cl/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_buildbot_win.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/example.py
[modify] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/tests/recipes_test.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/basic_pkg.json
[modify] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/tests/bot_update_coverage_test.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/depot_tools/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gerrit/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/depot_tools/example.expected/win.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/trychange_oauth2_json_win.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gclient/example.expected/buildbot.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/basic_file_name.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/pkg_bad_mode.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/gerrit_no_reset.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gsutil/resources/gsutil_smart_retry.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gsutil/api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/depot_tools/example.expected/basic.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/depot_tools/example.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_wrong_patch.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/example.expected/paths_buildbot_mac.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/infra_paths/path_config.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/cipd/example.expected/win64.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/basic_output_manifest.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/git-cache-checkout.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/remote_not_origin.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/bundle_extra_paths.txt
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/cat-file_test.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/tryserver/example.expected/with_git_patch_luci.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/count-objects_failed.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/gerrit/test_api.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/__init__.py
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/git/example.expected/curl_trace_file.json
[rename] https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883/recipes/recipe_modules/bot_update/example.expected/reset_root_solution_revision.json

Project Member

Comment 16 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f83e262e6d10b480df069129c3eddfab0a22c4b7

commit f83e262e6d10b480df069129c3eddfab0a22c4b7
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Fri Mar 24 09:42:11 2017

Adjust paths in bot_update.py after moving recipes to subdir

Bug:  699120 , 704864
Change-Id: Iea62a8382ae2553af3f080f07358de53c278ad7c
Reviewed-on: https://chromium-review.googlesource.com/459496
Reviewed-by: Emma Söderberg <emso@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/f83e262e6d10b480df069129c3eddfab0a22c4b7/recipes/recipe_modules/bot_update/resources/bot_update.py

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e7de363248f87ec5e004375edb55d4ff4a148c3c

commit e7de363248f87ec5e004375edb55d4ff4a148c3c
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Fri Mar 24 09:45:27 2017

Manually roll recipes.cfg

TBR=iannucci

Bug:  699120 , 704864
Change-Id: If88d97639f4be5beed9f06059efa2a5258dde868
Reviewed-on: https://chromium-review.googlesource.com/459417
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/e7de363248f87ec5e004375edb55d4ff4a148c3c/infra/config/recipes.cfg

Blockedon: 705791 705792
Blockedon: 709260

Comment 20 by whesse@google.com, Apr 7 2017

Blockedon: 709403
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e399682750f09d8a34cc71026e42fe3a1628c394

commit e399682750f09d8a34cc71026e42fe3a1628c394
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Apr 11 06:09:34 2017

Stop running deprecated simulation_test

See https://codereview.chromium.org/2808833003/
for context.

Bug:  699120 ,  693058 
Change-Id: I3a293f6abb520e99b9c4a754fb7698b6b24a458f
Reviewed-on: https://chromium-review.googlesource.com/474146
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/only_go.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/only_DEPS.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/only_cipd_build.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.py
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/basic.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/only_python.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/only_js.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/rietveld_tests.json
[modify] https://crrev.com/e399682750f09d8a34cc71026e42fe3a1628c394/recipes/recipes/infra_repo_trybot.expected/basic_gerrit.json

Project Member

Comment 22 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/ec576ecfa26321ab363cf5e97fe2cdaef67b3b6e

commit ec576ecfa26321ab363cf5e97fe2cdaef67b3b6e
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Apr 11 06:10:23 2017

Stop running deprecated simulation_test

See https://codereview.chromium.org/2808833003/
for context.

Bug:  699120 ,  693058 
Change-Id: I1420c347d4ae2bac8bea54bc1b921fe6b65e6161
Reviewed-on: https://chromium-review.googlesource.com/474027
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/ec576ecfa26321ab363cf5e97fe2cdaef67b3b6e/tests/recipes_test.py

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/124bc90e599bdf6f1183e3a3fadac770b46615c1

commit 124bc90e599bdf6f1183e3a3fadac770b46615c1
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Apr 11 06:12:04 2017

Stop running deprecated simulation_test

See https://codereview.chromium.org/2808833003/
for context.

Bug:  699120 ,  693058 
Change-Id: I44485f66879c6203eb83f91126099186aad40554
Reviewed-on: https://chromium-review.googlesource.com/474126
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/124bc90e599bdf6f1183e3a3fadac770b46615c1/scripts/slave/unittests/recipe_test.py

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fcaa6d436eaebb15f439f01cbda2bbb19172b77a

commit fcaa6d436eaebb15f439f01cbda2bbb19172b77a
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Fri Apr 14 18:49:38 2017

Migrate remaining references to 'simulation_test'

Bug:  699120 
Change-Id: I2d7c13d864c23ba2791cd7cc1af2e66f10c7bc7e
Reviewed-on: https://chromium-review.googlesource.com/478210
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tree_simulation.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_simulation.expected/normal.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob_with_unicode.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob_dont_test_untouched_code.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_simulation.py
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipe_modules/recipe_tryjob/api.py
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/deps.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_simulation.expected/with_auth.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob_with_numbers.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/one_patch.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/three_patches.json

Project Member

Comment 25 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fcaa6d436eaebb15f439f01cbda2bbb19172b77a

commit fcaa6d436eaebb15f439f01cbda2bbb19172b77a
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Fri Apr 14 18:49:38 2017

Migrate remaining references to 'simulation_test'

Bug:  699120 
Change-Id: I2d7c13d864c23ba2791cd7cc1af2e66f10c7bc7e
Reviewed-on: https://chromium-review.googlesource.com/478210
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tree_simulation.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_simulation.expected/normal.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob_with_unicode.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob_dont_test_untouched_code.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_simulation.py
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipe_modules/recipe_tryjob/api.py
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/deps.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_simulation.expected/with_auth.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob_with_numbers.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/one_patch.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/tryjob.json
[modify] https://crrev.com/fcaa6d436eaebb15f439f01cbda2bbb19172b77a/recipes/recipes/recipe_roll_tryjob.expected/three_patches.json

Blockedon: 713267
How do I train expectations now?
Maybe `scripts/slave/recipes.py test train`? (`recipes.py test -h` doesn't print anything useful)
Yup, that's right.
Status: Fixed (was: Started)

Sign in to add a comment